Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[matrix-ui] Submit Job modal should validate input before submission #754

New Issue
Closed
opened 2026-03-21 18:04:20 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-21 18:04:20 +00:00
Owner
Copy Link

What to implement

Add client-side validation to the Submit Job modal:

  • Prevent empty submissions
  • Warn if input is too long (e.g., > 2000 chars)
  • Show inline validation messages

Files likely needing changes

  • src/components/SubmitJob.jsx or similar — add validation logic
  • src/styles/ — error/warning message styling

Acceptance criteria

  • Submit button disabled when input is empty
  • Character count shown near input
  • Warning displayed if input exceeds max length
  • Inline error messages (red text) for validation failures
  • Validation runs on blur and on submit attempt
## What to implement Add client-side validation to the Submit Job modal: - Prevent empty submissions - Warn if input is too long (e.g., > 2000 chars) - Show inline validation messages ## Files likely needing changes - `src/components/SubmitJob.jsx` or similar — add validation logic - `src/styles/` — error/warning message styling ## Acceptance criteria - [ ] Submit button disabled when input is empty - [ ] Character count shown near input - [ ] Warning displayed if input exceeds max length - [ ] Inline error messages (red text) for validation failures - [ ] Validation runs on blur and on submit attempt
kimi was assigned by Timmy 2026-03-21 18:04:20 +00:00
kimi added this to the Matrix Staging milestone 2026-03-21 20:24:34 +00:00
kimi commented 2026-03-21 22:14:02 +00:00
Collaborator
Copy Link

PR created: #832

Implementation Summary

Added a Submit Job modal to the Matrix 3D workshop UI with comprehensive client-side validation as specified:

✅ Acceptance Criteria Met

  • Submit button disabled when input is empty
  • Character count shown near input (title: 0/200, description: 0/2000)
  • Warning displayed if input exceeds max length (amber at >1800 chars, red error at >2000)
  • Inline error messages (red text) for validation failures
  • Validation runs on blur and on submit attempt (also on input for real-time feedback)

Additional Features

  • Submit Job button with plus icon in top-right corner
  • Modal with title, description (textarea), and priority (dropdown) fields
  • Success state with confirmation message after submission
  • Keyboard accessible (Escape to close, focus management)
  • Responsive design for mobile devices
  • API integration to /api/tasks endpoint
  • Follows existing Matrix UI styling (gold accents, dark theme)

Files Changed

  • static/world/index.html - Modal HTML structure and JavaScript validation logic
  • static/world/style.css - Modal styling, form elements, validation states, responsive adjustments

All tests pass (2832 passed).

PR created: #832 ## Implementation Summary Added a Submit Job modal to the Matrix 3D workshop UI with comprehensive client-side validation as specified: ### ✅ Acceptance Criteria Met - [x] Submit button disabled when input is empty - [x] Character count shown near input (title: 0/200, description: 0/2000) - [x] Warning displayed if input exceeds max length (amber at >1800 chars, red error at >2000) - [x] Inline error messages (red text) for validation failures - [x] Validation runs on blur and on submit attempt (also on input for real-time feedback) ### Additional Features - Submit Job button with plus icon in top-right corner - Modal with title, description (textarea), and priority (dropdown) fields - Success state with confirmation message after submission - Keyboard accessible (Escape to close, focus management) - Responsive design for mobile devices - API integration to `/api/tasks` endpoint - Follows existing Matrix UI styling (gold accents, dark theme) ### Files Changed - `static/world/index.html` - Modal HTML structure and JavaScript validation logic - `static/world/style.css` - Modal styling, form elements, validation states, responsive adjustments All tests pass (2832 passed).
kimi closed this issue 2026-03-21 22:14:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone Matrix Staging
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#754
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?