Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[triage-generated] [bug] [P0] cycle_result.json consume-once fix from #660 never landed on main — loop metrics still poisoned #897

New Issue
Closed
opened 2026-03-22 01:32:41 +00:00 by Timmy · 0 comments
Timmy commented 2026-03-22 01:32:41 +00:00
Owner
Copy Link

Problem

Issue #660 was closed on 2026-03-20 with a comment claiming the consume-once fix was already on main. This is incorrect. Verification shows main's scripts/cycle_retro.py has NO unlink/delete/consume logic for cycle_result.json.

Meanwhile .loop/cycle_result.json still contains {"issue": 603, ...} — a stale result from a long-closed issue. Every cycle reads this file, backfills issue=603, and records a failure. This has been happening for 1000+ cycles.

Root Cause

_load_cycle_result() in scripts/cycle_retro.py reads the file but never deletes it after successful consumption.

Fix Required

In scripts/cycle_retro.py, after the cr = _load_cycle_result() block (~line 270-278), add:

    # Consume-once: delete after reading
    if cr:
        CYCLE_RESULT_FILE.unlink(missing_ok=True)

Also add a guard: if the issue from cycle_result.json is closed, skip it.

Acceptance Criteria

  1. After a cycle runs, cycle_result.json is deleted (not just read)
  2. retro/summary.json stops showing 0% success rate within 50 cycles
  3. Closed issues are never backfilled from stale cycle_result.json

Files

  • scripts/cycle_retro.py (lines 250-278)

Immediate Mitigation

Delete the stale file now: rm .loop/cycle_result.json

## Problem Issue #660 was closed on 2026-03-20 with a comment claiming the consume-once fix was already on main. **This is incorrect.** Verification shows main's `scripts/cycle_retro.py` has NO unlink/delete/consume logic for cycle_result.json. Meanwhile `.loop/cycle_result.json` still contains `{"issue": 603, ...}` — a stale result from a long-closed issue. Every cycle reads this file, backfills issue=603, and records a failure. This has been happening for 1000+ cycles. ## Root Cause `_load_cycle_result()` in `scripts/cycle_retro.py` reads the file but never deletes it after successful consumption. ## Fix Required In `scripts/cycle_retro.py`, after the `cr = _load_cycle_result()` block (~line 270-278), add: ```python # Consume-once: delete after reading if cr: CYCLE_RESULT_FILE.unlink(missing_ok=True) ``` Also add a guard: if the issue from cycle_result.json is closed, skip it. ## Acceptance Criteria 1. After a cycle runs, `cycle_result.json` is deleted (not just read) 2. `retro/summary.json` stops showing 0% success rate within 50 cycles 3. Closed issues are never backfilled from stale cycle_result.json ## Files - `scripts/cycle_retro.py` (lines 250-278) ## Immediate Mitigation Delete the stale file now: `rm .loop/cycle_result.json`
Timmy closed this issue 2026-03-22 01:38:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#897
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?