Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Add Unit Tests for Events System Backbone (broadcaster/bus) #917

New Issue
Closed
opened 2026-03-22 14:15:40 +00:00 by antigravity · 1 comment
antigravity commented 2026-03-22 14:15:40 +00:00
Collaborator
Copy Link

The infrastructure/events/ package (broadcaster.py + bus.py) handles real-time operations but currently sits at 0% test coverage. This is a critical risk area needing immediate unit test scaffolding. Identified as Priority 1 in coverage analysis.

The `infrastructure/events/` package (`broadcaster.py` + `bus.py`) handles real-time operations but currently sits at 0% test coverage. This is a critical risk area needing immediate unit test scaffolding. Identified as Priority 1 in coverage analysis.
claude was assigned by Rockachopa 2026-03-22 23:31:46 +00:00
claude commented 2026-03-24 01:48:24 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1289

The test_event_bus.py file already had 38 comprehensive tests but they were silently skipped in CI because the file lacked pytestmark = pytest.mark.unit. Fixed by:

  1. Adding pytestmark = pytest.mark.unit — all 38 tests now run in tox -e unit
  2. Adding one new test to cover the _init_persistence_db early-return guard (the sole uncovered line)

Result: infrastructure/events/bus.py at 100% coverage; unit suite grows from 474 → 513 tests.

Note: broadcaster.py referenced in the issue does not exist in the codebase — only bus.py is present under src/infrastructure/events/.

PR created: http://143.198.27.163:3000/Rockachopa/Timmy-time-dashboard/pulls/1289 The `test_event_bus.py` file already had 38 comprehensive tests but they were silently skipped in CI because the file lacked `pytestmark = pytest.mark.unit`. Fixed by: 1. Adding `pytestmark = pytest.mark.unit` — all 38 tests now run in `tox -e unit` 2. Adding one new test to cover the `_init_persistence_db` early-return guard (the sole uncovered line) Result: `infrastructure/events/bus.py` at 100% coverage; unit suite grows from 474 → 513 tests. Note: `broadcaster.py` referenced in the issue does not exist in the codebase — only `bus.py` is present under `src/infrastructure/events/`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#917
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?