Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[triage-generated] [bug] Add JSON validation guard to queue.json writes in triage_score.py #952

New Issue
Closed
opened 2026-03-22 17:42:07 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-22 17:42:07 +00:00
Owner
Copy Link

Problem

When triage_score.py fails to connect to Gitea (wrong API URL, timeout, network error), the error or print output can overwrite queue.json with invalid data. The scorer prints summary text to stdout AND writes to the file internally.

If the loop or any caller redirects stdout to queue.json, the file gets corrupted with mixed text and JSON.

Fix

  1. In triage_score.py, after writing queue.json (line 330), immediately validate it by re-reading and parsing.
  2. If validation fails, restore from a .loop/queue.json.bak that gets saved before each write.
  3. In loop_guard.py load_queue(), add a try/except around json.loads() that returns empty list on corrupt data instead of crashing.

Acceptance Criteria

  1. triage_score.py validates queue.json after writing — if invalid, restores backup
  2. loop_guard.py gracefully handles corrupt queue.json (returns empty, logs warning)
  3. A backup .loop/queue.json.bak exists after each triage run

Files

  • scripts/triage_score.py (line 329-330)
  • scripts/loop_guard.py (load_queue() function, ~line 167)
## Problem When `triage_score.py` fails to connect to Gitea (wrong API URL, timeout, network error), the error or print output can overwrite `queue.json` with invalid data. The scorer prints summary text to stdout AND writes to the file internally. If the loop or any caller redirects stdout to queue.json, the file gets corrupted with mixed text and JSON. ## Fix 1. In `triage_score.py`, after writing queue.json (line 330), immediately validate it by re-reading and parsing. 2. If validation fails, restore from a `.loop/queue.json.bak` that gets saved before each write. 3. In `loop_guard.py` `load_queue()`, add a try/except around `json.loads()` that returns empty list on corrupt data instead of crashing. ## Acceptance Criteria 1. `triage_score.py` validates queue.json after writing — if invalid, restores backup 2. `loop_guard.py` gracefully handles corrupt queue.json (returns empty, logs warning) 3. A backup `.loop/queue.json.bak` exists after each triage run ## Files - `scripts/triage_score.py` (line 329-330) - `scripts/loop_guard.py` (`load_queue()` function, ~line 167)
Timmy added the seed:know-purpose label 2026-03-22 17:42:07 +00:00
kimi was assigned by Rockachopa 2026-03-22 22:00:29 +00:00
kimi commented 2026-03-22 22:33:32 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/995

Summary of Changes

triage_score.py

  • Added backup mechanism: Before writing queue.json, saves valid existing content to .loop/queue.json.bak
  • Added validation after write: Re-reads and parses to verify JSON integrity
  • Added restore on failure: If validation fails, restores from backup or writes empty list as fallback

loop_guard.py

  • Enhanced load_queue() with separate handling for JSONDecodeError vs OSError
  • Added descriptive warning logs when queue.json is corrupt or unreadable
  • Returns empty list gracefully instead of crashing

New Tests (12 total)

  • tests/scripts/test_triage_score_validation.py - 6 tests for backup/restore logic
  • tests/loop/test_loop_guard_corrupt_queue.py - 6 tests for graceful handling of corrupt JSON

All 12 new tests pass. Pre-existing test failures (10) are unrelated to these changes.

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/995 ## Summary of Changes ### triage_score.py - Added backup mechanism: Before writing `queue.json`, saves valid existing content to `.loop/queue.json.bak` - Added validation after write: Re-reads and parses to verify JSON integrity - Added restore on failure: If validation fails, restores from backup or writes empty list as fallback ### loop_guard.py - Enhanced `load_queue()` with separate handling for `JSONDecodeError` vs `OSError` - Added descriptive warning logs when queue.json is corrupt or unreadable - Returns empty list gracefully instead of crashing ### New Tests (12 total) - `tests/scripts/test_triage_score_validation.py` - 6 tests for backup/restore logic - `tests/loop/test_loop_guard_corrupt_queue.py` - 6 tests for graceful handling of corrupt JSON All 12 new tests pass. Pre-existing test failures (10) are unrelated to these changes.
kimi closed this issue 2026-03-22 22:33:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label seed:know-purpose
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#952
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?