From d311b7b717e5c53ed8d38132d5c53ff4b7d32171 Mon Sep 17 00:00:00 2001 From: Alexander Whitestone Date: Mon, 23 Mar 2026 18:22:15 -0400 Subject: [PATCH] fix: use settings.ollama_model instead of hardcoded value in test The test hardcoded 'qwen3:14b' but .env overrides to 'qwen3:30b', causing CI failures. Assert against settings.ollama_model so the test works regardless of environment configuration. --- tests/unit/test_config.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/test_config.py b/tests/unit/test_config.py index 7d93c341..0ae4aee4 100644 --- a/tests/unit/test_config.py +++ b/tests/unit/test_config.py @@ -699,12 +699,12 @@ class TestGetEffectiveOllamaModel: """get_effective_ollama_model walks fallback chain.""" def test_returns_primary_when_available(self): - from config import get_effective_ollama_model + from config import get_effective_ollama_model, settings with patch("config.check_ollama_model_available", return_value=True): result = get_effective_ollama_model() - # Default is qwen3:14b - assert result == "qwen3:14b" + # Should return whatever the settings primary model is + assert result == settings.ollama_model def test_falls_back_when_primary_unavailable(self): from config import get_effective_ollama_model, settings -- 2.43.0