fix: session_pair_harvester uses role/content format (#91) #240

Merged
Rockachopa merged 1 commits from step35/91-feat-session-transcript-trai into main 2026-05-04 00:23:23 +00:00
Owner

Fixes #91 — session_pair_harvester was using deprecated message fields (from/value) instead of current Hermes session format (role/content).

Changes:

  • Import session_reader to normalize conversations
  • Rewrite extract_pairs_from_conversation to use role/content
  • Fix predecessor lookup from "human"/"gpt" to "user"/"assistant"
  • Add 8 smoke tests covering unit + integration (all passing)
  • Verify extraction on test_sessions: 11 pairs, avg ratio 8.13

Test results:

Ran 8 tests in 0.001s - OK

Closes #91

Fixes #91 — session_pair_harvester was using deprecated message fields (from/value) instead of current Hermes session format (role/content). Changes: - Import `session_reader` to normalize conversations - Rewrite `extract_pairs_from_conversation` to use role/content - Fix predecessor lookup from "human"/"gpt" to "user"/"assistant" - Add 8 smoke tests covering unit + integration (all passing) - Verify extraction on test_sessions: 11 pairs, avg ratio 8.13 Test results: ``` Ran 8 tests in 0.001s - OK ``` Closes #91
Rockachopa added 1 commit 2026-04-26 04:22:22 +00:00
feat: fix session_pair_harvester to use role/content format (#91)
Some checks failed
Test / pytest (pull_request) Failing after 8s
b1a728f5f4
- Harvester used old message fields (from/value) but Hermes sessions use role/content
- Import session_reader to normalize conversations properly
- Update extract function to operate on normalized role/content messages
- Change predecessor lookup from "human"/"gpt" to "user"/"assistant"
- Add comprehensive smoke tests (8 tests, all pass)
- Verify extraction from test_sessions: 11 pairs, avg ratio 8.13
Rockachopa merged commit 2a4e73aa03 into main 2026-05-04 00:23:23 +00:00
Sign in to join this conversation.