fix(redact): safely handle non-string inputs (salvage #2369)

fix(redact): safely handle non-string inputs (salvage #2369)
This commit is contained in:
Teknium
2026-03-21 17:10:14 -07:00
committed by GitHub
2 changed files with 11 additions and 0 deletions

View File

@@ -100,6 +100,10 @@ def redact_sensitive_text(text: str) -> str:
Safe to call on any string -- non-matching text passes through unchanged.
Disabled when security.redact_secrets is false in config.yaml.
"""
if text is None:
return None
if not isinstance(text, str):
text = str(text)
if not text:
return text
if os.getenv("HERMES_REDACT_SECRETS", "").lower() in ("0", "false", "no", "off"):

View File

@@ -124,6 +124,13 @@ class TestPassthrough:
def test_none_returns_none(self):
assert redact_sensitive_text(None) is None
def test_non_string_input_int_coerced(self):
assert redact_sensitive_text(12345) == "12345"
def test_non_string_input_dict_coerced_and_redacted(self):
result = redact_sensitive_text({"token": "sk-proj-abc123def456ghi789jkl012"})
assert "abc123def456" not in result
def test_normal_text_unchanged(self):
text = "Hello world, this is a normal log message with no secrets."
assert redact_sensitive_text(text) == text