Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 250 Pull Requests 13 Actions 7 Packages Projects Releases Wiki Activity

fix(cron): get_due_jobs read jobs.json twice creating race window

Browse Source 
get_due_jobs() called load_jobs() twice: once for filtering (with
_apply_skill_fields) and once for saving updates. Between the two
reads, another process could modify jobs.json, causing the filtering
and saving to operate on different versions.

Fix: load once, deepcopy for the skill-applied working list.
This commit is contained in:
teknium1
2026-03-17 04:03:42 -07:00
parent 4433b83378
commit 1f0bb8742f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cron/jobs.py
View File

@@ -5,6 +5,7 @@ Jobs are stored in ~/.hermes/cron/jobs.json
Output is saved to ~/.hermes/cron/output/{job_id}/{timestamp}.md Output is saved to ~/.hermes/cron/output/{job_id}/{timestamp}.md
""" """
import copy
import json import json
import logging import logging
import tempfile import tempfile
@@ -539,8 +540,8 @@ def get_due_jobs() -> List[Dict[str, Any]]:
immediately. This prevents a burst of missed jobs on gateway restart. immediately. This prevents a burst of missed jobs on gateway restart.
""" """
now = _hermes_now() now = _hermes_now()
jobs = [_apply_skill_fields(j) for j in load_jobs()] raw_jobs = load_jobs()
raw_jobs = load_jobs() # For saving updates jobs = [_apply_skill_fields(j) for j in copy.deepcopy(raw_jobs)]
due = [] due = []
needs_save = False needs_save = False