From 8c48bb080fb6fdca9b2a818ff368a1afbc18d364 Mon Sep 17 00:00:00 2001
From: teknium1 <teknium1@gmail.com>
Date: Mon, 2 Mar 2026 04:40:13 -0800
Subject: [PATCH] refactor: remove unnecessary single-element loop in disk
 usage calc
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The 'for pattern in [f"hermes-*{task_id[:8]}*"]' was a loop over a
single-element list — just use a plain variable instead.
---
 tools/terminal_tool.py | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/tools/terminal_tool.py b/tools/terminal_tool.py
index 2f8ba8174..096ac207f 100644
--- a/tools/terminal_tool.py
+++ b/tools/terminal_tool.py
@@ -638,19 +638,18 @@ def get_active_environments_info() -> Dict[str, Any]:
         "workdirs": {},
     }
     
-    # Calculate total disk usage
+    # Calculate total disk usage (per-task to avoid double-counting)
     total_size = 0
     for task_id in _active_environments.keys():
-        # Check sandbox and workdir sizes
         scratch_dir = _get_scratch_dir()
-        for pattern in [f"hermes-*{task_id[:8]}*"]:
-            import glob
-            for path in glob.glob(str(scratch_dir / pattern)):
-                try:
-                    size = sum(f.stat().st_size for f in Path(path).rglob('*') if f.is_file())
-                    total_size += size
-                except OSError:
-                    pass
+        pattern = f"hermes-*{task_id[:8]}*"
+        import glob
+        for path in glob.glob(str(scratch_dir / pattern)):
+            try:
+                size = sum(f.stat().st_size for f in Path(path).rglob('*') if f.is_file())
+                total_size += size
+            except OSError:
+                pass
     
     info["total_disk_usage_mb"] = round(total_size / (1024 * 1024), 2)
     return info