From efc7a7b95707a19d47ffbf6b614fc67a655361b2 Mon Sep 17 00:00:00 2001 From: rovle Date: Thu, 5 Mar 2026 11:49:35 -0800 Subject: [PATCH] fix(daytona): don't guess /root on cwd probe failure, keep constructor default; update tests to reflect this Signed-off-by: rovle --- tests/tools/test_daytona_environment.py | 8 ++++---- tools/environments/daytona.py | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/tools/test_daytona_environment.py b/tests/tools/test_daytona_environment.py index c27edd102..41f1ace87 100644 --- a/tests/tools/test_daytona_environment.py +++ b/tests/tools/test_daytona_environment.py @@ -115,15 +115,15 @@ class TestCwdResolution: env = make_env(cwd="/workspace", home_dir="/root") assert env.cwd == "/workspace" - def test_home_detection_failure_falls_back_to_root(self, make_env): + def test_home_detection_failure_keeps_default_cwd(self, make_env): sb = _make_sandbox() sb.process.exec.side_effect = RuntimeError("exec failed") env = make_env(sandbox=sb) - assert env.cwd == "/root" + assert env.cwd == "/home/daytona" # keeps constructor default - def test_empty_home_falls_back_to_root(self, make_env): + def test_empty_home_keeps_default_cwd(self, make_env): env = make_env(home_dir="") - assert env.cwd == "/root" + assert env.cwd == "/home/daytona" # keeps constructor default # --------------------------------------------------------------------------- diff --git a/tools/environments/daytona.py b/tools/environments/daytona.py index 8e8817d2f..bfd1732e0 100644 --- a/tools/environments/daytona.py +++ b/tools/environments/daytona.py @@ -98,9 +98,10 @@ class DaytonaEnvironment(BaseEnvironment): if self._requested_cwd in ("~", "/home/daytona"): try: home = self._sandbox.process.exec("echo $HOME").result.strip() - self.cwd = home or "/root" + if home: + self.cwd = home except Exception: - self.cwd = "/root" + pass # leave cwd as-is; sandbox will use its own default logger.info("Daytona: resolved cwd to %s", self.cwd) def _ensure_sandbox_ready(self):