teknium1
|
a44e041acf
|
test: strengthen assertions across 7 test files (batch 1)
Replaced weak 'is not None' / '> 0' / 'len >= 1' assertions with
concrete value checks across the most flagged test files:
gateway/test_pairing.py (11 weak → 0):
- Code assertions verify isinstance + len == CODE_LENGTH
- Approval results verify dict structure + specific user_id/user_name
- Added code2 != code1 check in rate_limit_expires
test_hermes_state.py (6 weak → 0):
- ended_at verified as float timestamp
- Search result counts exact (== 2, not >= 1)
- Context verified as non-empty list
- Export verified as dict, session ID verified
test_cli_init.py (4 weak → 0):
- max_turns asserts exact value (60)
- model asserts string with provider/name format
gateway/test_hooks.py (2 zero-assert tests → fixed):
- test_no_handlers_for_event: verifies no handler registered
- test_handler_error_does_not_propagate: verifies handler count + return
gateway/test_platform_base.py (9 weak image tests → fixed):
- extract_images tests now verify actual URL and alt_text
- truncate_message verifies content preservation after splitting
cron/test_scheduler.py (1 weak → 0):
- resolve_origin verifies dict equality, not just existence
cron/test_jobs.py (2 weak → 0 + 4 new tests):
- Schedule parsing verifies ISO timestamp type
- Cron expression verifies result is valid datetime string
- NEW: 4 tests for update_job() (was completely untested)
|
2026-03-05 18:39:37 -08:00 |
|
0xbyt4
|
46506769f1
|
test: add unit tests for 5 security/logic-critical modules (batch 4)
- gateway/pairing.py: rate limiting, lockout, code expiry, approval flow (28 tests)
- tools/skill_manager_tool.py: validation, path traversal prevention, CRUD (46 tests)
- tools/skills_tool.py: frontmatter/tag parsing, skill discovery, view chain (34 tests)
- agent/auxiliary_client.py: auth reading, API key resolution, param branching (16 tests)
- honcho_integration/session.py: session dataclass, ID sanitization, transcript format (20 tests)
|
2026-02-28 20:33:48 +03:00 |
|