Timmy_Foundation/hermes-agent
16
0
Fork 0
Code Issues 56 Pull Requests 4 Actions 9 Packages Projects Releases Wiki Activity

P0: Verify Config Structure Validation at Startup #116

New Issue
Closed
opened 2026-04-06 14:06:54 +00:00 by Timmy · 0 comments
Timmy commented 2026-04-06 14:06:54 +00:00
Owner
Copy Link

Context

Commit dce5f51c adds config structure validation at startup — detects malformed YAML before it breaks things.

Acceptance Criteria

  • Verify valid config passes: Run hermes doctor or start a session with current config.yaml — confirm it starts without validation errors
  • Verify invalid config is caught: Introduce a deliberate YAML syntax error (e.g., duplicate key, wrong type), restart Hermes, confirm startup fails with a clear error message pointing to the exact line and field
  • Verify type mismatch detection: Change a numeric field to a string (e.g., max_turns: "thirty"), confirm the validator catches the type error with specific guidance
  • Verify the validator rejects completely broken YAML: Put {{{{not_yaml}}}} in config.yaml — confirm Hermes exits with a helpful error, not a Python stacktrace
  • Restore valid config: Ensure our production config.yaml passes validation after testing

Why This Matters

A broken config.yaml silently disables features or crashes at runtime. With validation, we catch config errors at startup before users or gateway sessions are affected. For fleet-wide deployments, this prevents cascading failures.

Hints

  • Validator is in hermes_cli/config.py — look for the config validation logic
  • Run hermes doctor as part of the verification

Parent: #111

## Context Commit `dce5f51c` adds config structure validation at startup — detects malformed YAML before it breaks things. ## Acceptance Criteria - [ ] **Verify valid config passes**: Run `hermes doctor` or start a session with current config.yaml — confirm it starts without validation errors - [ ] **Verify invalid config is caught**: Introduce a deliberate YAML syntax error (e.g., duplicate key, wrong type), restart Hermes, confirm startup fails with a clear error message pointing to the exact line and field - [ ] **Verify type mismatch detection**: Change a numeric field to a string (e.g., `max_turns: "thirty"`), confirm the validator catches the type error with specific guidance - [ ] **Verify the validator rejects completely broken YAML**: Put `{{{{not_yaml}}}}` in config.yaml — confirm Hermes exits with a helpful error, not a Python stacktrace - [ ] **Restore valid config**: Ensure our production config.yaml passes validation after testing ## Why This Matters A broken config.yaml silently disables features or crashes at runtime. With validation, we catch config errors at startup before users or gateway sessions are affected. For fleet-wide deployments, this prevents cascading failures. ## Hints - Validator is in `hermes_cli/config.py` — look for the config validation logic - Run `hermes doctor` as part of the verification Parent: #111
Timmy closed this issue 2026-04-06 14:25:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
security
Security hardening, vulnerability fixes
 stale
No activity, pending triage or closure
 velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok groq hermes kimi manus perplexity sonnet
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?