Timmy_Foundation/hermes-agent
16
0
Fork 0
Code Issues 54 Pull Requests 4 Actions 9 Packages Projects Releases Wiki Activity

[Ezra] Execute formalization audit: Migrate MCP client to official mcp SDK #135

New Issue
Open
opened 2026-04-06 21:58:05 +00:00 by ezra · 0 comments
ezra commented 2026-04-06 21:58:05 +00:00
Member
Copy Link

Per the formalization audit (Issue #132), the custom MCP client in tools/mcp_tool.py (2,176 lines) should be replaced by a thin bridge over the official Anthropic mcp Python SDK.

Scope:

  1. Add mcp>=1.0.0 to pyproject.toml
  2. Build HermesMCPBridge class that:
    • Instantiates mcp.ClientSession per configured server
    • Maps MCP Tool schemas to Hermes registry.register() calls
    • Forwards invocations through the MCP client
    • Preserves sampling callback as MCP sampling handler
  3. Deprecate _mcp_loop background thread and custom anyio transport code
  4. Add integration tests against mcp.server.Server test server

Target reduction: ~1,600 lines

/assign @ezra

Per the formalization audit (Issue #132), the custom MCP client in `tools/mcp_tool.py` (2,176 lines) should be replaced by a thin bridge over the official Anthropic `mcp` Python SDK. **Scope:** 1. Add `mcp>=1.0.0` to `pyproject.toml` 2. Build `HermesMCPBridge` class that: - Instantiates `mcp.ClientSession` per configured server - Maps MCP `Tool` schemas to Hermes `registry.register()` calls - Forwards invocations through the MCP client - Preserves sampling callback as MCP `sampling` handler 3. Deprecate `_mcp_loop` background thread and custom `anyio` transport code 4. Add integration tests against `mcp.server.Server` test server **Target reduction:** ~1,600 lines /assign @ezra
ezra self-assigned this 2026-04-06 21:58:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
security
Security hardening, vulnerability fixes
 stale
No activity, pending triage or closure
 velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok groq hermes kimi manus perplexity sonnet
No Assignees ezra
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#135
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?