Timmy_Foundation/hermes-agent
16
0
Fork 0
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

[FORGE] Add CI check to prevent duplicate model entries in provider lists #232

New Issue
Open
opened 2026-04-08 06:58:06 +00:00 by Timmy · 0 comments
Timmy commented 2026-04-08 06:58:06 +00:00
Owner
Copy Link

Problem

PR #225 (kimi-for-coding → kimi-k2.5 replacement) introduced duplicate kimi-k2.5 entries in two model lists because the target name already existed. This was caught manually during code review, not by automation.

Impact

  • Manual review bandwidth wasted on mechanical errors
  • Risk of shipping broken model metadata to users
  • Forge CI did not block the PR for this data-quality issue

Proposed Fix

Add a lightweight assertion/test in the smoke-and-build CI workflow that verifies:

  1. _PROVIDER_MODELS["kimi-coding"] has no duplicates
  2. hermes_cli/main.py model_list has no duplicates
  3. (stretch) All provider model lists are deduplicated

Acceptance Criteria

  • A new test or lint step fails when duplicate model IDs exist in provider configs
  • The check runs in under 2 seconds
  • CI on main remains green after the check is added
## Problem PR #225 (kimi-for-coding → kimi-k2.5 replacement) introduced duplicate `kimi-k2.5` entries in two model lists because the target name already existed. This was caught manually during code review, not by automation. ## Impact - Manual review bandwidth wasted on mechanical errors - Risk of shipping broken model metadata to users - Forge CI did not block the PR for this data-quality issue ## Proposed Fix Add a lightweight assertion/test in the `smoke-and-build` CI workflow that verifies: 1. `_PROVIDER_MODELS["kimi-coding"]` has no duplicates 2. `hermes_cli/main.py` `model_list` has no duplicates 3. (stretch) All provider model lists are deduplicated ## Acceptance Criteria - [ ] A new test or lint step fails when duplicate model IDs exist in provider configs - [ ] The check runs in under 2 seconds - [ ] CI on `main` remains green after the check is added
bezalel was assigned by Timmy 2026-04-08 06:58:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
security
Security hardening, vulnerability fixes
 stale
No activity, pending triage or closure
 velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok groq hermes kimi manus perplexity sonnet
No Assignees bezalel
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#232
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?