Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 113 Pull Requests 98 Actions 14 Packages Projects Releases Wiki Activity

fix(cron): guard AIAgent init kwargs so dream cycles cannot crash on scheduler drift #341

New Issue
Closed
opened 2026-04-13 06:46:50 +00:00 by Timmy · 2 comments
Timmy commented 2026-04-13 06:46:50 +00:00
Owner
Copy Link

Problem

Three dream cycle cron jobs are stuck red without an audit trail in hermes-agent:

  • Dream Cycle — 2:30AM (Deep) 074fb31b588f
  • Dream Cycle — 4:00AM (Abyss) a0abdafe21a7
  • Dream Cycle — 5:30AM (Awakening) 39af1269e7a9

The stored cron failure is:
TypeError: AIAgent.__init__() got an unexpected keyword argument 'tool_choice'

Diagnosis

  • Working and failing dream jobs use the same model/provider path (xiaomi/mimo-v2-pro via nous)
  • They all run the same dream script path: python3 ~/.hermes/scripts/the-dream.py
  • ~/.hermes/scripts/the-dream.py runs successfully outside cron
  • ~/.hermes/scripts/the-reflection.py also exists and runs successfully outside cron
  • The failure is therefore in cron/agent orchestration, not in the dream/reflection scripts themselves

Root cause

Cron scheduling can drift from AIAgent.__init__() and pass unsupported keyword arguments. When that happens, jobs crash before the prompt runs. In this case the unsupported kwarg was tool_choice.

Acceptance criteria

  • cron.scheduler filters or otherwise guards unsupported AIAgent init kwargs instead of crashing jobs
  • Add regression coverage proving an unexpected scheduler kwarg does not crash run_job()
  • Add regression coverage proving the supported kwargs still reach AIAgent
  • After the fix lands, the three failing dream cycles can be rerun successfully
  • Audit trail exists as hermes-agent issue + PR for the repair
## Problem Three dream cycle cron jobs are stuck red without an audit trail in hermes-agent: - Dream Cycle — 2:30AM (Deep) `074fb31b588f` - Dream Cycle — 4:00AM (Abyss) `a0abdafe21a7` - Dream Cycle — 5:30AM (Awakening) `39af1269e7a9` The stored cron failure is: `TypeError: AIAgent.__init__() got an unexpected keyword argument 'tool_choice'` ## Diagnosis - Working and failing dream jobs use the same model/provider path (`xiaomi/mimo-v2-pro` via `nous`) - They all run the same dream script path: `python3 ~/.hermes/scripts/the-dream.py` - `~/.hermes/scripts/the-dream.py` runs successfully outside cron - `~/.hermes/scripts/the-reflection.py` also exists and runs successfully outside cron - The failure is therefore in cron/agent orchestration, not in the dream/reflection scripts themselves ## Root cause Cron scheduling can drift from `AIAgent.__init__()` and pass unsupported keyword arguments. When that happens, jobs crash before the prompt runs. In this case the unsupported kwarg was `tool_choice`. ## Acceptance criteria - [ ] `cron.scheduler` filters or otherwise guards unsupported `AIAgent` init kwargs instead of crashing jobs - [ ] Add regression coverage proving an unexpected scheduler kwarg does not crash `run_job()` - [ ] Add regression coverage proving the supported kwargs still reach `AIAgent` - [ ] After the fix lands, the three failing dream cycles can be rerun successfully - [ ] Audit trail exists as hermes-agent issue + PR for the repair
claude self-assigned this 2026-04-13 06:48:28 +00:00
Timmy commented 2026-04-13 13:37:35 +00:00
Author
Owner
Copy Link

Fixed in PR #358 (merged).

Added _safe_agent_kwargs() that filters unsupported kwargs before passing to AIAgent(). Combined with the deploy sync guard (#356), there are now two layers:

  1. Fail-fast (#356): warns on first job if params are missing
  2. Resilient filter (#358): drops unsupported kwargs so jobs keep running

Deployed to live system.

Fixed in PR #358 (merged). Added `_safe_agent_kwargs()` that filters unsupported kwargs before passing to `AIAgent()`. Combined with the deploy sync guard (#356), there are now two layers: 1. **Fail-fast** (#356): warns on first job if params are missing 2. **Resilient filter** (#358): drops unsupported kwargs so jobs keep running Deployed to live system.
Timmy closed this issue 2026-04-13 19:13:32 +00:00
Timmy commented 2026-04-13 19:13:47 +00:00
Author
Owner
Copy Link

Fixed in PR #364 (merged). Deploy sync guard + kwarg filter + [SCRIPT_FAILED] marker all live.

Fixed in PR #364 (merged). Deploy sync guard + kwarg filter + [SCRIPT_FAILED] marker all live.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 epic:memory
Unified Memory Architecture epic
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
phase:1-activate
Phase 1: Activate existing systems
 phase:2-operational
Phase 2: Operational memory bridge
 phase:3-episodic
Phase 3: Proactive episodic recall
 phase:4-hygiene
Phase 4: Memory hygiene and quality
 phase:5-integration
Phase 5: Integration and testing
 poka-yoke
research
security
Security hardening, vulnerability fixes
 stale
No activity, pending triage or closure
 tool-evaluation
velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees claude
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?