Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 176 Pull Requests 5 Actions 27 Packages Projects Releases Wiki Activity

[BUG] deploy-crons.py silently drops model/provider changes when prompt unchanged #375

New Issue
Closed
opened 2026-04-13 21:21:40 +00:00 by Rockachopa · 3 comments
Rockachopa commented 2026-04-13 21:21:40 +00:00
Owner
Copy Link

Bug

In deploy-crons.py lines 91-92, update check compares ONLY prompt and schedule. If model/provider changes but prompt stays the same, the job is marked unchanged and NOT updated.

Impact

The provider migration changes to cron-jobs.yaml were applied to YAML but deploy-crons.py would NOT deploy them to jobs.json because the prompts didn't change. Model/provider updates are silently dropped.

Fix

Include model and provider in the comparison:

if (cur.get('prompt') != normalized.get('prompt') or
cur.get('schedule') != normalized.get('schedule') or
cur.get('model') != normalized.get('model') or
cur.get('provider') != normalized.get('provider')):
## Bug In deploy-crons.py lines 91-92, update check compares ONLY prompt and schedule. If model/provider changes but prompt stays the same, the job is marked unchanged and NOT updated. ## Impact The provider migration changes to cron-jobs.yaml were applied to YAML but deploy-crons.py would NOT deploy them to jobs.json because the prompts didn't change. Model/provider updates are silently dropped. ## Fix Include model and provider in the comparison: ``` if (cur.get('prompt') != normalized.get('prompt') or cur.get('schedule') != normalized.get('schedule') or cur.get('model') != normalized.get('model') or cur.get('provider') != normalized.get('provider')): ```
Rockachopa commented 2026-04-13 22:02:57 +00:00
Author
Owner
Copy Link

🔥 BURN DISPATCH v2 — BURNONE pane 3

Timmy multi-threaded burn. Gitea-first workflow.

🔥 **BURN DISPATCH v2** — BURNONE pane 3 Timmy multi-threaded burn. Gitea-first workflow.
claude self-assigned this 2026-04-14 00:42:58 +00:00
Rockachopa commented 2026-04-14 00:48:39 +00:00
Author
Owner
Copy Link

Fixed in PR #447.

Added --deploy mode with _jobs_changed() that compares prompt, schedule, model, and provider — so model/provider changes are never silently dropped.

See: #447

Fixed in PR #447. Added `--deploy` mode with `_jobs_changed()` that compares prompt, schedule, model, and provider — so model/provider changes are never silently dropped. See: https://forge.alexanderwhitestone.com/Timmy_Foundation/hermes-agent/pulls/447
Rockachopa commented 2026-04-14 01:10:36 +00:00
Author
Owner
Copy Link

Fixed in PR #448.

_jobs_changed() now compares prompt, schedule, model, and provider.

See: #448

Fixed in PR #448. `_jobs_changed()` now compares prompt, schedule, model, and provider. See: https://forge.alexanderwhitestone.com/Timmy_Foundation/hermes-agent/pulls/448
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 batch-pipeline
batch-pipeline label
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 epic:memory
Unified Memory Architecture epic
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
phase:1-activate
Phase 1: Activate existing systems
 phase:2-operational
Phase 2: Operational memory bridge
 phase:3-episodic
Phase 3: Proactive episodic recall
 phase:4-hygiene
Phase 4: Memory hygiene and quality
 phase:5-integration
Phase 5: Integration and testing
 poka-yoke
research
security
Security hardening, vulnerability fixes
 shared-infra
Shared infrastructure across projects (Playground + LPM)
 stale
No activity, pending triage or closure
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 tool-evaluation
velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees claude
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#375
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?