Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 190 Pull Requests 24 Actions 96 Packages Projects Releases Wiki Activity

fix(cron): inject cloud-context warning when prompt refs localhost #468

Closed
Rockachopa wants to merge 246 commits from fix/456-cloud-context-warning into main
pull from: fix/456-cloud-context-warning
merge into: Timmy_Foundation:main
Conversation 1 Commits 246 Files Changed 228 +153
Rockachopa commented 2026-04-14 01:18:22 +00:00
Owner
Copy Link

Fix

Fixes #378, Closes #456

When a cron job runs on a cloud endpoint but its prompt references local services (Ollama, localhost, etc.), inject a [SYSTEM NOTE] telling the agent it cannot reach localhost.

How it works

  1. Detection — _detect_local_service_refs() scans the prompt against 12 regex patterns (localhost:PORT, 127.x, "Check Ollama", curl localhost, etc.)
  2. Cloud check — uses existing is_local_endpoint() to determine if the runtime is cloud
  3. Injection — if cloud + local refs found, _inject_cloud_context() prepends a warning so the agent reports the limitation instead of wasting iterations on doomed connections

Changes

  • cron/scheduler.py: Added import re, _LOCAL_SERVICE_PATTERNS, _detect_local_service_refs(), _inject_cloud_context(). Injection call after cloud detection in run_job().
  • tests/test_cron_cloud_context.py: 15 tests covering pattern detection, warning injection, false-positive avoidance.
## Fix Fixes #378, Closes #456 When a cron job runs on a cloud endpoint but its prompt references local services (Ollama, localhost, etc.), inject a `[SYSTEM NOTE]` telling the agent it cannot reach localhost. ### How it works 1. **Detection** — `_detect_local_service_refs()` scans the prompt against 12 regex patterns (localhost:PORT, 127.x, "Check Ollama", curl localhost, etc.) 2. **Cloud check** — uses existing `is_local_endpoint()` to determine if the runtime is cloud 3. **Injection** — if cloud + local refs found, `_inject_cloud_context()` prepends a warning so the agent reports the limitation instead of wasting iterations on doomed connections ### Changes - `cron/scheduler.py`: Added `import re`, `_LOCAL_SERVICE_PATTERNS`, `_detect_local_service_refs()`, `_inject_cloud_context()`. Injection call after cloud detection in `run_job()`. - `tests/test_cron_cloud_context.py`: 15 tests covering pattern detection, warning injection, false-positive avoidance.
Rockachopa added 2 commits 2026-04-14 01:18:23 +00:00
fix(cron): inject cloud-context warning when prompt refs localhost 2e59f8540d 
Fixes #378, Closes #456

When a cron job runs on a cloud endpoint but its prompt references
local services (Ollama, localhost ports, etc.), inject a SYSTEM NOTE
telling the agent it cannot reach localhost so it reports the
limitation instead of wasting iterations on doomed connections.
test(cron): add tests for cloud-context warning injection
Some checks failed
Forge CI / smoke-and-build (pull_request) Failing after 1m13s
Details
7ac8d0268f
Rockachopa commented 2026-04-14 01:28:10 +00:00
Author
Owner
Copy Link

PR #481 created to address this issue: #481

This PR implements cloud context warning injection for cron jobs that reference local services. When a cron job runs on a cloud endpoint but its prompt references local services (Ollama, localhost, etc.), the system now injects a warning telling the agent it cannot reach localhost.

Key changes:

  1. Added _LOCAL_SERVICE_PATTERNS with 12 regex patterns for detecting local service references
  2. Added _detect_local_service_refs() to scan prompts for local service references
  3. Added _inject_cloud_context() to prepend warning to prompts
  4. Integrated injection in run_job() after prompt build, before agent creation
  5. Created comprehensive tests in tests/test_cron_cloud_context.py

The fix ensures that agents running on cloud endpoints report limitations to users instead of wasting iterations trying to connect to non-existent local services.

PR #481 created to address this issue: https://forge.alexanderwhitestone.com/Timmy_Foundation/hermes-agent/pulls/481 This PR implements cloud context warning injection for cron jobs that reference local services. When a cron job runs on a cloud endpoint but its prompt references local services (Ollama, localhost, etc.), the system now injects a warning telling the agent it cannot reach localhost. Key changes: 1. Added `_LOCAL_SERVICE_PATTERNS` with 12 regex patterns for detecting local service references 2. Added `_detect_local_service_refs()` to scan prompts for local service references 3. Added `_inject_cloud_context()` to prepend warning to prompts 4. Integrated injection in `run_job()` after prompt build, before agent creation 5. Created comprehensive tests in `tests/test_cron_cloud_context.py` The fix ensures that agents running on cloud endpoints report limitations to users instead of wasting iterations trying to connect to non-existent local services.
Rockachopa closed this pull request 2026-04-14 01:50:21 +00:00
Some checks failed
Forge CI / smoke-and-build (pull_request) Failing after 1m13s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 audit-finding
batch-pipeline
batch-pipeline label
 blocked
Blocked by external dependency or merge conflict
 bug
claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 critical
duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 epic:memory
Unified Memory Architecture epic
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 ops
p0-critical
p1-important
phase:1-activate
Phase 1: Activate existing systems
 phase:2-operational
Phase 2: Operational memory bridge
 phase:3-episodic
Phase 3: Proactive episodic recall
 phase:4-hygiene
Phase 4: Memory hygiene and quality
 phase:5-integration
Phase 5: Integration and testing
 poka-yoke
research
security
Security hardening, vulnerability fixes
 shared-infra
Shared infrastructure across projects (Playground + LPM)
 stale
No activity, pending triage or closure
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 tool-evaluation
velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#468
Delete Branch "fix/456-cloud-context-warning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?