82d6c28bd5
Two fixes for /skills install and /skills uninstall slash commands: 1. input() hangs indefinitely inside prompt_toolkit's TUI event loop, soft-locking the CLI. The user typing the slash command is already implicit consent, so confirmation is now always skipped. 2. Cache invalidation was unconditional — installing or uninstalling a skill mid-session silently broke the prompt cache, increasing costs. The slash handler now defers cache invalidation by default (skill takes effect next session). Pass --now to invalidate immediately, with a message explaining the cost tradeoff. The CLI argparse path (hermes skills install) is unaffected and still invalidates. Fixes #3474 Salvaged from PR #3496 by dlkakbs.
175 lines
8.3 KiB
Python
175 lines
8.3 KiB
Python
"""
|
|
Tests for skip_confirm and invalidate_cache behavior in /skills install
|
|
and /skills uninstall slash commands.
|
|
|
|
Slash commands always skip confirmation (input() hangs in TUI).
|
|
Cache invalidation is deferred by default; --now opts into immediate
|
|
invalidation (at the cost of breaking prompt cache mid-session).
|
|
|
|
Based on PR #1595 by 333Alden333 (salvaged).
|
|
Updated for PR #3586 (cache-aware install/uninstall).
|
|
"""
|
|
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
import pytest
|
|
|
|
|
|
class TestHandleSkillsSlashInstallFlags:
|
|
"""Test flag parsing in handle_skills_slash for install."""
|
|
|
|
def test_yes_flag_sets_skip_confirm(self):
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill --yes")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
assert kwargs.get("force") is False
|
|
|
|
def test_y_flag_sets_skip_confirm(self):
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill -y")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_force_flag_sets_force(self):
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill --force")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("force") is True
|
|
# Slash commands always skip confirmation (input() hangs in TUI)
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_no_flags_still_skips_confirm(self):
|
|
"""Slash commands always skip confirmation — input() hangs in TUI."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("force") is False
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_default_defers_cache_invalidation(self):
|
|
"""Without --now, cache invalidation is deferred to next session."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("invalidate_cache") is False
|
|
|
|
def test_now_flag_invalidates_cache(self):
|
|
"""--now opts into immediate cache invalidation."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill --now")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("invalidate_cache") is True
|
|
|
|
|
|
class TestHandleSkillsSlashUninstallFlags:
|
|
"""Test flag parsing in handle_skills_slash for uninstall."""
|
|
|
|
def test_yes_flag_sets_skip_confirm(self):
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill --yes")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_y_flag_sets_skip_confirm(self):
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill -y")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_no_flags_still_skips_confirm(self):
|
|
"""Slash commands always skip confirmation — input() hangs in TUI."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_default_defers_cache_invalidation(self):
|
|
"""Without --now, cache invalidation is deferred to next session."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("invalidate_cache") is False
|
|
|
|
def test_now_flag_invalidates_cache(self):
|
|
"""--now opts into immediate cache invalidation."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill --now")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("invalidate_cache") is True
|
|
|
|
|
|
class TestDoInstallSkipConfirm:
|
|
"""Test that do_install respects skip_confirm parameter."""
|
|
|
|
@patch("hermes_cli.skills_hub.input", return_value="n")
|
|
def test_without_skip_confirm_prompts_user(self, mock_input):
|
|
"""Without skip_confirm, input() is called for confirmation."""
|
|
from hermes_cli.skills_hub import do_install
|
|
with patch("hermes_cli.skills_hub._console"), \
|
|
patch("tools.skills_hub.ensure_hub_dirs"), \
|
|
patch("tools.skills_hub.GitHubAuth"), \
|
|
patch("tools.skills_hub.create_source_router") as mock_router, \
|
|
patch("hermes_cli.skills_hub._resolve_short_name", return_value="test/skill"), \
|
|
patch("hermes_cli.skills_hub._resolve_source_meta_and_bundle") as mock_resolve:
|
|
|
|
# Make it return None so we exit early
|
|
mock_resolve.return_value = (None, None, None)
|
|
do_install("test-skill", skip_confirm=False)
|
|
# We don't get to the input() call because resolve returns None,
|
|
# but the parameter wiring is correct
|
|
|
|
|
|
class TestDoUninstallSkipConfirm:
|
|
"""Test that do_uninstall respects skip_confirm parameter."""
|
|
|
|
def test_skip_confirm_bypasses_input(self):
|
|
"""With skip_confirm=True, input() should not be called."""
|
|
from hermes_cli.skills_hub import do_uninstall
|
|
with patch("hermes_cli.skills_hub._console") as mock_console, \
|
|
patch("tools.skills_hub.uninstall_skill", return_value=(True, "Removed")) as mock_uninstall, \
|
|
patch("builtins.input") as mock_input:
|
|
do_uninstall("test-skill", skip_confirm=True)
|
|
mock_input.assert_not_called()
|
|
mock_uninstall.assert_called_once_with("test-skill")
|
|
|
|
def test_without_skip_confirm_calls_input(self):
|
|
"""Without skip_confirm, input() should be called."""
|
|
from hermes_cli.skills_hub import do_uninstall
|
|
with patch("hermes_cli.skills_hub._console"), \
|
|
patch("tools.skills_hub.uninstall_skill", return_value=(True, "Removed")), \
|
|
patch("builtins.input", return_value="y") as mock_input:
|
|
do_uninstall("test-skill", skip_confirm=False)
|
|
mock_input.assert_called_once()
|
|
|
|
def test_without_skip_confirm_cancel(self):
|
|
"""Without skip_confirm, answering 'n' should cancel."""
|
|
from hermes_cli.skills_hub import do_uninstall
|
|
with patch("hermes_cli.skills_hub._console"), \
|
|
patch("tools.skills_hub.uninstall_skill") as mock_uninstall, \
|
|
patch("builtins.input", return_value="n"):
|
|
do_uninstall("test-skill", skip_confirm=False)
|
|
mock_uninstall.assert_not_called()
|