786970925e
All 35 subprocess.run() calls in hermes_cli/gateway.py lacked timeout parameters. If systemctl, launchctl, loginctl, wmic, or ps blocks, hermes gateway start/stop/restart/status/install/uninstall hangs indefinitely with no feedback. Timeouts tiered by operation type: - 10s: instant queries (is-active, status, list, ps, tail, journalctl) - 30s: fast lifecycle (daemon-reload, enable, start, bootstrap, kickstart) - 90s: graceful shutdown (stop, restart, bootout, kickstart -k) — exceeds our TimeoutStopSec=60 to avoid premature timeout during shutdown Special handling: _is_service_running() and launchd_status() catch TimeoutExpired and treat it as not-running/not-loaded, consistent with how non-zero return codes are already handled. Inspired by PR #3732 (dlkakbs) and issue #4057 (SHL0MS). Reimplemented on current main which has significantly changed launchctl handling (bootout/bootstrap/kickstart vs legacy load/unload/start/stop).
121 lines
5.0 KiB
Python
121 lines
5.0 KiB
Python
"""Tests for gateway linger auto-enable behavior on headless Linux installs."""
|
|
|
|
from types import SimpleNamespace
|
|
|
|
import hermes_cli.gateway as gateway
|
|
|
|
|
|
class TestEnsureLingerEnabled:
|
|
def test_linger_already_enabled_via_file(self, monkeypatch, capsys):
|
|
monkeypatch.setattr(gateway, "is_linux", lambda: True)
|
|
monkeypatch.setattr("getpass.getuser", lambda: "testuser")
|
|
monkeypatch.setattr(gateway, "Path", lambda _path: SimpleNamespace(exists=lambda: True))
|
|
|
|
calls = []
|
|
monkeypatch.setattr(gateway.subprocess, "run", lambda *args, **kwargs: calls.append((args, kwargs)))
|
|
|
|
gateway._ensure_linger_enabled()
|
|
|
|
out = capsys.readouterr().out
|
|
assert "Systemd linger is enabled" in out
|
|
assert calls == []
|
|
|
|
def test_status_enabled_skips_enable(self, monkeypatch, capsys):
|
|
monkeypatch.setattr(gateway, "is_linux", lambda: True)
|
|
monkeypatch.setattr("getpass.getuser", lambda: "testuser")
|
|
monkeypatch.setattr(gateway, "Path", lambda _path: SimpleNamespace(exists=lambda: False))
|
|
monkeypatch.setattr(gateway, "get_systemd_linger_status", lambda: (True, ""))
|
|
|
|
calls = []
|
|
monkeypatch.setattr(gateway.subprocess, "run", lambda *args, **kwargs: calls.append((args, kwargs)))
|
|
|
|
gateway._ensure_linger_enabled()
|
|
|
|
out = capsys.readouterr().out
|
|
assert "Systemd linger is enabled" in out
|
|
assert calls == []
|
|
|
|
def test_loginctl_success_enables_linger(self, monkeypatch, capsys):
|
|
monkeypatch.setattr(gateway, "is_linux", lambda: True)
|
|
monkeypatch.setattr("getpass.getuser", lambda: "testuser")
|
|
monkeypatch.setattr(gateway, "Path", lambda _path: SimpleNamespace(exists=lambda: False))
|
|
monkeypatch.setattr(gateway, "get_systemd_linger_status", lambda: (False, ""))
|
|
monkeypatch.setattr("shutil.which", lambda name: "/usr/bin/loginctl")
|
|
|
|
run_calls = []
|
|
|
|
def fake_run(cmd, capture_output=False, text=False, check=False, **kwargs):
|
|
run_calls.append((cmd, capture_output, text, check))
|
|
return SimpleNamespace(returncode=0, stdout="", stderr="")
|
|
|
|
monkeypatch.setattr(gateway.subprocess, "run", fake_run)
|
|
|
|
gateway._ensure_linger_enabled()
|
|
|
|
out = capsys.readouterr().out
|
|
assert "Enabling linger" in out
|
|
assert "Linger enabled" in out
|
|
assert run_calls == [(["loginctl", "enable-linger", "testuser"], True, True, False)]
|
|
|
|
def test_missing_loginctl_shows_manual_guidance(self, monkeypatch, capsys):
|
|
monkeypatch.setattr(gateway, "is_linux", lambda: True)
|
|
monkeypatch.setattr("getpass.getuser", lambda: "testuser")
|
|
monkeypatch.setattr(gateway, "Path", lambda _path: SimpleNamespace(exists=lambda: False))
|
|
monkeypatch.setattr(gateway, "get_systemd_linger_status", lambda: (None, "loginctl not found"))
|
|
monkeypatch.setattr("shutil.which", lambda name: None)
|
|
|
|
calls = []
|
|
monkeypatch.setattr(gateway.subprocess, "run", lambda *args, **kwargs: calls.append((args, kwargs)))
|
|
|
|
gateway._ensure_linger_enabled()
|
|
|
|
out = capsys.readouterr().out
|
|
assert "sudo loginctl enable-linger testuser" in out
|
|
assert "loginctl not found" in out
|
|
assert calls == []
|
|
|
|
def test_loginctl_failure_shows_manual_guidance(self, monkeypatch, capsys):
|
|
monkeypatch.setattr(gateway, "is_linux", lambda: True)
|
|
monkeypatch.setattr("getpass.getuser", lambda: "testuser")
|
|
monkeypatch.setattr(gateway, "Path", lambda _path: SimpleNamespace(exists=lambda: False))
|
|
monkeypatch.setattr(gateway, "get_systemd_linger_status", lambda: (False, ""))
|
|
monkeypatch.setattr("shutil.which", lambda name: "/usr/bin/loginctl")
|
|
monkeypatch.setattr(
|
|
gateway.subprocess,
|
|
"run",
|
|
lambda *args, **kwargs: SimpleNamespace(returncode=1, stdout="", stderr="Permission denied"),
|
|
)
|
|
|
|
gateway._ensure_linger_enabled()
|
|
|
|
out = capsys.readouterr().out
|
|
assert "sudo loginctl enable-linger testuser" in out
|
|
assert "Permission denied" in out
|
|
|
|
|
|
def test_systemd_install_calls_linger_helper(monkeypatch, tmp_path, capsys):
|
|
unit_path = tmp_path / "systemd" / "user" / "hermes-gateway.service"
|
|
|
|
monkeypatch.setattr(gateway, "get_systemd_unit_path", lambda system=False: unit_path)
|
|
|
|
calls = []
|
|
|
|
def fake_run(cmd, check=False, **kwargs):
|
|
calls.append((cmd, check))
|
|
return SimpleNamespace(returncode=0, stdout="", stderr="")
|
|
|
|
helper_calls = []
|
|
monkeypatch.setattr(gateway.subprocess, "run", fake_run)
|
|
monkeypatch.setattr(gateway, "_ensure_linger_enabled", lambda: helper_calls.append(True))
|
|
|
|
gateway.systemd_install(force=False)
|
|
|
|
out = capsys.readouterr().out
|
|
assert unit_path.exists()
|
|
assert [cmd for cmd, _ in calls] == [
|
|
["systemctl", "--user", "daemon-reload"],
|
|
["systemctl", "--user", "enable", gateway.get_service_name()],
|
|
]
|
|
assert helper_calls == [True]
|
|
assert "User service installed and enabled" in out
|