25481d4286
Restore the ACP editor-integration implementation that was present on the original PR branch but did not actually land in main. Includes: - acp_adapter/ server, session manager, event bridge, auth, permissions, and tool helpers - hermes acp subcommand and hermes-acp entry point - hermes-acp curated toolset - ACP registry manifest, setup guide, and ACP test suite - jupyter-live-kernel data science skill from the original branch Also updates the revived ACP code for current main by: - resolving runtime providers through the modern shared provider router - binding ACP sessions to per-session cwd task overrides - tracking duplicate same-name tool calls with FIFO IDs - restoring terminal approval callbacks after prompts - normalizing supporting docs/skill metadata Validated with tests/acp and the full pytest suite (-n0).
237 lines
8.5 KiB
Python
237 lines
8.5 KiB
Python
"""Tests for acp_adapter.tools — tool kind mapping and ACP content building."""
|
|
|
|
import pytest
|
|
|
|
from acp_adapter.tools import (
|
|
TOOL_KIND_MAP,
|
|
build_tool_complete,
|
|
build_tool_start,
|
|
build_tool_title,
|
|
extract_locations,
|
|
get_tool_kind,
|
|
make_tool_call_id,
|
|
)
|
|
from acp.schema import (
|
|
FileEditToolCallContent,
|
|
ContentToolCallContent,
|
|
ToolCallLocation,
|
|
ToolCallStart,
|
|
ToolCallProgress,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# TOOL_KIND_MAP coverage
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
COMMON_HERMES_TOOLS = ["read_file", "search_files", "terminal", "patch", "write_file", "process"]
|
|
|
|
|
|
class TestToolKindMap:
|
|
def test_all_hermes_tools_have_kind(self):
|
|
"""Every common hermes tool should appear in TOOL_KIND_MAP."""
|
|
for tool in COMMON_HERMES_TOOLS:
|
|
assert tool in TOOL_KIND_MAP, f"{tool} missing from TOOL_KIND_MAP"
|
|
|
|
def test_tool_kind_read_file(self):
|
|
assert get_tool_kind("read_file") == "read"
|
|
|
|
def test_tool_kind_terminal(self):
|
|
assert get_tool_kind("terminal") == "execute"
|
|
|
|
def test_tool_kind_patch(self):
|
|
assert get_tool_kind("patch") == "edit"
|
|
|
|
def test_tool_kind_write_file(self):
|
|
assert get_tool_kind("write_file") == "edit"
|
|
|
|
def test_tool_kind_web_search(self):
|
|
assert get_tool_kind("web_search") == "fetch"
|
|
|
|
def test_tool_kind_execute_code(self):
|
|
assert get_tool_kind("execute_code") == "execute"
|
|
|
|
def test_tool_kind_browser_navigate(self):
|
|
assert get_tool_kind("browser_navigate") == "fetch"
|
|
|
|
def test_unknown_tool_returns_other_kind(self):
|
|
assert get_tool_kind("nonexistent_tool_xyz") == "other"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# make_tool_call_id
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestMakeToolCallId:
|
|
def test_returns_string(self):
|
|
tc_id = make_tool_call_id()
|
|
assert isinstance(tc_id, str)
|
|
|
|
def test_starts_with_tc_prefix(self):
|
|
tc_id = make_tool_call_id()
|
|
assert tc_id.startswith("tc-")
|
|
|
|
def test_ids_are_unique(self):
|
|
ids = {make_tool_call_id() for _ in range(100)}
|
|
assert len(ids) == 100
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# build_tool_title
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestBuildToolTitle:
|
|
def test_terminal_title_includes_command(self):
|
|
title = build_tool_title("terminal", {"command": "ls -la /tmp"})
|
|
assert "ls -la /tmp" in title
|
|
|
|
def test_terminal_title_truncates_long_command(self):
|
|
long_cmd = "x" * 200
|
|
title = build_tool_title("terminal", {"command": long_cmd})
|
|
assert len(title) < 120
|
|
assert "..." in title
|
|
|
|
def test_read_file_title(self):
|
|
title = build_tool_title("read_file", {"path": "/etc/hosts"})
|
|
assert "/etc/hosts" in title
|
|
|
|
def test_patch_title(self):
|
|
title = build_tool_title("patch", {"path": "main.py", "mode": "replace"})
|
|
assert "main.py" in title
|
|
|
|
def test_search_title(self):
|
|
title = build_tool_title("search_files", {"pattern": "TODO"})
|
|
assert "TODO" in title
|
|
|
|
def test_web_search_title(self):
|
|
title = build_tool_title("web_search", {"query": "python asyncio"})
|
|
assert "python asyncio" in title
|
|
|
|
def test_unknown_tool_uses_name(self):
|
|
title = build_tool_title("some_new_tool", {"foo": "bar"})
|
|
assert title == "some_new_tool"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# build_tool_start
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestBuildToolStart:
|
|
def test_build_tool_start_for_patch(self):
|
|
"""patch should produce a FileEditToolCallContent (diff)."""
|
|
args = {
|
|
"path": "src/main.py",
|
|
"old_string": "print('hello')",
|
|
"new_string": "print('world')",
|
|
}
|
|
result = build_tool_start("tc-1", "patch", args)
|
|
assert isinstance(result, ToolCallStart)
|
|
assert result.kind == "edit"
|
|
# The first content item should be a diff
|
|
assert len(result.content) >= 1
|
|
diff_item = result.content[0]
|
|
assert isinstance(diff_item, FileEditToolCallContent)
|
|
assert diff_item.path == "src/main.py"
|
|
assert diff_item.new_text == "print('world')"
|
|
assert diff_item.old_text == "print('hello')"
|
|
|
|
def test_build_tool_start_for_write_file(self):
|
|
"""write_file should produce a FileEditToolCallContent (diff)."""
|
|
args = {"path": "new_file.py", "content": "print('hello')"}
|
|
result = build_tool_start("tc-w1", "write_file", args)
|
|
assert isinstance(result, ToolCallStart)
|
|
assert result.kind == "edit"
|
|
assert len(result.content) >= 1
|
|
diff_item = result.content[0]
|
|
assert isinstance(diff_item, FileEditToolCallContent)
|
|
assert diff_item.path == "new_file.py"
|
|
|
|
def test_build_tool_start_for_terminal(self):
|
|
"""terminal should produce text content with the command."""
|
|
args = {"command": "ls -la /tmp"}
|
|
result = build_tool_start("tc-2", "terminal", args)
|
|
assert isinstance(result, ToolCallStart)
|
|
assert result.kind == "execute"
|
|
assert len(result.content) >= 1
|
|
content_item = result.content[0]
|
|
assert isinstance(content_item, ContentToolCallContent)
|
|
# The wrapped text block should contain the command
|
|
text = content_item.content.text
|
|
assert "ls -la /tmp" in text
|
|
|
|
def test_build_tool_start_for_read_file(self):
|
|
"""read_file should include the path in content."""
|
|
args = {"path": "/etc/hosts", "offset": 1, "limit": 50}
|
|
result = build_tool_start("tc-3", "read_file", args)
|
|
assert isinstance(result, ToolCallStart)
|
|
assert result.kind == "read"
|
|
assert len(result.content) >= 1
|
|
content_item = result.content[0]
|
|
assert isinstance(content_item, ContentToolCallContent)
|
|
assert "/etc/hosts" in content_item.content.text
|
|
|
|
def test_build_tool_start_for_search(self):
|
|
"""search_files should include pattern in content."""
|
|
args = {"pattern": "TODO", "target": "content"}
|
|
result = build_tool_start("tc-4", "search_files", args)
|
|
assert isinstance(result, ToolCallStart)
|
|
assert result.kind == "search"
|
|
assert "TODO" in result.content[0].content.text
|
|
|
|
def test_build_tool_start_generic_fallback(self):
|
|
"""Unknown tools should get a generic text representation."""
|
|
args = {"foo": "bar", "baz": 42}
|
|
result = build_tool_start("tc-5", "some_tool", args)
|
|
assert isinstance(result, ToolCallStart)
|
|
assert result.kind == "other"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# build_tool_complete
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestBuildToolComplete:
|
|
def test_build_tool_complete_for_terminal(self):
|
|
"""Completed terminal call should include output text."""
|
|
result = build_tool_complete("tc-2", "terminal", "total 42\ndrwxr-xr-x 2 root root 4096 ...")
|
|
assert isinstance(result, ToolCallProgress)
|
|
assert result.status == "completed"
|
|
assert len(result.content) >= 1
|
|
content_item = result.content[0]
|
|
assert isinstance(content_item, ContentToolCallContent)
|
|
assert "total 42" in content_item.content.text
|
|
|
|
def test_build_tool_complete_truncates_large_output(self):
|
|
"""Very large outputs should be truncated."""
|
|
big_output = "x" * 10000
|
|
result = build_tool_complete("tc-6", "read_file", big_output)
|
|
assert isinstance(result, ToolCallProgress)
|
|
display_text = result.content[0].content.text
|
|
assert len(display_text) < 6000
|
|
assert "truncated" in display_text
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# extract_locations
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestExtractLocations:
|
|
def test_extract_locations_with_path(self):
|
|
args = {"path": "src/app.py", "offset": 42}
|
|
locs = extract_locations(args)
|
|
assert len(locs) == 1
|
|
assert isinstance(locs[0], ToolCallLocation)
|
|
assert locs[0].path == "src/app.py"
|
|
assert locs[0].line == 42
|
|
|
|
def test_extract_locations_without_path(self):
|
|
args = {"command": "echo hi"}
|
|
locs = extract_locations(args)
|
|
assert locs == []
|