de6750ed23
Adds a skin system that lets users customize the CLI's visual appearance through data files (YAML) rather than code changes. Skins define: color palette, spinner faces/verbs/wings, branding text, and tool output prefix. New files: - hermes_cli/skin_engine.py — SkinConfig dataclass, built-in skins (default, ares, mono, slate), YAML loader for user skins from ~/.hermes/skins/, skin management API - tests/hermes_cli/test_skin_engine.py — 26 tests covering config, built-in skins, user YAML skins, display integration Modified files: - agent/display.py — skin-aware spinner wings, faces, verbs, tool prefix - hermes_cli/banner.py — skin-aware banner colors (title, border, accent, dim, text, session) via _skin_color()/_skin_branding() helpers - cli.py — /skin command handler, skin init from config, skin-aware response box label and welcome message - hermes_cli/config.py — add display.skin default - hermes_cli/commands.py — add /skin to slash commands Built-in skins: - default: classic Hermes gold/kawaii - ares: crimson/bronze war-god theme (from community PRs #579/#725) - mono: clean grayscale - slate: cool blue developer theme User skins: drop a YAML file in ~/.hermes/skins/ with name, colors, spinner, branding, and tool_prefix fields. Missing values inherit from the default skin.
233 lines
8.8 KiB
Python
233 lines
8.8 KiB
Python
"""Tests for hermes_cli.skin_engine — the data-driven skin/theme system."""
|
|
|
|
import json
|
|
import os
|
|
import pytest
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def reset_skin_state():
|
|
"""Reset skin engine state between tests."""
|
|
from hermes_cli import skin_engine
|
|
skin_engine._active_skin = None
|
|
skin_engine._active_skin_name = "default"
|
|
yield
|
|
skin_engine._active_skin = None
|
|
skin_engine._active_skin_name = "default"
|
|
|
|
|
|
class TestSkinConfig:
|
|
def test_default_skin_has_required_fields(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("default")
|
|
assert skin.name == "default"
|
|
assert skin.tool_prefix == "┊"
|
|
assert "banner_title" in skin.colors
|
|
assert "banner_border" in skin.colors
|
|
assert "agent_name" in skin.branding
|
|
|
|
def test_get_color_with_fallback(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("default")
|
|
assert skin.get_color("banner_title") == "#FFD700"
|
|
assert skin.get_color("nonexistent", "#000") == "#000"
|
|
|
|
def test_get_branding_with_fallback(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("default")
|
|
assert skin.get_branding("agent_name") == "Hermes Agent"
|
|
assert skin.get_branding("nonexistent", "fallback") == "fallback"
|
|
|
|
def test_get_spinner_list_empty_for_default(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("default")
|
|
# Default skin has no custom spinner config
|
|
assert skin.get_spinner_list("waiting_faces") == []
|
|
assert skin.get_spinner_list("thinking_verbs") == []
|
|
|
|
def test_get_spinner_wings_empty_for_default(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("default")
|
|
assert skin.get_spinner_wings() == []
|
|
|
|
|
|
class TestBuiltinSkins:
|
|
def test_ares_skin_loads(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("ares")
|
|
assert skin.name == "ares"
|
|
assert skin.tool_prefix == "╎"
|
|
assert skin.get_color("banner_border") == "#9F1C1C"
|
|
assert skin.get_branding("agent_name") == "Ares Agent"
|
|
|
|
def test_ares_has_spinner_customization(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("ares")
|
|
assert len(skin.get_spinner_list("waiting_faces")) > 0
|
|
assert len(skin.get_spinner_list("thinking_faces")) > 0
|
|
assert len(skin.get_spinner_list("thinking_verbs")) > 0
|
|
wings = skin.get_spinner_wings()
|
|
assert len(wings) > 0
|
|
assert isinstance(wings[0], tuple)
|
|
assert len(wings[0]) == 2
|
|
|
|
def test_mono_skin_loads(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("mono")
|
|
assert skin.name == "mono"
|
|
assert skin.get_color("banner_title") == "#e6edf3"
|
|
|
|
def test_slate_skin_loads(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("slate")
|
|
assert skin.name == "slate"
|
|
assert skin.get_color("banner_title") == "#7eb8f6"
|
|
|
|
def test_unknown_skin_falls_back_to_default(self):
|
|
from hermes_cli.skin_engine import load_skin
|
|
skin = load_skin("nonexistent_skin_xyz")
|
|
assert skin.name == "default"
|
|
|
|
def test_all_builtin_skins_have_complete_colors(self):
|
|
from hermes_cli.skin_engine import _BUILTIN_SKINS, _build_skin_config
|
|
required_keys = ["banner_border", "banner_title", "banner_accent",
|
|
"banner_dim", "banner_text", "ui_accent"]
|
|
for name, data in _BUILTIN_SKINS.items():
|
|
skin = _build_skin_config(data)
|
|
for key in required_keys:
|
|
assert key in skin.colors, f"Skin '{name}' missing color '{key}'"
|
|
|
|
|
|
class TestSkinManagement:
|
|
def test_set_active_skin(self):
|
|
from hermes_cli.skin_engine import set_active_skin, get_active_skin, get_active_skin_name
|
|
skin = set_active_skin("ares")
|
|
assert skin.name == "ares"
|
|
assert get_active_skin_name() == "ares"
|
|
assert get_active_skin().name == "ares"
|
|
|
|
def test_get_active_skin_defaults(self):
|
|
from hermes_cli.skin_engine import get_active_skin
|
|
skin = get_active_skin()
|
|
assert skin.name == "default"
|
|
|
|
def test_list_skins_includes_builtins(self):
|
|
from hermes_cli.skin_engine import list_skins
|
|
skins = list_skins()
|
|
names = [s["name"] for s in skins]
|
|
assert "default" in names
|
|
assert "ares" in names
|
|
assert "mono" in names
|
|
assert "slate" in names
|
|
for s in skins:
|
|
assert "source" in s
|
|
assert s["source"] == "builtin"
|
|
|
|
def test_init_skin_from_config(self):
|
|
from hermes_cli.skin_engine import init_skin_from_config, get_active_skin_name
|
|
init_skin_from_config({"display": {"skin": "ares"}})
|
|
assert get_active_skin_name() == "ares"
|
|
|
|
def test_init_skin_from_empty_config(self):
|
|
from hermes_cli.skin_engine import init_skin_from_config, get_active_skin_name
|
|
init_skin_from_config({})
|
|
assert get_active_skin_name() == "default"
|
|
|
|
|
|
class TestUserSkins:
|
|
def test_load_user_skin_from_yaml(self, tmp_path, monkeypatch):
|
|
from hermes_cli.skin_engine import load_skin, _skins_dir
|
|
# Create a user skin YAML
|
|
skins_dir = tmp_path / "skins"
|
|
skins_dir.mkdir()
|
|
skin_file = skins_dir / "custom.yaml"
|
|
skin_data = {
|
|
"name": "custom",
|
|
"description": "A custom test skin",
|
|
"colors": {"banner_title": "#FF0000"},
|
|
"branding": {"agent_name": "Custom Agent"},
|
|
"tool_prefix": "▸",
|
|
}
|
|
import yaml
|
|
skin_file.write_text(yaml.dump(skin_data))
|
|
|
|
# Patch skins dir
|
|
monkeypatch.setattr("hermes_cli.skin_engine._skins_dir", lambda: skins_dir)
|
|
|
|
skin = load_skin("custom")
|
|
assert skin.name == "custom"
|
|
assert skin.get_color("banner_title") == "#FF0000"
|
|
assert skin.get_branding("agent_name") == "Custom Agent"
|
|
assert skin.tool_prefix == "▸"
|
|
# Should inherit defaults for unspecified colors
|
|
assert skin.get_color("banner_border") == "#CD7F32" # from default
|
|
|
|
def test_list_skins_includes_user_skins(self, tmp_path, monkeypatch):
|
|
from hermes_cli.skin_engine import list_skins
|
|
skins_dir = tmp_path / "skins"
|
|
skins_dir.mkdir()
|
|
import yaml
|
|
(skins_dir / "pirate.yaml").write_text(yaml.dump({
|
|
"name": "pirate",
|
|
"description": "Arr matey",
|
|
}))
|
|
monkeypatch.setattr("hermes_cli.skin_engine._skins_dir", lambda: skins_dir)
|
|
|
|
skins = list_skins()
|
|
names = [s["name"] for s in skins]
|
|
assert "pirate" in names
|
|
pirate = [s for s in skins if s["name"] == "pirate"][0]
|
|
assert pirate["source"] == "user"
|
|
|
|
|
|
class TestDisplayIntegration:
|
|
def test_get_skin_tool_prefix_default(self):
|
|
from agent.display import get_skin_tool_prefix
|
|
assert get_skin_tool_prefix() == "┊"
|
|
|
|
def test_get_skin_tool_prefix_custom(self):
|
|
from hermes_cli.skin_engine import set_active_skin
|
|
from agent.display import get_skin_tool_prefix
|
|
set_active_skin("ares")
|
|
assert get_skin_tool_prefix() == "╎"
|
|
|
|
def test_get_skin_faces_default(self):
|
|
from agent.display import get_skin_faces, KawaiiSpinner
|
|
faces = get_skin_faces("waiting_faces", KawaiiSpinner.KAWAII_WAITING)
|
|
# Default skin has no custom faces, so should return the default list
|
|
assert faces == KawaiiSpinner.KAWAII_WAITING
|
|
|
|
def test_get_skin_faces_ares(self):
|
|
from hermes_cli.skin_engine import set_active_skin
|
|
from agent.display import get_skin_faces, KawaiiSpinner
|
|
set_active_skin("ares")
|
|
faces = get_skin_faces("waiting_faces", KawaiiSpinner.KAWAII_WAITING)
|
|
assert "(⚔)" in faces
|
|
|
|
def test_get_skin_verbs_default(self):
|
|
from agent.display import get_skin_verbs, KawaiiSpinner
|
|
verbs = get_skin_verbs()
|
|
assert verbs == KawaiiSpinner.THINKING_VERBS
|
|
|
|
def test_get_skin_verbs_ares(self):
|
|
from hermes_cli.skin_engine import set_active_skin
|
|
from agent.display import get_skin_verbs
|
|
set_active_skin("ares")
|
|
verbs = get_skin_verbs()
|
|
assert "forging" in verbs
|
|
|
|
def test_tool_message_uses_skin_prefix(self):
|
|
from hermes_cli.skin_engine import set_active_skin
|
|
from agent.display import get_cute_tool_message
|
|
set_active_skin("ares")
|
|
msg = get_cute_tool_message("terminal", {"command": "ls"}, 0.5)
|
|
assert msg.startswith("╎")
|
|
assert "┊" not in msg
|
|
|
|
def test_tool_message_default_prefix(self):
|
|
from agent.display import get_cute_tool_message
|
|
msg = get_cute_tool_message("terminal", {"command": "ls"}, 0.5)
|
|
assert msg.startswith("┊")
|