Timmy_Foundation/the-beacon
15
0
Fork 0
Code Issues 15 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

[BUG] 3 UI bugs: toast text, missing phase overlay, missing mute/contrast buttons #101

New Issue
Closed
opened 2026-04-13 06:43:57 +00:00 by Timmy · 3 comments
Timmy commented 2026-04-13 06:43:57 +00:00
Owner
Copy Link

3 UI bugs from QA report still unfixed

1. Memory Leak toast says "trust draining" (should be "compute")

File: js/engine.js
Toast says "trust draining" but the event drains compute (70% reduction) and ops. Misleading feedback.

2. Phase transition overlay element missing from HTML

showPhaseTransition() looks for #phase-transition but this element doesn't exist in index.html. Phase transitions silently fail — no celebratory overlay appears.

3. Mute and Contrast buttons referenced but not in HTML

toggleMute() looks for #mute-btn and toggleContrast() looks for #contrast-btn. Neither button exists in index.html. Keyboard shortcuts M and C do nothing.

All three from QA report qa_beacon.md (BUG-06, BUG-07, BUG-09).

## 3 UI bugs from QA report still unfixed ### 1. Memory Leak toast says "trust draining" (should be "compute") **File:** `js/engine.js` Toast says "trust draining" but the event drains compute (70% reduction) and ops. Misleading feedback. ### 2. Phase transition overlay element missing from HTML `showPhaseTransition()` looks for `#phase-transition` but this element doesn't exist in `index.html`. Phase transitions silently fail — no celebratory overlay appears. ### 3. Mute and Contrast buttons referenced but not in HTML `toggleMute()` looks for `#mute-btn` and `toggleContrast()` looks for `#contrast-btn`. Neither button exists in `index.html`. Keyboard shortcuts M and C do nothing. All three from QA report `qa_beacon.md` (BUG-06, BUG-07, BUG-09).
Timmy commented 2026-04-13 07:44:03 +00:00
Author
Owner
Copy Link

Work submitted in PR #105.

Status:

  • Bug 2 (phase-transition overlay): Fixed — added missing #phase-transition element
  • Bug 1 (Memory Leak toast): Already fixed in PR #103 (line 673: 'Memory Leak — compute draining')
  • Bug 3 (mute/contrast buttons): Already fixed in PR #103 (buttons at HTML lines 122-123)

Only Bug 2 required new work.

Work submitted in PR #105. **Status:** - Bug 2 (phase-transition overlay): **Fixed** — added missing `#phase-transition` element - Bug 1 (Memory Leak toast): Already fixed in PR #103 (line 673: `'Memory Leak — compute draining'`) - Bug 3 (mute/contrast buttons): Already fixed in PR #103 (buttons at HTML lines 122-123) Only Bug 2 required new work.
Timmy commented 2026-04-13 08:10:49 +00:00
Author
Owner
Copy Link

Sprint Fix — PR #110

Status:

  • Bug 1 (toast "trust draining"): ✅ Already fixed — Memory Leak toast says "compute draining"
  • Bug 2 (phase overlay missing): ✅ Fixed in PR #110 — added #phase-transition div with CSS
  • Bug 3 (mute/contrast buttons): ✅ Already present in HTML

PR: #110

Ready for review & merge.

## Sprint Fix — PR #110 **Status:** - Bug 1 (toast "trust draining"): ✅ Already fixed — `Memory Leak` toast says "compute draining" - Bug 2 (phase overlay missing): ✅ Fixed in PR #110 — added `#phase-transition` div with CSS - Bug 3 (mute/contrast buttons): ✅ Already present in HTML PR: https://forge.alexanderwhitestone.com/Timmy_Foundation/the-beacon/pulls/110 Ready for review & merge.
Timmy closed this issue 2026-04-13 08:18:11 +00:00
Timmy commented 2026-04-13 13:29:31 +00:00
Author
Owner
Copy Link

Verified — All 3 bugs already fixed

Checked current codebase on main:

Bug 1: Memory Leak toast

  • js/engine.js line ~606: showToast('Memory Leak — compute draining', 'event') ✓
  • The "trust draining" toast is for Unreviewed Merge event (which actually drains trust — correct)
  • Memory Leak correctly says "compute draining"

Bug 2: Phase transition overlay

  • index.html line 281: <div id="phase-transition"> ✓ exists
  • CSS at line 93: #phase-transition{display:none;...} ✓ exists
  • js/engine.js showPhaseTransition() finds the element ✓

Bug 3: Mute and Contrast buttons

  • index.html line 128: <button id="mute-btn">🔊</button> ✓
  • index.html line 129: <button id="contrast-btn">◐</button> ✓
  • js/main.js toggleMute() and toggleContrast() find their buttons ✓

All three were likely fixed in a previous PR. Closing as already resolved.

## Verified — All 3 bugs already fixed Checked current codebase on main: **Bug 1: Memory Leak toast** - `js/engine.js` line ~606: `showToast('Memory Leak — compute draining', 'event')` ✓ - The "trust draining" toast is for `Unreviewed Merge` event (which actually drains trust — correct) - Memory Leak correctly says "compute draining" **Bug 2: Phase transition overlay** - `index.html` line 281: `<div id="phase-transition">` ✓ exists - CSS at line 93: `#phase-transition{display:none;...}` ✓ exists - `js/engine.js` `showPhaseTransition()` finds the element ✓ **Bug 3: Mute and Contrast buttons** - `index.html` line 128: `<button id="mute-btn">🔊</button>` ✓ - `index.html` line 129: `<button id="contrast-btn">◐</button>` ✓ - `js/main.js` `toggleMute()` and `toggleContrast()` find their buttons ✓ All three were likely fixed in a previous PR. Closing as already resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
P3
architecture
devops
documentation
education
endgame
gameplay
mechanics
narrative
polish
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-beacon#101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?