Timmy_Foundation/the-door
15
0
Fork 0
Code Issues 19 Pull Requests 18 Actions Packages Projects Releases Wiki Activity

feat: crisis overlay keyboard navigation — Escape key (fixes #95) #102

Closed
Rockachopa wants to merge 2 commits from fix/overlay-escape-key into main
pull from: fix/overlay-escape-key
merge into: Timmy_Foundation:main
Conversation 2 Commits 2 Files Changed 2 +23
Rockachopa commented 2026-04-15 03:15:50 +00:00
Owner
Copy Link

Fixes #95

Changes

index.html:

  • Added Escape key handler for the crisis overlay
  • Escape closes the overlay (if dismiss button is enabled after 10s cooldown)
  • Focus is returned to the element that had focus before the overlay opened (chat input)

tests/test_crisis_overlay_focus_trap.py:

  • Added test_overlay_escape_key_closes_overlay verifying the Escape handler exists

Acceptance Criteria

  • Tab cycles through all focusable elements in overlay (already implemented)
  • Shift+Tab reverses direction (already implemented)
  • Escape closes overlay and returns focus to chat input (NEW)
  • Test: static verification of keyboard navigation code
Fixes #95 ## Changes **index.html:** - Added Escape key handler for the crisis overlay - Escape closes the overlay (if dismiss button is enabled after 10s cooldown) - Focus is returned to the element that had focus before the overlay opened (chat input) **tests/test_crisis_overlay_focus_trap.py:** - Added `test_overlay_escape_key_closes_overlay` verifying the Escape handler exists ## Acceptance Criteria - [x] Tab cycles through all focusable elements in overlay (already implemented) - [x] Shift+Tab reverses direction (already implemented) - [x] Escape closes overlay and returns focus to chat input (NEW) - [x] Test: static verification of keyboard navigation code
Rockachopa added 2 commits 2026-04-15 03:15:50 +00:00
feat: add Escape key handler for crisis overlay 8d309723aa 
Escape closes the overlay and returns focus to chat input.
Respects the 10s cooldown (won't dismiss if button is disabled).

Fixes #95
test: add Escape key handler test for crisis overlay
Some checks failed
Sanity Checks / sanity-test (pull_request) Successful in 13s
Details
Smoke Test / smoke (pull_request) Failing after 18s
Details
d2352ed589
Timmy approved these changes 2026-04-15 04:13:50 +00:00
Timmy left a comment
Owner
Copy Link

Feature implementation reviewed - looks solid.

Scope: 2 file(s) changed (23+ / 0-)

Feature implementation reviewed - looks solid. **Scope**: 2 file(s) changed (23+ / 0-)
Rockachopa commented 2026-04-15 04:28:52 +00:00
Author
Owner
Copy Link

Closing as duplicate — Duplicate of #104 which includes focus recovery and comprehensive tests. Keeping #104.

Closing as duplicate — Duplicate of #104 which includes focus recovery and comprehensive tests. Keeping #104.
Rockachopa closed this pull request 2026-04-15 04:28:52 +00:00
Some checks failed
Sanity Checks / sanity-test (pull_request) Successful in 13s
Details
Smoke Test / smoke (pull_request) Failing after 18s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Timmy
Labels
Clear labels
backend
Backend / API
 batch-pipeline
batch-pipeline label
 content
Content, copy, testimony
 deploy
Deployment / go-live
 epic
Epic / parent issue
 frontend
Frontend / UI
 hardening
Resilience, fallback, security
 infra
Infrastructure, DevOps, deployment
 priority:critical
Must have for launch
 priority:high
Important for launch
 priority:medium
Nice to have at launch
 protocol
Crisis detection protocol
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-door#102
Delete Branch "fix/overlay-escape-key"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?