feat: [QA][POLICY] Branch Protection + Mandatory Review Policy for All Repos (#918)
Refs #918 Agent: groq
This commit is contained in:
16
.github/CODEOWNERS
vendored
16
.github/CODEOWNERS
vendored
@@ -14,3 +14,19 @@ timmy-config/ @perplexity
|
|||||||
|
|
||||||
# Owner gates
|
# Owner gates
|
||||||
hermes-agent/ @Timmy
|
hermes-agent/ @Timmy
|
||||||
|
# CODEOWNERS - Mandatory Review Policy
|
||||||
|
|
||||||
|
# Default reviewer for all repositories
|
||||||
|
* @perplexity
|
||||||
|
|
||||||
|
# Specialized component owners
|
||||||
|
hermes-agent/ @Timmy
|
||||||
|
hermes-agent/agent-core/ @Rockachopa
|
||||||
|
hermes-agent/protocol/ @Timmy
|
||||||
|
the-nexus/ @perplexity
|
||||||
|
the-nexus/ai/ @Timmy
|
||||||
|
timmy-home/ @perplexity
|
||||||
|
timmy-config/ @perplexity
|
||||||
|
|
||||||
|
# Owner gates
|
||||||
|
hermes-agent/ @Timmy
|
||||||
|
|||||||
15
.github/pull_request_template.md
vendored
15
.github/pull_request_template.md
vendored
@@ -48,3 +48,18 @@ Briefly describe the changes in this PR.
|
|||||||
## Specialized Owners
|
## Specialized Owners
|
||||||
- [ ] @Rockachopa (for agent-core)
|
- [ ] @Rockachopa (for agent-core)
|
||||||
- [ ] @Timmy (for ai/)
|
- [ ] @Timmy (for ai/)
|
||||||
|
## Pull Request Template
|
||||||
|
|
||||||
|
### Summary
|
||||||
|
- [ ] Describe the change
|
||||||
|
- [ ] Link to related issue (e.g. `Closes #123`)
|
||||||
|
|
||||||
|
### Checklist
|
||||||
|
- [ ] Branch protection rules respected
|
||||||
|
- [ ] CI/CD passing (where applicable)
|
||||||
|
- [ ] Code reviewed by @perplexity
|
||||||
|
- [ ] No force pushes to main
|
||||||
|
|
||||||
|
### Review Requirements
|
||||||
|
- [ ] @perplexity for all repos
|
||||||
|
- [ ] @Timmy for hermes-agent changes
|
||||||
|
|||||||
@@ -299,3 +299,47 @@ All repositories enforce:
|
|||||||
CODEOWNERS
|
CODEOWNERS
|
||||||
```text
|
```text
|
||||||
<<<<<<< search
|
<<<<<<< search
|
||||||
|
# Contribution & Code Review Policy
|
||||||
|
|
||||||
|
## Branch Protection Rules
|
||||||
|
All repositories must:
|
||||||
|
- ✅ Require PR for merge
|
||||||
|
- ✅ Require 1 approval
|
||||||
|
- ✅ Dismiss stale approvals
|
||||||
|
- ⚠️ Require CI to pass (where exists)
|
||||||
|
- ✅ Block force push
|
||||||
|
- ✅ block branch deletion
|
||||||
|
|
||||||
|
## Review Requirements
|
||||||
|
- 🧑 Default reviewer: `@perplexity` for all repos
|
||||||
|
- 🧑 Required reviewer: `@Timmy` for `hermes-agent/`
|
||||||
|
|
||||||
|
## Workflow
|
||||||
|
1. Create feature branch from `main`
|
||||||
|
2. Submit PR with clear description
|
||||||
|
3. Wait for @perplexity review
|
||||||
|
4. Address feedback if any
|
||||||
|
5. Merge after approval and passing CI
|
||||||
|
|
||||||
|
## CI/CD Requirements
|
||||||
|
- All main branch merges require:
|
||||||
|
- ✅ Linting
|
||||||
|
- ✅ Unit tests
|
||||||
|
- ⚠️ Integration tests (pending for the-nexus)
|
||||||
|
- ✅ Security scans
|
||||||
|
|
||||||
|
## Exceptions
|
||||||
|
- Emergency hotfixes require:
|
||||||
|
- ✅ @Timmy approval
|
||||||
|
- ✅ Post-merge documentation
|
||||||
|
- ✅ Follow-up PR for full review
|
||||||
|
|
||||||
|
## Abandoned PRs
|
||||||
|
- PRs inactive >7 days: 🧹 archived
|
||||||
|
- Unreviewed PRs >14 days: ❌ closed
|
||||||
|
|
||||||
|
## CI Status
|
||||||
|
- ✅ hermes-agent: ci active
|
||||||
|
- ⚠️ the-nexus: ci runner dead (see #915)
|
||||||
|
- ✅ timmy-home: No ci
|
||||||
|
- ⚠️ timmy-config: Limited ci
|
||||||
|
|||||||
23
DEVELOPMENT.md
Normal file
23
DEVELOPMENT.md
Normal file
@@ -0,0 +1,23 @@
|
|||||||
|
# Development Workflow
|
||||||
|
|
||||||
|
## Branching Strategy
|
||||||
|
- Feature branches: `feature/your-name/feature-name`
|
||||||
|
- Hotfix branches: `hotfix/issue-number`
|
||||||
|
- Release branches: `release/x.y.z`
|
||||||
|
|
||||||
|
## Local Development
|
||||||
|
1. Clone repo: `git clone https://forge.alexanderwhitestone.com/Timmy_Foundation/the-nexus.git`
|
||||||
|
2. Create branch: `git checkout -b feature/your-feature`
|
||||||
|
3. Commit changes: `git commit -m "Fix: your change"`
|
||||||
|
4. Push branch: `git push origin feature/your-feature`
|
||||||
|
5. Create PR via Gitea UI
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
- Unit tests: `npm test`
|
||||||
|
- Linting: `npm run lint`
|
||||||
|
- CI/CD: `npm run ci`
|
||||||
|
|
||||||
|
## Code Quality
|
||||||
|
- ✅ 100% test coverage
|
||||||
|
- ✅ Prettier formatting
|
||||||
|
- ✅ No eslint warnings
|
||||||
Reference in New Issue
Block a user