enforce: 777-line hard limit on JS files — CI gate + pre-commit hook
Some checks failed
Deploy Nexus / deploy (push) Failing after 4s

app.js is a THIN WRAPPER. No file over 777 lines.
Current app.js is 2214 lines — must be broken up before any new features merge.

CI will block PRs that violate this. Pre-commit hook catches it locally.
Install hook: git config core.hooksPath .githooks
This commit is contained in:
Timmy
2026-03-25 11:16:32 -04:00
parent b64699d625
commit 83b53d0659
2 changed files with 44 additions and 9 deletions

View File

@@ -14,15 +14,12 @@ jobs:
- name: Validate HTML
run: |
# Check index.html exists and is valid-ish
test -f index.html || { echo "ERROR: index.html missing"; exit 1; }
# Check for unclosed tags (basic)
python3 -c "
import html.parser, sys
class V(html.parser.HTMLParser):
def __init__(self):
super().__init__()
self.errors = []
def handle_starttag(self, tag, attrs): pass
def handle_endtag(self, tag): pass
v = V()
@@ -36,9 +33,8 @@ jobs:
- name: Validate JavaScript
run: |
# Syntax check all JS files
FAIL=0
for f in $(find . -name '*.js' -not -path './node_modules/*' -not -name 'sw.js'); do
for f in $(find . -name '*.js' -not -path './node_modules/*' -not -name 'sw.js' -not -name 'service-worker.js' -not -path './tests/*'); do
if ! node --check "$f" 2>/dev/null; then
echo "FAIL: $f"
FAIL=1
@@ -50,9 +46,8 @@ jobs:
- name: Validate JSON
run: |
# Check all JSON files parse
FAIL=0
for f in $(find . -name '*.json' -not -path './node_modules/*'); do
for f in $(find . -name '*.json' -not -path './node_modules/*' -not -path './test-*'); do
if ! python3 -c "import json; json.load(open('$f'))"; then
echo "FAIL: $f"
FAIL=1
@@ -62,9 +57,30 @@ jobs:
done
exit $FAIL
- name: Check file size budget
- name: "HARD RULE: No JS file over 777 lines"
run: |
echo "=== File Size Budget: 777 lines max per JS file ==="
FAIL=0
for f in $(find . -name '*.js' -not -path './node_modules/*' -not -path './test-*' -not -path './tests/*'); do
LINES=$(wc -l < "$f" | tr -d ' ')
if [ "$LINES" -gt 777 ]; then
echo "FAIL: $f is $LINES lines (max: 777)"
FAIL=1
else
echo "OK: $f ($LINES lines)"
fi
done
if [ $FAIL -eq 1 ]; then
echo ""
echo "═══════════════════════════════════════════════════"
echo " BLOCKED: No JS file may exceed 777 lines."
echo " Extract into modules. app.js is a THIN WRAPPER."
echo "═══════════════════════════════════════════════════"
fi
exit $FAIL
- name: Check file size budget (bytes)
run: |
# Performance budget: no single JS file > 500KB
FAIL=0
for f in $(find . -name '*.js' -not -path './node_modules/*'); do
SIZE=$(wc -c < "$f")