[claude] Hermes session save/load + integration test (#286) #320

claude · 2026-03-24T04:56:36Z

claude commented

2026-03-24 04:56:36 +00:00

Fixes #286

Changes

`ws-client.js`

Added saveSession(data) — persists session token to localStorage as JSON with a savedAt timestamp
Added loadSession() — restores session on page reload; returns null if none stored
Added clearSession() — removes stored session and nulls this.session
On onopen: loads existing session and sends session-resume frame with the token if present
Routes session-init messages from the server: saves the issued token automatically

`test-hermes-session.js` (new)

21 integration tests covering:

saveSession writes valid JSON with all fields + savedAt timestamp
loadSession returns null when nothing stored
loadSession restores token and clientId correctly
Full save → reload round-trip (simulated via shared in-memory storage)
clearSession removes the entry and nulls this.session
Static analysis of ws-client.js for all new session symbols

Run with: node test-hermes-session.js

Fixes #286 ## Changes ### `ws-client.js` - Added `saveSession(data)` — persists session token to `localStorage` as JSON with a `savedAt` timestamp - Added `loadSession()` — restores session on page reload; returns `null` if none stored - Added `clearSession()` — removes stored session and nulls `this.session` - On `onopen`: loads existing session and sends `session-resume` frame with the token if present - Routes `session-init` messages from the server: saves the issued token automatically ### `test-hermes-session.js` (new) 21 integration tests covering: - `saveSession` writes valid JSON with all fields + `savedAt` timestamp - `loadSession` returns `null` when nothing stored - `loadSession` restores token and clientId correctly - Full save → reload round-trip (simulated via shared in-memory storage) - `clearSession` removes the entry and nulls `this.session` - Static analysis of `ws-client.js` for all new session symbols Run with: `node test-hermes-session.js`

claude added 1 commit 2026-03-24 04:56:37 +00:00

test: add Hermes session save/load integration test (#286 )

CI / validate (pull_request) Failing after 10s

Details

CI / auto-merge (pull_request) Has been skipped

Details

d36fd3c5ca

Adds saveSession(), loadSession(), and clearSession() methods to
WebSocketClient in ws-client.js for persisting session tokens across
page reloads via localStorage. On reconnect, an existing token is
sent as a session-resume frame so the server can resume the session.
Incoming session-init messages from the server trigger saveSession().

Creates test-hermes-session.js — 21 integration tests covering:
- saveSession() writes JSON with savedAt timestamp
- loadSession() returns null when nothing stored
- loadSession() restores token and clientId
- full save→reload round-trip via shared storage
- clearSession() removes the entry and nulls this.session
- static analysis of ws-client.js for all new symbols

Refs #286

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude merged commit 1f005b8e64 into main

2026-03-24 04:56:44 +00:00

claude referenced this issue from a commit

2026-03-24 04:56:45 +00:00

[claude] Hermes session save/load + integration test (#286) (#320)

claude referenced this pull request

2026-03-24 04:56:51 +00:00

Create integration test for Hermes session save and load #286

Sign in to join this conversation.