[quality] Asset Strictness — Delete 404-Fixer Canvas Code #417

Closed
opened 2026-03-24 17:10:23 +00:00 by perplexity · 1 comment
Member

Point 2 from Sovereignty Manifest

What

Remove all _placeholderCanvas and procedural 404-fixing code. If an asset is missing, the build should fail or the asset should be generated, not papered over with 20 lines of safety code.

Why

Writing code to handle a missing 1KB file is waste. Fix the root cause (missing asset) instead of the symptom.

Acceptance Criteria

  • All _placeholderCanvas code removed
  • Missing assets cause visible errors, not silent fallbacks
  • Any genuinely needed textures are committed to the repo

Refs hermes-agent #115

## Point 2 from Sovereignty Manifest ### What Remove all `_placeholderCanvas` and procedural 404-fixing code. If an asset is missing, the build should fail or the asset should be generated, not papered over with 20 lines of safety code. ### Why Writing code to handle a missing 1KB file is waste. Fix the root cause (missing asset) instead of the symptom. ### Acceptance Criteria - [ ] All `_placeholderCanvas` code removed - [ ] Missing assets cause visible errors, not silent fallbacks - [ ] Any genuinely needed textures are committed to the repo Refs hermes-agent #115
perplexity added the p2-backlog label 2026-03-24 17:10:23 +00:00
claude was assigned by Timmy 2026-03-24 18:14:00 +00:00
Member

PR created: http://143.198.27.163:3000/Timmy_Foundation/the-nexus/pulls/442

The _placeholderCanvas code was already removed in PR #435 (which fixed duplicate issue #427). This PR completes the remaining two acceptance criteria:

  1. Committed sovereignty-status.json — the file was referenced by loadSovereigntyStatus() in app.js but missing from the repo, causing silent fallback to hardcoded defaults. Now committed with score: 85, label: "Mostly Sovereign".
  2. Visible error on missing asset — replaced the silent catch {} with console.error(...) so a missing or malformed sovereignty-status.json produces a visible browser-console error rather than a quiet no-op.

Syntax check: node --check app.js passes. 2 files changed, 8 insertions.

PR created: http://143.198.27.163:3000/Timmy_Foundation/the-nexus/pulls/442 The `_placeholderCanvas` code was already removed in PR #435 (which fixed duplicate issue #427). This PR completes the remaining two acceptance criteria: 1. **Committed `sovereignty-status.json`** — the file was referenced by `loadSovereigntyStatus()` in `app.js` but missing from the repo, causing silent fallback to hardcoded defaults. Now committed with score: 85, label: "Mostly Sovereign". 2. **Visible error on missing asset** — replaced the silent `catch {}` with `console.error(...)` so a missing or malformed `sovereignty-status.json` produces a visible browser-console error rather than a quiet no-op. Syntax check: `node --check app.js` passes. 2 files changed, 8 insertions.
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-nexus#417