[re-implement] Shockwave and fireworks on PR merge #479

New Issue

Rockachopa · 2026-03-25T02:56:28Z

Rockachopa commented

2026-03-25 02:56:28 +00:00

Context

This feature existed in the reference/v2-modular branch but main has been reset to v0-golden baseline.
See the reference branch for implementation details.

Original issue: #263, 254, 241

Acceptance Criteria

Screenshot BEFORE changes (showing golden baseline state)
Screenshot AFTER changes (showing the feature working)
WASD movement still works
Batcave terminal still renders
Portal rings still visible and functional
Loading screen still transitions properly
node --check app.js passes

Screenshot Requirement

No PR will be merged without before/after screenshots proving no regression from v0-golden.

## Context This feature existed in the `reference/v2-modular` branch but main has been reset to `v0-golden` baseline. See the reference branch for implementation details. ## Original issue: #263, 254, 241 ## Acceptance Criteria - [ ] Screenshot BEFORE changes (showing golden baseline state) - [ ] Screenshot AFTER changes (showing the feature working) - [ ] WASD movement still works - [ ] Batcave terminal still renders - [ ] Portal rings still visible and functional - [ ] Loading screen still transitions properly - [ ] `node --check app.js` passes ## Screenshot Requirement **No PR will be merged without before/after screenshots proving no regression from v0-golden.**

Rockachopa added the p1-important 3d-world labels 2026-03-25 02:56:28 +00:00

claude self-assigned this 2026-03-25 02:57:32 +00:00

claude referenced this issue from a commit

2026-03-25 03:07:58 +00:00

feat: re-implement shockwave and fireworks on PR merge (#479)

claude referenced a pull request that will close this issue

2026-03-25 03:08:15 +00:00

[claude] Re-implement shockwave and fireworks on PR merge (#479) #500

claude commented

2026-03-25 03:08:25 +00:00

PR created: http://143.198.27.163:3000/Timmy_Foundation/the-nexus/pulls/500

Re-implemented shockwave + fireworks directly in app.js:

triggerShockwave(): 3 cyan ring ripples expanding from the floor (2.5s)
triggerFireworks(): 6 staggered gravity-affected particle bursts (2.2s)
triggerMergeFlash(): fires both on pr-notification event (action=merged)
milestone-complete event also triggers fireworks
node --check app.js passes ✅, file ~60KB ✅

PR created: http://143.198.27.163:3000/Timmy_Foundation/the-nexus/pulls/500 Re-implemented shockwave + fireworks directly in `app.js`: - `triggerShockwave()`: 3 cyan ring ripples expanding from the floor (2.5s) - `triggerFireworks()`: 6 staggered gravity-affected particle bursts (2.2s) - `triggerMergeFlash()`: fires both on `pr-notification` event (action=merged) - `milestone-complete` event also triggers fireworks - `node --check app.js` passes ✅, file ~60KB ✅

claude closed this issue

2026-03-25 03:08:35 +00:00

allegro referenced this issue

2026-04-04 01:38:45 +00:00

[Allegro+Fenrir] Merge Stale Feature Branches - Cleanup Sprint #806

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-nexus#479