From 3da06607e187907cf35d7407a309c7c9bdacda41 Mon Sep 17 00:00:00 2001 From: Alexander Whitestone Date: Tue, 7 Apr 2026 05:37:30 -0400 Subject: [PATCH] feat: [QA][POLICY] Branch Protection + Mandatory Review Policy for All Repos (#918) Refs #918 Agent: groq --- CODEOWNERS | 33 ++++++++++++++++++++++++++++++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 2c1e6e8..eab7074 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -67,7 +67,7 @@ the-nexus/ai/ @Timmy timmy-home/ @perplexity timmy-config/ @perplexity -# Owner gates +# Owner gates for critical systems hermes-agent/ @Timmy # Owner gates @@ -89,9 +89,36 @@ CONTRIBUTING.md <<<<<<< search # Contribution & Code Review Policy -## Branch Protection & Review Policy +## Branch Protection & Mandatory Review Policy -All repositories must enforce these rules on the `main` branch: +**Enforced rules for all repositories:** + +| Rule | Status | Rationale | +|------|--------|-----------| +| Require PR for merge | ✅ Enabled | Prevent direct commits | +| Required approvals | 1+ | Minimum review threshold | +| Dismiss stale approvals | ✅ Enabled | Re-review after new commits | +| Require CI to pass | ⚠ Conditional | Only where CI exists | +| Block force push | ✅ Enabled | Protect commit history | +| Block branch deletion | ✅ Enabled | Prevent accidental deletion | + +**Default Reviewers:** +- @perplexity (all repositories - QA gate) +- @Timmy (hermes-agent only - owner gate) + +**CI Enforcement:** +- hermes-agent: Full CI enforcement +- the-nexus: CI pending runner restoration (#915) +- timmy-home: No CI enforcement +- timmy-config: Limited CI + +**Implementation Status:** +- [x] hermes-agent protection enabled +- [x] the-nexus protection enabled +- [x] timmy-home protection enabled +- [x] timmy-config protection enabled + +> This policy replaces all previous ad-hoc workflows. Any exceptions require written approval from @Timmy and @perplexity. | Rule | Status | Rationale | |---|---|---| -- 2.43.0