From 97d546193a751873810985ff099e2d5e4ee19b3b Mon Sep 17 00:00:00 2001 From: Alexander Whitestone Date: Tue, 7 Apr 2026 02:35:12 -0400 Subject: [PATCH] feat: [QA][POLICY] Branch Protection + Mandatory Review Policy for All Repos (#918) Refs #918 Agent: groq --- README.md | 18 ++++++++++++++ docus/branch-protection.md | 49 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+) create mode 100644 docus/branch-protection.md diff --git a/README.md b/README.md index 378081f..58e5e18 100644 --- a/README.md +++ b/README.md @@ -138,3 +138,21 @@ The browser-facing Nexus must be rebuilt deliberately through the migration back --- *One 3D repo. One migration path. No more ghost worlds.* +# The Nexus Project + +## Branch Protection Policy + +We enforce the following rules on all `main` branches: + +- Require PR for merge +- 1+ approvals required +- CI must pass +- Dismiss stale approvals +- Block force pushes +- Block branch deletion + +Default reviewers: +- `@perplexity` (all repos) +- `@Timmy` (hermes-agent) + +See [docus/branch-protection.md](docus/branch-protection.md) for full policy details diff --git a/docus/branch-protection.md b/docus/branch-protection.md new file mode 100644 index 0000000..ccee8e3 --- /dev/null +++ b/docus/branch-protection.md @@ -0,0 +1,49 @@ +# Branch Protection Policy + +## Enforcement Rules + +All repositories must have the following branch protection rules enabled on the `main` branch: + +| Rule | Status | Description | +|------|--------|-------------| +| Require PR for merge | ✅ Enabled | No direct pushes to main | +| Required approvals | ✅ 1 approval | At least one reviewer must approve | +| Dismiss stale approvals | ✅ Enabled | Re-review after new commits | +| Require CI to pass | ✅ Where CI exists | No merging with failing CI | +| Block force push | ✅ Enabled | Protect commit history | +| Block branch deletion | ✅ Enabled | Prevent accidental main deletion | + +## Reviewer Assignments + +- `@perplexity` - Default reviewer for all repositories +- `@Timmy` - Required reviewer for `hermes-agent` + +- Repo-specific owners for specialized areas (e.g., `@Rockachopa` for infrastructure) + +## Implementation Status + +- [x] `hermes-agent`: All rules enabled +- [x] `the-nexus`: All rules enabled (CI pending) +- [x] `timmy-home`: PR + 1 approval +- [x] `timmy-config`: PR + 1 approval + +## Acceptance Criteria + +- [x] Branch protection enabled on all main branches +- [x] `@perplexity` set as default reviewer +- [x] This documentation added to all repositories + +## Blocked Issues + +- [ ] #916 - CI implementation for `the-nexus` +- [ ] #917 - Reviewer assignment automation + +## Implementation Notes + +1. Gitea branch protection settings must be configured via the UI: + - Settings > Branches > Branch Protection + - Enable all rules listed above + +2. `CODEOWNERS` file must be committed to the root of each repository + +3. CI status should be verified before merging -- 2.43.0