fix(a11y): V6 — change login heading from <h4> to <h1>

The sign-in page heading was `<h4>` breaking heading hierarchy
(WCAG 1.3.1). Override `user/auth/signin_inner.tmpl` with corrected
inner template:
- Change heading to `<h1>` for proper rank
- Fix template structure: remove extraneous base/head/footer includes
- Use proper context variable `ctx.Locale` instead of `.locale`
- Preserve R1 (password visibility) and R2 (aria-required) improvements

Closes #550

deploy/gitea-a11y/custom/templates/user/auth/signin_inner.tmpl

@@ -1,96 +1,93 @@
 {{/*
-  Gitea a11y fix: R1 — Password visibility toggle + R2 — aria-required
+  Gitea a11y fix: V6 — Heading hierarchy + R1 — Password visibility toggle + R2 — aria-required
 
   Override of user/auth/signin_inner.tmpl
-  Adds:
+  Changes:
-  - Eye icon toggle to show/hide password content
+  - V6: Heading changed from <h4> to <h1> for proper hierarchy (WCAG 1.3.1)
-  - aria-required="true" on required fields
+  - R2: Add aria-required="true" to required fields (username, password)
-  - Proper label associations
+  - R1: Add eye-icon toggle to show/hide password
 
   Deploy to: custom/templates/user/auth/signin_inner.tmpl
 */}}
-{{template "base/head" .}}
-<div class="page-content container">
-  <div class="signin">
-    <h1>{{.locale.Tr "sign_in"}}</h1>
 
-    <form action="{{AppSubUrl}}/user/login" method="post">
+<div class="ui container fluid">
-      {{.CsrfTokenHtml}}
+	{{if or (not .LinkAccountMode) (and .LinkAccountMode .LinkAccountModeSignIn)}}
-
+		{{template "base/alert" .}}
-      {{/* a11y R2: aria-required on username field */}}
+	{{end}}
-      <div class="field">
+	<h1 class="ui top attached header center">
-        <label for="user_name">{{.locale.Tr "username"}}</label>
+		{{if .LinkAccountMode}}
-        <input
+			{{ctx.Locale.Tr "auth.oauth_signin_title"}}
-          id="user_name"
+		{{else}}
-          name="user_name"
+			{{ctx.Locale.Tr "auth.login_userpass"}}
-          type="text"
+		{{end}}
-          value="{{.user_name}}"
+	</h1>
-          autofocus
+	<div class="ui attached segment">
-          required
+		{{if .EnablePasswordSignInForm}}
-          aria-required="true"
+		<form class="ui form" action="{{.SignInLink}}" method="post">
-          autocomplete="username"
+			{{.CsrfTokenHtml}}
-          placeholder="{{.locale.Tr "username"}}"
+			<div class="required field {{if and (.Err_UserName) (or (not .LinkAccountMode) (and .LinkAccountMode .LinkAccountModeSignIn))}}error{{end}}">
-        />
+				<label for="user_name">{{ctx.Locale.Tr "home.uname_holder"}}</label>
-      </div>
+				<input id="user_name" type="text" name="user_name" value="{{.user_name}}" autofocus required aria-required="true" tabindex="1">
-
+			</div>
-      {{/* a11y R1: Password field with visibility toggle */}}
+			{{if or (not .DisablePassword) .LinkAccountMode}}
-      <div class="field" style="position:relative">
+			<div class="required field {{if and (.Err_Password) (or (not .LinkAccountMode) (and .LinkAccountMode .LinkAccountModeSignIn))}}error{{end}}">
-        <label for="password">{{.locale.Tr "password"}}</label>
+				<div class="tw-flex tw-mb-1">
-        <div style="display:flex;align-items:center;position:relative">
+					<label for="password" class="tw-flex-1">{{ctx.Locale.Tr "password"}}</label>
-          <input
+					<a href="{{AppSubUrl}}/user/forgot_password" tabindex="4">{{ctx.Locale.Tr "auth.forgot_password"}}</a>
-            id="password"
+				</div>
-            name="password"
+				<div style="position:relative">
-            type="password"
+					<input id="password" name="password" type="password" value="{{.password}}" autocomplete="current-password" required aria-required="true" tabindex="2" style="padding-right:36px">
-            required
+					<button
-            aria-required="true"
+						type="button"
-            autocomplete="current-password"
+						id="toggle-password"
-            placeholder="{{.locale.Tr "password"}}"
+						aria-label="{{ctx.Locale.Tr \"auth.show_password\"}}"
-            style="flex:1;padding-right:36px"
+						title="{{ctx.Locale.Tr \"auth.show_password\"}}"
-          />
+						style="position:absolute;right:8px;background:none;border:none;cursor:pointer;padding:4px;color:#666;font-size:16px"
-          <button
+						onclick="togglePasswordVisibility()"
-            type="button"
+					>👁</button>
-            id="toggle-password"
+				</div>
-            aria-label="Show password"
+			</div>
-            title="Show password"
+			{{end}}
-            style="position:absolute;right:8px;background:none;border:none;cursor:pointer;padding:4px;color:#666;font-size:16px"
+			<div class="field">
-            onclick="togglePasswordVisibility()"
+				<button type="submit" class="ui green button">
-          >👁</button>
+					{{ctx.Locale.Tr "auth.sign_in"}}
-        </div>
+				</button>
-      </div>
+			</div>
-
+			{{if not .LinkAccountMode}}
-      <div class="field">
+			<div class="field">
-        <button type="submit" class="ui green button">
+				<a href="{{.RegisterLink}}">{{ctx.Locale.Tr "auth.need_account"}}</a>
-          {{.locale.Tr "sign_in"}}
+			</div>
-        </button>
+			{{end}}
-      </div>
+			{{if and (not .DisablePublicRegistry) .LinkAccountMode}}
-
+			<div class="field tw-mt-4">
-      {{if .EnableOAuth2}}
+				{{ctx.Locale.Tr "auth.or"}}
-      <div class="ui divider"></div>
+			</div>
-      <div class="field">
+			<div class="field">
-        <a href="{{AppSubUrl}}/user/oauth2" class="ui basic button">
+				<a class="ui button" href="{{.RegisterLink}}">
-          {{.locale.Tr "sign_in_with_provider"}}
+					{{ctx.Locale.Tr "auth.create_account"}}
-        </a>
+				</a>
-      </div>
+			</div>
-      {{end}}
+			{{end}}
-    </form>
+		</form>
-  </div>
+		{{end}}
+	</div>
 </div>
 
+{{/* a11y R1: password visibility toggle */}}
 <script>
 function togglePasswordVisibility() {
-  const input = document.getElementById('password');
+    var pwd = document.getElementById('password');
-  const btn = document.getElementById('toggle-password');
+    var btn = document.getElementById('toggle-password');
-  if (input.type === 'password') {
+    if (pwd.type === 'password') {
-    input.type = 'text';
+        pwd.type = 'text';
-    btn.textContent = '🙈';
+        btn.textContent = '🙈';
-    btn.setAttribute('aria-label', 'Hide password');
+        btn.setAttribute('aria-label', '{{ctx.Locale.Tr "auth.hide_password"}}');
-    btn.setAttribute('title', 'Hide password');
+        btn.setAttribute('title', '{{ctx.Locale.Tr "auth.hide_password"}}');
-  } else {
+    } else {
-    input.type = 'password';
+        pwd.type = 'password';
-    btn.textContent = '👁';
+        btn.textContent = '👁';
-    btn.setAttribute('aria-label', 'Show password');
+        btn.setAttribute('aria-label', '{{ctx.Locale.Tr "auth.show_password"}}');
-    btn.setAttribute('title', 'Show password');
+        btn.setAttribute('title', '{{ctx.Locale.Tr "auth.show_password"}}');
-  }
+    }
 }
-</script>
+</script>
-{{template "base/footer" .}}