Commit Graph

5 Commits

Author SHA1 Message Date
e1abecbc54 fix: address all 7 review items from Timmy's code review
1. Add MAX_FILE_SIZE check (50MB) to prevent unbounded memory usage
2. Add 'lighting' to JSON repair field list
3. Seek 2s into video before extracting frame + log ffmpeg stderr
4. Fix --model default to None so auto-detect actually works
6. Wrap temp frame cleanup in try/finally for crash safety
7. Reduce inter-file sleep to 0.1s (Ollama is local, no rate limit needed)

Test coverage gap (item #5) tracked for follow-up.
2026-04-15 11:17:24 +00:00
e176fadef5 fix: make --input optional when --check-model is used 2026-04-15 09:54:22 +00:00
7ca2ebe6b5 fix: increase token limit and improve JSON repair for truncated responses 2026-04-15 09:50:31 +00:00
e9d2cb5e56 fix: improve JSON parsing fallback and default to gemma4 2026-04-15 09:42:27 +00:00
990676fb02 feat: enhance scene description generator for #689
- Auto-detect best vision model (gemma4:latest preferred)
- Add --check-model flag for model availability
- Add --format sharegpt for training pipeline integration
- Add retry logic for Ollama API calls
- Add video frame extraction with ffmpeg
- Structured JSON output with validation
- Comprehensive CLI with --help

Closes #689
2026-04-15 09:37:25 +00:00