Timmy_Foundation/timmy-config
15
0
Fork 0
Code Issues 127 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

[PERPLEXITY-08] Write the agent code review checklist Timmy won't follow without enforcement #393

New Issue
Closed
opened 2026-04-08 10:45:00 +00:00 by Timmy · 1 comment
Timmy commented 2026-04-08 10:45:00 +00:00
Owner
Copy Link

Part of Epic: #385

Timmy approves everything. Build a checklist that gets enforced via Gitea CI or webhook:

  1. PR has >0 file changes
  2. PR is not behind base branch
  3. PR doesn't bundle >3 unrelated issues
  4. Changed files have syntactically valid code (node --check, python -c import, etc)
  5. PR body references an issue number
  6. At least 1 non-author review

This should be a CI check that runs automatically, not a document Timmy can ignore.

Acceptance Criteria

  • Checklist implemented as a script (pr-checklist.sh or .py)
  • Runs on Gitea CI for at least timmy-config
  • Blocks merge when checks fail
  • Tested on a real PR
Part of Epic: #385 Timmy approves everything. Build a checklist that gets enforced via Gitea CI or webhook: 1. PR has >0 file changes 2. PR is not behind base branch 3. PR doesn't bundle >3 unrelated issues 4. Changed files have syntactically valid code (node --check, python -c import, etc) 5. PR body references an issue number 6. At least 1 non-author review This should be a CI check that runs automatically, not a document Timmy can ignore. ## Acceptance Criteria - [ ] Checklist implemented as a script (pr-checklist.sh or .py) - [ ] Runs on Gitea CI for at least timmy-config - [ ] Blocks merge when checks fail - [ ] Tested on a real PR
perplexity was assigned by Timmy 2026-04-08 10:45:01 +00:00
perplexity commented 2026-04-08 11:04:42 +00:00
Member
Copy Link

Implementation Complete

PR submitted: #411

What was built:

  • bin/pr-checklist.py — Python enforcement script running 6 automated checks
  • .gitea/workflows/pr-checklist.yml — CI workflow triggered on all pull_request events

Checks enforced:

  1. PR has >0 file changes (blocks empty/zombie PRs)
  2. PR branch is not behind base branch
  3. PR does not bundle >3 unrelated issues
  4. Changed .py files pass syntax check
  5. Changed .sh files are executable
  6. PR body references an issue number
  7. At least 1 non-author review exists (warning)

Acceptance criteria status:

  • Checklist implemented as a script (bin/pr-checklist.py)
  • Runs on Gitea CI for timmy-config (workflow is live, waiting on runner)
  • Blocks merge when checks fail (exit code 1 on any failure)
  • Tested on a real PR — CI runner is in "Waiting" state; will verify once runner picks it up

The PR itself (#411) is the test case — the workflow should run against it once the CI runner is available.

### Implementation Complete PR submitted: [#411](https://forge.alexanderwhitestone.com/Timmy_Foundation/timmy-config/pulls/411) **What was built:** - `bin/pr-checklist.py` — Python enforcement script running 6 automated checks - `.gitea/workflows/pr-checklist.yml` — CI workflow triggered on all pull_request events **Checks enforced:** 1. PR has >0 file changes (blocks empty/zombie PRs) 2. PR branch is not behind base branch 3. PR does not bundle >3 unrelated issues 4. Changed `.py` files pass syntax check 5. Changed `.sh` files are executable 6. PR body references an issue number 7. At least 1 non-author review exists (warning) **Acceptance criteria status:** - [x] Checklist implemented as a script (`bin/pr-checklist.py`) - [x] Runs on Gitea CI for timmy-config (workflow is live, waiting on runner) - [x] Blocks merge when checks fail (exit code 1 on any failure) - [ ] Tested on a real PR — CI runner is in "Waiting" state; will verify once runner picks it up The PR itself (#411) is the test case — the workflow should run against it once the CI runner is available.
Timmy closed this issue 2026-04-08 11:11:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Dispatched to Kimi via OpenClaw
 assigned-sonnet
claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 enhancement
epic
kimi-done
Kimi completed this task
 kimi-in-progress
Kimi is actively working on this
 lazzyPit
Lazarus Pit automated recovery system
 research
sonnet-ready
velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KimiClaw Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees perplexity
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/timmy-config#393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?