perf: bulk-authorize push devices (Closes #725)

src/dashboard_auth.py

@@ -244,6 +244,14 @@ async def managed_session_active(management_id: str) -> bool:
     return status == "active"
 
 
+async def managed_session_statuses(management_ids) -> dict[str, str]:
+    return await asyncio.to_thread(
+        _session_store().managed_statuses,
+        management_ids,
+        idle_timeout_seconds=idle_timeout_seconds(),
+    )
+
+
 async def touch_session(session: Session) -> bool:
     return await asyncio.to_thread(
         _session_store().touch,

src/main.py

@@ -128,7 +128,7 @@ async def _push_poll_loop() -> None:
                 _push_subscription_store,
                 _push_configuration(),
                 gitea_proxy.unread_notification_snapshot,
-                session_active=dashboard_auth.managed_session_active,
+                session_statuses=dashboard_auth.managed_session_statuses,
                 lease_seconds=lease_seconds,
                 send_timeout_seconds=send_timeout,
                 max_concurrency=max_concurrency,
@@ -140,7 +140,7 @@ async def _push_poll_loop() -> None:
                 _push_subscription_store,
                 _push_configuration(),
                 gitea_proxy.assigned_issue_snapshot,
-                session_active=dashboard_auth.managed_session_active,
+                session_statuses=dashboard_auth.managed_session_statuses,
                 send_timeout_seconds=send_timeout,
                 lease_seconds=lease_seconds,
                 max_concurrency=max_concurrency,

src/push_notifications.py

@@ -49,7 +49,7 @@ async def dispatch_unread_updates(
     unread: Callable[[], Awaitable[dict]],
     send: Callable[[dict, str], Awaitable[None]] | None = None,
     *,
-    session_active: Callable[[str], Awaitable[bool]] | None = None,
+    session_statuses: Callable[[list[str]], Awaitable[dict[str, str]]] | None = None,
     lease_seconds: float = 60.0,
     send_timeout_seconds: float = 10.0,
     max_concurrency: int = 8,
@@ -79,20 +79,22 @@ async def dispatch_unread_updates(
         }
         await asyncio.to_thread(store.reconcile_unread, thread_revisions)
         deliveries = await asyncio.to_thread(store.claim_unseen, thread_revisions)
-        if session_active is not None:
+        if session_statuses is not None:
             try:
-                authorized = [await session_active(item.session_id) for item in deliveries]
+                statuses = await session_statuses(
+                    [item.session_id for item in deliveries]
+                )
             except Exception:
                 # Authorization state is mandatory for delivery. Preserve subscriptions
                 # so a temporary registry failure can be retried safely.
                 return 0
-            for delivery, active in zip(deliveries, authorized):
-                if not active:
+            for delivery in deliveries:
+                if statuses.get(delivery.session_id) != "active":
                     await asyncio.to_thread(store.delete_session, delivery.session_id)
             deliveries = [
                 delivery
-                for delivery, active in zip(deliveries, authorized)
-                if active
+                for delivery in deliveries
+                if statuses.get(delivery.session_id) == "active"
             ]
         semaphore = asyncio.Semaphore(max(1, max_concurrency))
         ownership_lost = asyncio.Event()
@@ -277,7 +279,7 @@ async def _dispatch_deadline_reminders_unlocked(
     send: Callable[[dict, str], Awaitable[None]] | None = None,
     *,
     now: datetime | None = None,
-    session_active: Callable[[str], Awaitable[bool]] | None = None,
+    session_statuses: Callable[[list[str]], Awaitable[dict[str, str]]] | None = None,
     send_timeout_seconds: float = 10.0,
     lease_seconds: float = 60.0,
     max_concurrency: int = 8,
@@ -318,6 +320,35 @@ async def _dispatch_deadline_reminders_unlocked(
         due_days.append(due_day)
     if not due_days:
         return 0
+    due_counts = {}
+    for device in eligible_devices:
+        local_now = current.astimezone(ZoneInfo(device.timezone))
+        local_cutoff = local_now.date() + timedelta(days=2)
+        due_count = sum(due_day <= local_cutoff for due_day in due_days)
+        if due_count:
+            due_counts[device.session_id] = due_count
+    eligible_devices = [
+        device for device in eligible_devices if device.session_id in due_counts
+    ]
+    if not eligible_devices:
+        return 0
+    if session_statuses is not None:
+        try:
+            statuses = await session_statuses(
+                [device.session_id for device in eligible_devices]
+            )
+        except Exception:
+            return 0
+        for device in eligible_devices:
+            if statuses.get(device.session_id) != "active":
+                await asyncio.to_thread(store.delete_session, device.session_id)
+        eligible_devices = [
+            device
+            for device in eligible_devices
+            if statuses.get(device.session_id) == "active"
+        ]
+        if not eligible_devices:
+            return 0
     semaphore = asyncio.Semaphore(max(1, max_concurrency))
 
     async def dispatch_device(device) -> int:
@@ -332,13 +363,7 @@ async def _dispatch_deadline_reminders_unlocked(
                 or device.delivered_local_day == local_day
             ):
                 return 0
-            local_cutoff = local_now.date() + timedelta(days=2)
-            due_count = sum(due_day <= local_cutoff for due_day in due_days)
-            if not due_count:
-                return 0
-            if session_active is not None and not await session_active(device.session_id):
-                await asyncio.to_thread(store.delete_session, device.session_id)
-                return 0
+            due_count = due_counts[device.session_id]
             still_owner = await asyncio.to_thread(
                 store.acquire_dispatch_lease,
                 owner,

src/session_store.py

@@ -273,21 +273,40 @@ class SessionStore:
 
     def managed_status(self, management_id: str, *, idle_timeout_seconds: int) -> str:
         """Return the authorization state for a durable device identifier."""
+        return self.managed_statuses(
+            [management_id], idle_timeout_seconds=idle_timeout_seconds
+        )[management_id]
+
+    def managed_statuses(
+        self, management_ids, *, idle_timeout_seconds: int
+    ) -> dict[str, str]:
+        """Return authorization states for durable device identifiers in one read."""
+        requested = set(management_ids)
+        if not requested:
+            return {}
         now = int(self.clock())
         try:
             with self._connect() as connection:
-                row = connection.execute(
-                    "SELECT expires_at, last_active_at FROM active_sessions "
-                    "WHERE management_id = ?",
-                    (management_id,),
-                ).fetchone()
+                placeholders = ",".join("?" for _ in requested)
+                rows = connection.execute(
+                    "SELECT management_id, expires_at, last_active_at "
+                    f"FROM active_sessions WHERE management_id IN ({placeholders})",
+                    tuple(requested),
+                ).fetchall()
         except (OSError, sqlite3.Error) as exc:
             raise SessionStoreError("Session registry is temporarily unavailable") from exc
-        if row is None or row[0] <= now:
-            return "revoked"
-        if row[1] + max(1, idle_timeout_seconds) <= now:
-            return "idle"
-        return "active"
+        known = {row[0]: row[1:] for row in rows if row[0] in requested}
+        idle_timeout = max(1, idle_timeout_seconds)
+        statuses = {}
+        for management_id in requested:
+            row = known.get(management_id)
+            if row is None or row[0] <= now:
+                statuses[management_id] = "revoked"
+            elif row[1] + idle_timeout <= now:
+                statuses[management_id] = "idle"
+            else:
+                statuses[management_id] = "active"
+        return statuses
 
     def revoke_managed(self, management_id: str) -> bool:
         try: