feat: reply, mark read, and continue updates (Closes #503)

frontend/authored-outbox.js

@@ -4,7 +4,7 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
     globalThis.crypto?.randomUUID?.() || String(Date.now()) + '-' + Math.random().toString(16).slice(2)
   );
   const pending = new Map();
-  const supportedKinds = new Set(['issue-comment', 'pull-comment', 'update-reply', 'pull-review', 'issue-close']);
+  const supportedKinds = new Set(['issue-comment', 'pull-comment', 'update-reply', 'update-reply-read', 'pull-review', 'issue-close']);
 
   function reviewFingerprint(message) {
     return JSON.stringify({
@@ -74,6 +74,7 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
       ownerLogin,
       status: 'queued',
       queuedAt: Number(now()),
+      ...(message.kind === 'update-reply-read' ? { replyConfirmed: message.replyConfirmed === true } : {}),
       ...(message.kind === 'issue-comment' && message.attachment ? {
         attachment: {
           filename: String(message.attachment.filename || ''),
@@ -183,7 +184,24 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
           }
           result = delivery.message;
         } else {
-          if (item.kind === 'issue-close') {
+          if (item.kind === 'update-reply-read') {
+            if (!item.replyConfirmed) {
+              await fetchJson('api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/reply', {
+                method: 'POST',
+                headers: {
+                  Accept: 'application/json', 'Content-Type': 'application/json',
+                  'Idempotency-Key': item.operationId,
+                },
+                body: JSON.stringify({ body: item.body }),
+              });
+              write(read().map(candidate => candidate.id === item.id ? {
+                ...candidate, replyConfirmed: true, status: 'sending', lastAttemptAt: attemptAt,
+              } : candidate), false);
+            }
+            result = await fetchJson('api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/read', {
+              method: 'PATCH', headers: { Accept: 'application/json' },
+            });
+          } else if (item.kind === 'issue-close') {
             result = await fetchJson(endpoint(item), {
               method: 'PATCH',
               headers: { Accept: 'application/json', 'Idempotency-Key': item.operationId },

frontend/background-issue-sync.js

@@ -311,7 +311,7 @@ function createBackgroundIssueSync({
     if (item.kind === 'notification-read') {
       return { id: item.id, status, kind: 'notification-read', route: '#/my-work/updates' };
     }
-    if (item.kind === 'update-reply') {
+    if (item.kind === 'update-reply' || item.kind === 'update-reply-read') {
       return { id: item.id, status, kind: 'message', route: '#/my-work/update/' + encodeURIComponent(item.notificationId) };
     }
     const repository = String(item.repository || '').split('/').map(encodeURIComponent).join('/');
@@ -344,6 +344,12 @@ function createBackgroundIssueSync({
     if (item.kind === 'update-reply') {
       return authoredRequest('api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/reply', item);
     }
+    if (item.kind === 'update-reply-read') {
+      return {
+        url: base + 'api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/read',
+        options: { method: 'PATCH', headers: { Accept: 'application/json' } },
+      };
+    }
     const repository = String(item.repository || '').split('/').map(encodeURIComponent).join('/');
     if (item.kind === 'issue-close') {
       return {
@@ -420,6 +426,22 @@ function createBackgroundIssueSync({
     return String(operationId || '').slice(0, 128 - suffix.length) + suffix;
   }
 
+  async function deliverReplyRead(item) {
+    let current = item;
+    if (!current.replyConfirmed) {
+      await requestStage(
+        current,
+        base + 'api/v1/notifications/' + encodeURIComponent(current.notificationId) + '/reply',
+        authoredRequest('', current).options,
+      );
+      const checkpointed = await checkpointClaim(current, stored => ({ ...stored, replyConfirmed: true }));
+      if (checkpointed === false) throw new Error('Background delivery claim was lost.');
+      current = { ...current, replyConfirmed: true };
+    }
+    const request = deliveryRequest(current);
+    return requestStage(current, request.url, request.options);
+  }
+
   function attachmentMultipart(attachment) {
     let blob = attachment?.blob;
     if (!blob && attachment?.data) {
@@ -520,7 +542,8 @@ function createBackgroundIssueSync({
   async function deliver(item) {
     const request = deliveryRequest(item);
     try {
-      const delivered = item.attachment && item.kind === 'issue-comment' ?
+      const delivered = item.kind === 'update-reply-read' ? await deliverReplyRead(item) :
+        item.attachment && item.kind === 'issue-comment' ?
         await deliverScreenshotComment(item) : item.attachment && !item.kind ?
           await deliverIssueCapture(item) : await requestStage(item, request.url, request.options);
       if (item.kind === 'issue-close' && delivered?.state !== 'closed') {

frontend/dashboard.js

@@ -615,8 +615,7 @@
       qs('#update-reply').value = notificationReplier.loadDraft(item);
       qs('#update-reply-status').textContent = '';
       qs('#send-update-reply').disabled = false;
-      qs('#send-update-reply-next').disabled = false;
-      setUpdateReplyNextVisibility();
+      qs('#send-update-reply-read-next').disabled = false;
       qs('#update-ownership-action').hidden = true;
       qs('#retry-update-load').hidden = true;
       setOfflineUpdateControls(false);
@@ -1019,9 +1018,7 @@
     const item = kind === 'issue' ? selectedIssue : selectedPull;
     qs('#send-' + kind + '-comment-next').hidden = !item || !workSession.checkpointed(item);
   }
-  function setUpdateReplyNextVisibility() {
-    qs('#send-update-reply-next').hidden = !selectedUpdate || !workSession.checkpointed(selectedUpdate);
-  }
+
   const issueCommentNext = createCommentNext({
     post: async (item, body) => {
       const comment = await issueController.comment(item, body);
@@ -1056,25 +1053,16 @@
       failureMessage: 'Comment saved, but Today still needs completion.',
     }),
   });
-  const updateReplyNext = createCommentNext({
-    queueKind: 'update-reply',
+  const updateReplyReadNext = createUpdateReplyReadNext({
     post: (item, body, operationId) => postNotificationReply(item.notification_id, body, operationId),
+    markRead: markNotificationRead,
     queue: message => authoredOutbox.enqueueDurably(message),
     canQueue: canQueueMessage,
-    accept: (item, result) => {
+    accept: item => {
       notificationReplier.saveDraft(item, '');
-      if (selectedUpdate === item) {
-        qs('#update-reply').value = '';
-        if (result.comment) notificationReader.appendReply(result.comment);
-        qs('#update-reply-status').textContent = result.delivery === 'queued' ?
-          'Reply queued for background delivery.' : result.delivery === 'saved' ?
-            'Reply saved for next-launch delivery.' : 'Reply posted.';
-      }
+      if (selectedUpdate === item) qs('#update-reply').value = '';
     },
-    complete: item => completeTodayItem(item, {
-      successMessage: 'Reply saved. Next Today item opened.',
-      failureMessage: 'Reply saved, but Today still needs completion.',
-    }),
+    next: item => notificationReader.acceptReadAndNext(lastMyWork, item),
   });
   const closeOfflineIssue = createOfflineIssueClose({
     enqueueDurably: message => authoredOutbox.enqueueDurably(message),
@@ -4326,7 +4314,7 @@
       qs('#update-reply').focus();
     }
   });
-  qs('#send-update-reply-next').addEventListener('click', async () => {
+  qs('#send-update-reply-read-next').addEventListener('click', async () => {
     if (!selectedUpdate) return;
     const item = selectedUpdate;
     const body = qs('#update-reply').value.trim();
@@ -4335,14 +4323,17 @@
       qs('#update-reply').focus();
       return;
     }
-    const button = qs('#send-update-reply-next');
+    const button = qs('#send-update-reply-read-next');
     const sendButton = qs('#send-update-reply');
     button.disabled = true;
     sendButton.disabled = true;
-    qs('#update-reply-status').textContent = 'Sending reply…';
+    qs('#update-reply-status').textContent = 'Replying, then marking read…';
     const operationId = globalThis.crypto?.randomUUID?.() || String(Date.now()) + '-' + Math.random();
     try {
-      await updateReplyNext.submit(item, body, operationId);
+      const result = await updateReplyReadNext.submit(item, body, operationId);
+      if (result?.accepted) qs('#my-work-action-status').textContent =
+        result.delivery === 'posted' ? 'Reply posted and update marked read.' :
+          'Reply and read acknowledgement queued for sync.';
     } catch (error) {
       qs('#update-reply-status').textContent = error.message + ' Your draft is safe; retry.';
       qs('#update-reply').focus();

frontend/drafts.js

@@ -141,7 +141,7 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
       const currentLogin = String(getCurrentLogin() || '').trim();
       return record.items.filter(item => item && typeof item.id === 'string' && typeof item.body === 'string')
         .map(item => {
-          const isUpdate = item.kind === 'update-reply';
+          const isUpdate = item.kind === 'update-reply' || item.kind === 'update-reply-read';
           const isReview = item.kind === 'pull-review';
           const isClosure = item.kind === 'issue-close';
           const routeKind = isReview ? 'review' : (item.kind === 'pull-comment' ? 'pull' : 'issue');

frontend/index.html

@@ -518,7 +518,7 @@
       <div class="mention-status small" id="update-reply-mention-status" aria-live="polite"></div>
       <div class="update-reply-actions">
         <button id="send-update-reply" type="button">Send reply</button>
-        <button id="send-update-reply-next" type="button" hidden>Reply &amp; next</button>
+        <button id="send-update-reply-read-next" type="button">Reply, mark read &amp; next</button>
       </div>
       <div id="update-reply-status" class="small" aria-live="assertive"></div>
     </section>
@@ -696,6 +696,7 @@
 <script src="static/today-completion.js"></script>
 <script src="static/today-readiness.js"></script>
 <script src="static/comment-next.js"></script>
+<script src="static/update-reply-read-next.js"></script>
 <script src="static/plan-today.js"></script>
 <script src="static/plan-today-preview.js"></script>
 <script src="static/today-sync.js"></script>

frontend/my-work.js

@@ -292,6 +292,22 @@ function createNotificationReader({
   let conversationPager = null;
   let offlineHydrated = false;
 
+  async function advanceAfterRead(items, current, queueing = false) {
+    const updated = acknowledgeNotification(items, current.notification_id);
+    onItems(updated);
+    const currentIndex = items.indexOf(current);
+    const remaining = items.slice(currentIndex + 1).concat(items.slice(0, currentIndex));
+    const next = remaining.find(item => item && item.has_update &&
+      Number.isInteger(item.notification_id) && (!queueing || loadSaved(item)));
+    if (next) await open(next, queueing ? loadSaved(next) : null);
+    else {
+      selected = null;
+      onClose();
+      onStatus('Inbox cleared.');
+    }
+    return { items: updated, next: next || null };
+  }
+
   async function open(item, savedDetail = null) {
     selected = item;
     offlineHydrated = Boolean(savedDetail && !Array.isArray(savedDetail));
@@ -327,6 +343,10 @@ function createNotificationReader({
       onConversation(conversationPager.append(comment));
       return true;
     },
+    acceptReadAndNext(items, item = selected) {
+      if (!item || selected !== item) return false;
+      return advanceAfterRead(items, item);
+    },
     async loadOlder() {
       if (!conversationPager || !selected || offlineHydrated) return false;
       const pager = conversationPager;
@@ -354,19 +374,7 @@ function createNotificationReader({
       try {
         if (queueing) await queueRead(current.notification_id);
         else await markRead(current.notification_id);
-        const updated = acknowledgeNotification(items, current.notification_id);
-        onItems(updated);
-        const currentIndex = items.indexOf(current);
-        const remaining = items.slice(currentIndex + 1).concat(items.slice(0, currentIndex));
-        const next = remaining.find(item => item && item.has_update &&
-          Number.isInteger(item.notification_id) && (!queueing || loadSaved(item)));
-        if (next) await open(next, queueing ? loadSaved(next) : null);
-        else {
-          selected = null;
-          onClose();
-          onStatus('Inbox cleared.');
-        }
-        return { items: updated, next: next || null };
+        return await advanceAfterRead(items, current, queueing);
       } catch (_error) {
         onStatus(queueing ? 'Could not queue update read. Retry.' : 'Could not mark update read. Retry.');
         return false;

frontend/service-worker.js

@@ -1,6 +1,6 @@
 const BASE = new URL('./', self.location.href).pathname;
 importScripts(BASE + 'static/background-issue-sync.js');
-const CACHE = 'stackchain-dashboard-shell-v83';
+const CACHE = 'stackchain-dashboard-shell-v84';
 const OFFLINE_LEASE_URL = new URL(BASE + '__offline-session-lease', self.location.origin).href;
 const OUTAGE_STATUSES = new Set([500, 502, 503, 504]);
 const NAVIGATION_TIMEOUT_MS = self.__STACKCHAIN_NAVIGATION_TIMEOUT_MS || 4000;
@@ -31,6 +31,7 @@ const SHELL = [
   BASE + 'static/today-completion.js',
   BASE + 'static/today-readiness.js',
   BASE + 'static/comment-next.js',
+  BASE + 'static/update-reply-read-next.js',
   BASE + 'static/plan-today.js',
   BASE + 'static/plan-today-preview.js',
   BASE + 'static/today-sync.js',

frontend/update-reply-read-next.js

@@ -0,0 +1,50 @@
+function createUpdateReplyReadNext({
+  post, markRead, queue, canQueue, accept = () => undefined, next = () => undefined,
+}) {
+  let inFlight = null;
+
+  async function admit(item, body, operationId, replyConfirmed) {
+    const admission = await queue({
+      kind: 'update-reply-read',
+      notificationId: item.notification_id,
+      body,
+      operationId,
+      replyConfirmed,
+    });
+    if (!admission || (!admission.item && admission.durable !== true)) {
+      throw new Error('Reply and acknowledgement were not saved for delivery.');
+    }
+    accept(item);
+    return {
+      accepted: true,
+      delivery: admission.background ? 'queued' : 'saved',
+      next: await next(item),
+    };
+  }
+
+  function submit(item, body, operationId) {
+    if (inFlight) return inFlight;
+    inFlight = (async () => {
+      let replyConfirmed = false;
+      try {
+        try {
+          await post(item, body, operationId);
+          replyConfirmed = true;
+          await markRead(item.notification_id);
+        } catch (error) {
+          if (!canQueue(error)) throw error;
+          return await admit(item, body, operationId, replyConfirmed);
+        }
+        accept(item);
+        return { accepted: true, delivery: 'posted', next: await next(item) };
+      } finally {
+        inFlight = null;
+      }
+    })();
+    return inFlight;
+  }
+
+  return { submit, busy: () => Boolean(inFlight) };
+}
+
+if (typeof module !== 'undefined' && module.exports) module.exports = createUpdateReplyReadNext;