feat: make mobile review loading retryable (#127)

src/gitea_proxy.py

@@ -1,3 +1,4 @@
+import asyncio
 import os
 import shlex
 from typing import Any
@@ -119,14 +120,15 @@ async def pull_requests() -> list[dict]:
 
 
 async def is_requested_review(repository: str, number: int) -> bool:
-    pulls = await pull_requests()
+    pulls = await fetch(
+        "repos/issues/search?state=open&review_requested=true&type=pulls&limit=50"
+    )
     return any(
         isinstance(pull, dict)
         and pull.get("number") == number
-        and "review_requested" in (pull.get("work_reasons") or [])
         and isinstance(pull.get("repository"), dict)
         and pull["repository"].get("full_name") == repository
-        for pull in pulls
+        for pull in (pulls or [])
     )
 
 
@@ -135,16 +137,19 @@ async def pull_review_detail(repository: str, number: int) -> dict:
     pull = await fetch(base)
     if not isinstance(pull, dict):
         raise ValueError("Gitea pull request response was not an object")
-    files = await fetch(f"{base}/files")
     head_value = pull.get("head")
     head: dict = head_value if isinstance(head_value, dict) else {}
     sha_value = head.get("sha")
     sha = sha_value if isinstance(sha_value, str) else ""
-    status = await fetch(f"repos/{repository}/commits/{sha}/status")
-    reviews = await fetch(f"{base}/reviews")
-    diff, diff_truncated = await fetch_text(
-        f"repos/{repository}/pulls/{number}.diff", REVIEW_DIFF_MAX_BYTES
+    files, status, reviews, diff_result = await asyncio.gather(
+        fetch(f"{base}/files"),
+        fetch(f"repos/{repository}/commits/{sha}/status"),
+        fetch(f"{base}/reviews"),
+        fetch_text(
+            f"repos/{repository}/pulls/{number}.diff", REVIEW_DIFF_MAX_BYTES
+        ),
     )
+    diff, diff_truncated = diff_result
     previews = _diff_previews(diff, diff_truncated)
     user_value = pull.get("user")
     user: dict = user_value if isinstance(user_value, dict) else {}

src/main.py

@@ -24,6 +24,7 @@ app = FastAPI(title="Stackchain Dashboard")
 CONTEXT_TIMEOUT_SECONDS = 5.0
 EVENT_STREAM_TIMEOUT_SECONDS = 5.0
 READINESS_TIMEOUT_SECONDS = 5.0
+REVIEW_DETAIL_TIMEOUT_SECONDS = 5.0
 FRONTEND_DIR = Path(__file__).resolve().parent.parent / "frontend"
 
 
@@ -262,19 +263,28 @@ async def event_stream():
 
 @app.get("/api/v1/repos/{owner}/{repo}/pulls/{number}/review")
 async def review_detail(owner: str, repo: str, number: int):
-    try:
+    async def load_requested_review():
         repository = f"{owner}/{repo}"
-        if not await asyncio.wait_for(
-            is_requested_review(repository, number),
-            timeout=CONTEXT_TIMEOUT_SECONDS,
-        ):
+        if not await is_requested_review(repository, number):
             raise HTTPException(status_code=404, detail="Review request not found")
+        return await pull_review_detail(repository, number)
+
+    try:
         return await asyncio.wait_for(
-            pull_review_detail(repository, number),
-            timeout=CONTEXT_TIMEOUT_SECONDS,
+            load_requested_review(), timeout=REVIEW_DETAIL_TIMEOUT_SECONDS
         )
     except HTTPException:
         raise
+    except TimeoutError:
+        return JSONResponse(
+            {"error": "Pull request review details timed out. Please retry."},
+            status_code=503,
+            headers={
+                "Retry-After": str(
+                    max(1, math.ceil(REVIEW_DETAIL_TIMEOUT_SECONDS))
+                )
+            },
+        )
     except Exception:
         return JSONResponse(
             {"error": "Pull request review details are temporarily unavailable"},