feat: make assigned pull sheets read-first (#217)

src/gitea_proxy.py

@@ -1222,18 +1222,9 @@ async def pull_completion_detail(repository: str, number: int) -> dict:
     pull = await fetch(base)
     if not isinstance(pull, dict):
         raise ValueError("Gitea pull request response was not an object")
+    conversation = await issue_conversation_page(repository, number)
     head = pull.get("head") if isinstance(pull.get("head"), dict) else {}
     sha = head.get("sha") if isinstance(head.get("sha"), str) else ""
-    files, status, conversation, diff_result = await asyncio.gather(
-        fetch(f"{base}/files"),
-        fetch(f"repos/{repository}/commits/{sha}/status"),
-        issue_conversation_page(repository, number),
-        fetch_text(
-            f"repos/{repository}/pulls/{number}.diff", REVIEW_DIFF_MAX_BYTES
-        ),
-    )
-    diff, diff_truncated = diff_result
-    previews = _diff_previews(diff, diff_truncated)
     user = pull.get("user") if isinstance(pull.get("user"), dict) else {}
     return {
         "repository": repository,
@@ -1244,6 +1235,33 @@ async def pull_completion_detail(repository: str, number: int) -> dict:
         "author": user.get("login") if isinstance(user.get("login"), str) else "",
         "head_sha": sha,
         "state": pull.get("state") if isinstance(pull.get("state"), str) else "",
+        "conversation": conversation,
+    }
+
+
+async def pull_completion_review(repository: str, number: int) -> dict:
+    base = f"repos/{repository}/pulls/{number}"
+    pull = await fetch(base)
+    if not isinstance(pull, dict):
+        raise ValueError("Gitea pull request response was not an object")
+    head_value = pull.get("head")
+    head: dict = head_value if isinstance(head_value, dict) else {}
+    sha_value = head.get("sha")
+    sha = sha_value if isinstance(sha_value, str) else ""
+    files, status, diff_result = await asyncio.gather(
+        fetch(f"{base}/files"),
+        fetch(f"repos/{repository}/commits/{sha}/status"),
+        fetch_text(
+            f"repos/{repository}/pulls/{number}.diff", REVIEW_DIFF_MAX_BYTES
+        ),
+    )
+    diff, diff_truncated = diff_result
+    previews = _diff_previews(diff, diff_truncated)
+    return {
+        "repository": repository,
+        "number": number,
+        "head_sha": sha,
+        "state": pull.get("state") if isinstance(pull.get("state"), str) else "",
         "draft": pull.get("draft") is True,
         "mergeable": pull.get("mergeable") is True,
         "merged": pull.get("merged") is True,
@@ -1267,8 +1285,6 @@ async def pull_completion_detail(repository: str, number: int) -> dict:
             for item in (files if isinstance(files, list) else [])[:100]
             if isinstance(item, dict) and isinstance(item.get("filename"), str)
         ],
-        "comments": conversation["comments"],
-        "conversation": conversation,
     }
 
 

src/main.py

@@ -1642,6 +1642,37 @@ async def assigned_pull_detail(owner: str, repo: str, number: int = PathParam(gt
         )
 
 
+@app.get("/api/v1/repos/{owner}/{repo}/pulls/{number}/review-data")
+async def assigned_pull_review_data(
+    owner: str, repo: str, number: int = PathParam(gt=0)
+):
+    repository = f"{owner}/{repo}"
+
+    async def load_assigned_pull_review():
+        if not await gitea_proxy.is_assigned_pull(repository, number):
+            raise HTTPException(status_code=404, detail="Assigned pull request not found")
+        return await gitea_proxy.pull_completion_review(repository, number)
+
+    try:
+        return await asyncio.wait_for(
+            load_assigned_pull_review(), timeout=REVIEW_DETAIL_TIMEOUT_SECONDS
+        )
+    except HTTPException:
+        raise
+    except TimeoutError:
+        return JSONResponse(
+            {"error": "Loading review and merge data timed out. Please retry."},
+            status_code=503,
+            headers={"Retry-After": "1"},
+        )
+    except Exception:
+        return JSONResponse(
+            {"error": "Review and merge data is temporarily unavailable. Please retry."},
+            status_code=503,
+            headers={"Retry-After": "1"},
+        )
+
+
 @app.get("/api/v1/repos/{owner}/{repo}/pulls/{number}/comments")
 async def assigned_pull_conversation(
     owner: str,