feat: capture photo evidence in conversation replies (Closes #941)

tests/test_comment_next.py

@@ -303,4 +303,4 @@ async def test_unread_update_offers_reply_mark_read_and_next_independent_of_toda
     assert '.update-reply-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
     assert '.update-reply-actions button { min-height:44px;' in html
     worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
-    assert "stackchain-dashboard-shell-v109" in worker
+    assert "stackchain-dashboard-shell-v110" in worker

tests/test_issue_attachment_ui.py

@@ -570,7 +570,7 @@ def test_new_issue_sheet_captures_screenshot_into_durable_outbox():
     assert "overflow-x:hidden" in css
 
 
-def test_mobile_new_issue_camera_and_library_append_to_one_photo_evidence_bundle():
+def test_mobile_new_issue_camera_and_library_render_as_one_photo_evidence_bundle():
     html = INDEX.read_text()
     source = DASHBOARD.read_text()
     css = CSS.read_text()
@@ -585,6 +585,30 @@ def test_mobile_new_issue_camera_and_library_append_to_one_photo_evidence_bundle
     assert "grid-template-columns:repeat(2,minmax(0,1fr))" in controls
     assert "min-width:0" in controls
 
+
+def test_mobile_conversation_composers_offer_camera_and_library_through_one_attachment_controller():
+    html = INDEX.read_text()
+    source = DASHBOARD.read_text()
+    css = CSS.read_text()
+
+    composers = (
+        ("take-issue-comment-photo", "issue-attachment", "issueAttachmentController"),
+        ("take-pull-comment-photo", "pull-attachment", "pullAttachmentController"),
+        ("take-update-reply-photo", "update-reply-attachment", "updateReplyAttachmentController"),
+    )
+    for camera_id, library_id, controller in composers:
+        assert f'id="{camera_id}" type="file" accept="image/*" capture="environment"' in html
+        assert f'for="{camera_id}">Take photo</label>' in html
+        assert f'for="{library_id}">Choose existing</label>' in html
+        mount = source.split(f"const {controller} = issueAttachment.mount({{", 1)[1].split("});", 1)[0]
+        assert f"inputs: [qs('#{camera_id}'), qs('#{library_id}')]" in mount
+
+    controls = css.split(".conversation-photo-actions", 1)[1].split("}", 1)[0]
+    assert "grid-template-columns:repeat(2,minmax(0,1fr))" in controls
+    assert "min-width:0" in controls
+    assert ".conversation-photo-actions .issue-attachment-trigger" in css
+    assert "width:100%" in css.split(".conversation-photo-actions .issue-attachment-trigger", 1)[1].split("}", 1)[0]
+
     script = f"""
 const attachment=require({json.dumps(str(ATTACHMENT))});
 class Element {{
@@ -593,7 +617,7 @@ class Element {{
   dispatch(type) {{ return this.listeners[type]({{target:this}}); }}
 }}
 const camera=new Element(),library=new Element(),preview=new Element(),image=new Element(),meta=new Element(),remove=new Element(),status=new Element();
-library.multiple=true;
+library.multiple=false;
 const controller=attachment.mount({{
   input:library,inputs:[camera,library],preview,image,meta,remove,status,
   optimizeImage:async file=>file,
@@ -612,9 +636,7 @@ const photo=name=>{{const blob=new Blob([name],{{type:'image/jpeg'}});blob.name=
     output = json.loads(run_node(script))
     assert output["afterCamera"]["name"] == "camera-one.jpg"
     assert output["afterCancel"] == output["afterCamera"]
-    assert [item["name"] for item in output["afterLibrary"]] == [
-        "camera-one.jpg", "library-two.jpg"
-    ]
+    assert output["afterLibrary"]["name"] == "library-two.jpg"
 
 
 def test_queued_screenshot_is_hydrated_before_the_issue_editor_opens_and_failure_is_retryable():

tests/test_later_sync.py

@@ -347,5 +347,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
 def test_later_sync_ships_atomically_in_the_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/later-sync.js'" in source

tests/test_markdown_renderer.py

@@ -256,4 +256,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
     assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
     assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
     assert ".markdown-content a { min-height:44px;" in css
-    assert "stackchain-dashboard-shell-v109" in worker
+    assert "stackchain-dashboard-shell-v110" in worker

tests/test_mobile_composer_integration.py

@@ -45,7 +45,7 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
     shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
 
     assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
-    assert "stackchain-dashboard-shell-v109" in worker
+    assert "stackchain-dashboard-shell-v110" in worker
 
 
 def test_all_conversation_composers_offer_accessible_mobile_mentions():

tests/test_mobile_device_setup.py

@@ -214,7 +214,7 @@ def test_mobile_dashboard_mounts_phone_safe_device_setup_flow():
     assert "promptStorage:localStorage" in dashboard
     assert "pushControllerReady.then(ensureDeviceSetup)" in dashboard
     assert "BASE + 'static/mobile-device-setup.js'" in worker
-    assert "stackchain-dashboard-shell-v109" in worker
+    assert "stackchain-dashboard-shell-v110" in worker
     assert ".device-setup-panel" in css
     assert ".device-readiness-card" in css
     assert "overflow-x:hidden" in css

tests/test_mobile_start_day.py

@@ -283,4 +283,4 @@ async def test_dashboard_wires_thumb_safe_start_day_briefing_into_offline_mobile
     assert ".mobile-start-day-finish { min-height:44px;" in html
     assert "max-width:100%; overflow-wrap:anywhere;" in html
     assert "BASE + 'static/mobile-start-day.js'" in service_worker
-    assert "stackchain-dashboard-shell-v109" in service_worker
+    assert "stackchain-dashboard-shell-v110" in service_worker

tests/test_plan_today.py

@@ -410,7 +410,7 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/plan-today.js'" in source
     assert "BASE + 'static/plan-today-readiness.js'" in source
     assert "BASE + 'static/plan-today-preview.js'" in source

tests/test_service_worker.py

@@ -155,7 +155,7 @@ async function dispatchPush(payload) {{
 def test_resumable_today_session_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/my-work.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
@@ -164,14 +164,14 @@ def test_resumable_today_session_ships_in_a_new_offline_shell():
 def test_ownership_exit_runtime_rolls_the_offline_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/dashboard.js'" in source
 
 
 def test_offline_review_next_ships_today_completion_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/today-completion.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -179,7 +179,7 @@ def test_offline_review_next_ships_today_completion_atomically():
 def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/create-issue-sheet.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -187,7 +187,7 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
 def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/issue-sheet.js'" in source
     assert "BASE + 'static/checklist-conflict.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
@@ -197,14 +197,14 @@ def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
 def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/later-picker.js'" in source
 
 
 def test_navigation_deadline_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/dashboard.css'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/install-app.js'" in source
@@ -213,21 +213,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
 def test_today_convergence_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/today-sync.js'" in source
 
 
 def test_mobile_search_viewport_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/mobile-search-viewport.js'" in source
 
 
 def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/update-ownership.js'" in source
 
 
@@ -893,7 +893,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
 def test_queue_today_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/queue-today.js'" in source
 
 

tests/test_today_readiness.py

@@ -221,7 +221,7 @@ async def test_today_blocker_opens_existing_preview_and_preserves_readiness_gate
 def test_readiness_runtime_is_available_in_offline_shell():
     service_worker = SERVICE_WORKER.read_text()
 
-    assert "const CACHE = 'stackchain-dashboard-shell-v109';" in service_worker
+    assert "const CACHE = 'stackchain-dashboard-shell-v110';" in service_worker
     assert "BASE + 'static/today-readiness.js'" in service_worker
 
 

tests/test_today_sync.py

@@ -127,7 +127,7 @@ sync.enqueueConfiguration(120, {{'issue:r:1:':60}});
 def test_inflight_today_drain_ships_in_a_new_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v109" in source
+    assert "stackchain-dashboard-shell-v110" in source
     assert "BASE + 'static/today-sync.js'" in source