Compact and rank pinned mobile work

tests/e2e/test_mobile_pinned_work_release.py

@@ -30,10 +30,6 @@ def test_operator_pins_and_reopens_frequent_work_without_phone_overflow(viewport
             getItem:key => values.get(key) || null,
             setItem:(key, value) => values.set(key, value),
           };
-          const item = {
-            kind:'issue', repository:'stackchain/stackchain-dashboard', number:1477,
-            title:'Pin frequent work across signed-in mobile devices',
-          };
           window.opened = [];
           window.recentWork = createMobileRecentWork({
             storage, getLogin:() => 'timmy', document,
@@ -41,32 +37,48 @@ def test_operator_pins_and_reopens_frequent_work_without_phone_overflow(viewport
             list:document.querySelector('#mobile-recent-work-list'),
             pinnedSection:document.querySelector('#mobile-pinned-work'),
             pinnedList:document.querySelector('#mobile-pinned-work-list'),
+            pinnedToggle:document.querySelector('#mobile-pinned-work-toggle'),
             status:document.querySelector('#mobile-recent-work-status'),
             openRoute:route => window.opened.push(route),
           });
-          window.recentWork.record(item);
-          window.recentWork.pin(item);
+          for (let number=1; number<=20; number += 1) {
+            const item = {
+              kind:'issue', repository:'stackchain/stackchain-dashboard', number,
+              title:'Pinned mobile work ' + number,
+            };
+            window.recentWork.record(item);
+            window.recentWork.pin(item);
+          }
           document.querySelector('#mobile-queue-sheet').showModal();
         }""")
 
         expect(page.locator("#mobile-pinned-work")).to_be_visible()
-        expect(page.locator("#mobile-recent-work")).to_be_visible()
+        expect(page.locator("#mobile-recent-work")).to_be_hidden()
+        expect(page.locator("#mobile-pinned-work-list .mobile-recent-work-row")).to_have_count(3)
         expect(page.locator("#mobile-recent-work-status")).to_have_text("Sync pending.")
+        toggle = page.locator("#mobile-pinned-work-toggle")
         open_button = page.get_by_role(
-            "button", name="Open Pin frequent work across signed-in mobile devices, issue stackchain/stackchain-dashboard #1477"
+            "button", name="Open Pinned mobile work 20, issue stackchain/stackchain-dashboard #20"
         ).first
         pin_button = page.get_by_role(
-            "button", name="Unpin Pin frequent work across signed-in mobile devices"
+            "button", name="Unpin Pinned mobile work 20"
         )
-        for control in (open_button, pin_button):
+        for control in (open_button, pin_button, toggle):
             bounds = control.bounding_box()
             assert bounds and bounds["height"] >= 44
             assert bounds["x"] >= 0 and bounds["x"] + bounds["width"] <= viewport["width"]
         assert page.evaluate("document.documentElement.scrollWidth <= window.innerWidth")
 
+        toggle.click()
+        expect(page.locator("#mobile-pinned-work-list .mobile-recent-work-row")).to_have_count(20)
+        expect(toggle).to_have_text("Show fewer")
+        assert toggle.get_attribute("aria-expanded") == "true"
+        toggle.click()
+        expect(page.locator("#mobile-pinned-work-list .mobile-recent-work-row")).to_have_count(3)
+
         open_button.focus()
         open_button.press("Enter")
         assert page.evaluate("window.opened") == [
-            "#/my-work/issue/stackchain/stackchain-dashboard/1477"
+            "#/my-work/issue/stackchain/stackchain-dashboard/20"
         ]
         browser.close()

tests/test_mobile_recent_work.py

@@ -306,7 +306,7 @@ const recent=createRecentWork({{
 const pinnedImmediately=recent.pin(item);
 recent.render();
 const immediate={{pinned:recent.pinned(),status:status.textContent,recentHidden:recentSection.hidden,pinnedHidden:pinnedSection.hidden,
-  recentActions:recentList.children[0].children.map(child=>child.attributes),
+  recentRows:recentList.children.length,
   pinnedActions:pinnedList.children[0].children.map(child=>child.attributes)}};
 await recent.sync();
 pinnedList.children[0].children[0].click();
@@ -320,16 +320,16 @@ process.stdout.write(JSON.stringify({{pinnedImmediately,immediate,opened,unpinne
     assert payload["pinnedImmediately"] is True
     assert payload["immediate"]["pinned"][0]["number"] == 1477
     assert payload["immediate"]["status"] == "Sync pending."
-    assert payload["immediate"]["recentHidden"] is False
+    assert payload["immediate"]["recentHidden"] is True
     assert payload["immediate"]["pinnedHidden"] is False
-    assert payload["immediate"]["recentActions"][0]["data-recent-work-route"].endswith("/1477")
-    assert payload["immediate"]["recentActions"][1]["data-recent-work-pin"] == "pin"
+    assert payload["immediate"]["recentRows"] == 0
     assert payload["immediate"]["pinnedActions"][1]["data-recent-work-pin"] == "unpin"
     assert payload["opened"] == ["#/my-work/issue/stackchain/dashboard/1477"]
     assert payload["unpinnedImmediately"] is True
     assert payload["settled"] == []
     assert payload["calls"] == [
         ["api/v1/recent-work/pin", "PUT", payload["immediate"]["pinned"][0]],
+        ["api/v1/recent-work", "POST", payload["immediate"]["pinned"][0]],
         [
             "api/v1/recent-work/pin",
             "DELETE",
@@ -338,6 +338,61 @@ process.stdout.write(JSON.stringify({{pinnedImmediately,immediate,opened,unpinne
     ]
 
 
+def test_pinned_work_is_compact_deduplicated_and_promotes_on_open():
+    script = f"""
+const createRecentWork = require({json.dumps(str(RECENT_WORK))});
+const makeItem=number=>({{kind:'issue',repository:'stackchain/dashboard',number,title:'Issue '+number}});
+const values=new Map([['stackchain.mobile-recent-work.v1.alice',JSON.stringify({{
+  items:[1,2,3,4,5].map(makeItem),pinned:[1,2,3,4,5].map(makeItem),pending:[],pinOps:[]
+}})]]);
+function node(tag) {{ return {{tag,children:[],attributes:{{}},listeners:{{}},hidden:false,textContent:'',
+  appendChild(child){{this.children.push(child);return child;}},
+  replaceChildren(...children){{this.children=children;}},
+  setAttribute(name,value){{this.attributes[name]=String(value);}},
+  addEventListener(name,callback){{this.listeners[name]=callback;}},
+  click(){{this.listeners.click?.();}}, focus(){{this.focused=true;}},
+}}; }}
+const recentList=node('div'), recentSection=node('section');
+const pinnedList=node('div'), pinnedSection=node('section'), pinnedToggle=node('button');
+const opened=[];
+const recent=createRecentWork({{
+  storage:{{getItem:key=>values.get(key)||null,setItem:(key,value)=>values.set(key,value)}},
+  getLogin:()=>'alice',document:{{createElement:node}},debounceMs:99999,
+  list:recentList,section:recentSection,pinnedList,pinnedSection,pinnedToggle,
+  openRoute:route=>opened.push(route),
+}});
+recent.render();
+const collapsed={{pinnedRows:pinnedList.children.length,recentRows:recentList.children.length,
+  recentHidden:recentSection.hidden,toggleHidden:pinnedToggle.hidden,toggleText:pinnedToggle.textContent,
+  expanded:pinnedToggle.attributes['aria-expanded'],controls:pinnedToggle.attributes['aria-controls']}};
+pinnedList.children[2].children[0].click();
+const promoted=recent.pinned().map(item=>item.number);
+pinnedToggle.click();
+const expanded={{pinnedRows:pinnedList.children.length,toggleText:pinnedToggle.textContent,
+  ariaExpanded:pinnedToggle.attributes['aria-expanded']}};
+process.stdout.write(JSON.stringify({{collapsed,promoted,expanded,opened,state:recent.state()}}));
+"""
+    payload = run_node(script)
+
+    assert payload["collapsed"] == {
+        "pinnedRows": 3,
+        "recentRows": 0,
+        "recentHidden": True,
+        "toggleHidden": False,
+        "toggleText": "Show all 5",
+        "expanded": "false",
+        "controls": "mobile-pinned-work-list",
+    }
+    assert payload["promoted"] == [3, 1, 2, 4, 5]
+    assert payload["expanded"] == {
+        "pinnedRows": 5,
+        "toggleText": "Show fewer",
+        "ariaExpanded": "true",
+    }
+    assert payload["opened"] == ["#/my-work/issue/stackchain/dashboard/3"]
+    assert payload["state"] == {"pending": True, "pendingCount": 1}
+
+
 def test_mobile_queues_integrates_recent_work_with_canonical_detail_routes():
     html = INDEX.read_text()
     dashboard = DASHBOARD.read_text()
@@ -347,6 +402,8 @@ def test_mobile_queues_integrates_recent_work_with_canonical_detail_routes():
     assert 'id="mobile-recent-work-list"' in html
     assert 'id="mobile-pinned-work"' in html
     assert 'id="mobile-pinned-work-list"' in html
+    assert 'id="mobile-pinned-work-toggle"' in html
+    assert 'aria-controls="mobile-pinned-work-list"' in html
     assert 'id="mobile-recent-work-status" role="status" aria-live="polite"' in html
     assert '<script src="static/mobile-recent-work.js"></script>' in html
     assert "createMobileRecentWork({" in dashboard
@@ -354,6 +411,7 @@ def test_mobile_queues_integrates_recent_work_with_canonical_detail_routes():
     assert "status:qs('#mobile-recent-work-status')" in dashboard
     assert "pinnedList:qs('#mobile-pinned-work-list')" in dashboard
     assert "pinnedSection:qs('#mobile-pinned-work')" in dashboard
+    assert "pinnedToggle:qs('#mobile-pinned-work-toggle')" in dashboard
     assert "mobileRecentWork.startLifecycle({window, document})" in dashboard
     assert "void mobileRecentWork.load();" in dashboard
     assert "mobileRecentWork.record(item)" in dashboard

tests/test_recent_work_store.py

@@ -60,6 +60,21 @@ def test_pinned_work_survives_recent_limit_and_unpin_keeps_recent_item(tmp_path)
     assert "#/my-work/issue" not in payload
 
 
+def test_reopening_pinned_work_promotes_it_for_every_device(tmp_path):
+    store = RecentWorkStore(
+        tmp_path / "recent-work.sqlite3",
+        encryption_key=b"r" * 32,
+    )
+    for number in range(1, 5):
+        store.pin("timmy", item(number))
+
+    reopened = store.record("timmy", item(1, title="Issue 1 current"))
+
+    assert [entry["number"] for entry in reopened["pinned"]] == [1, 4, 3, 2]
+    assert reopened["pinned"][0]["title"] == "Issue 1 current"
+    assert store.get("timmy")["pinned"] == reopened["pinned"]
+
+
 def test_recent_work_rejects_noncanonical_or_unsupported_items(tmp_path):
     store = RecentWorkStore(tmp_path / "recent-work.sqlite3", encryption_key=b"r" * 32)