feat: authorize consequential pull reviews (Closes #507)

frontend/authored-outbox.js

@@ -315,6 +315,11 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
         error: String(background.error || 'Message needs attention').slice(0, 240),
         ...(background.deliveryState ? { deliveryState: background.deliveryState } : {}),
       }];
+      if (background?.status === 'authorization') return [{
+        ...item,
+        status: 'authorization',
+        error: String(background.error || 'Fresh authorization required').slice(0, 240),
+      }];
       return [item];
     });
     write(items);

frontend/background-issue-sync.js

@@ -85,7 +85,8 @@ function createIssueSyncStore({
           incoming.set(current.id, replacement);
         }
         if ((current.status === 'sending' && Number(current.claimUntil) > Number(now())) ||
-            (current.status === 'attention' && replacement.status === 'attention') ||
+            (['attention', 'authorization'].includes(current.status) &&
+              replacement.status === current.status) ||
             current.status === 'sent') {
           incoming.set(current.id, current);
         }
@@ -153,7 +154,8 @@ function createIssueSyncStore({
     return transact(async records => {
       const current = (await records.getAll()).find(candidate => candidate.id === item.id);
       if (current && ((current.status === 'sending' && Number(current.claimUntil) > Number(now())) ||
-          (current.status === 'attention' && item.status === 'attention') ||
+          (['attention', 'authorization'].includes(current.status) &&
+            item.status === current.status) ||
           current.status === 'sent')) return current;
       const preservedAttachment = (current?.attachment?.data || current?.attachment?.blob) &&
         item?.attachment?.stored && !item.attachment.data && !item.attachment.blob
@@ -243,6 +245,9 @@ function createIssueSyncStore({
       status: 'attention', error,
       ...(deliveryState ? { deliveryState } : {}),
     })),
+    authorization: (id, claimToken, error) => updateClaim(
+      id, claimToken, item => clearClaim(item, { status: 'authorization', error })
+    ),
     snapshot: () => transact(async records =>
       (await records.getAll()).filter(item => item.recordType !== 'receipt-preference')),
     countBlocked: ownerLogin => transact(async records =>
@@ -271,6 +276,9 @@ function createBackgroundIssueSync({
   const failClaim = (item, error, deliveryState) => store.supportsClaimTokens
     ? store.fail(item.id, item.claimToken, error, deliveryState)
     : store.fail(item.id, error, deliveryState);
+  const requireAuthorization = (item, error) => store.supportsClaimTokens
+    ? store.authorization(item.id, item.claimToken, error)
+    : store.authorization(item.id, error);
   const checkpointClaim = (item, transform) => store.supportsClaimTokens
     ? store.checkpoint(item.id, item.claimToken, transform) : store.update?.(item.id, transform);
 
@@ -560,6 +568,15 @@ function createBackgroundIssueSync({
         await releaseClaim(item);
         throw error;
       }
+      if (status === 428 && item.kind === 'pull-review') {
+        const message = String(error?.message || 'Fresh authorization required').slice(0, 240);
+        await requireAuthorization(item, message);
+        return {
+          authorization: true,
+          error,
+          receipt: receiptFor(item, 'authorization'),
+        };
+      }
       if (status >= 400 && status < 500) {
         await failClaim(
           item,
@@ -590,11 +607,13 @@ function createBackgroundIssueSync({
     const confirmed = [];
     const receipts = [];
     let attention = 0;
-    if (!login) return { confirmed, blocked: 0, attention, login, receipts };
+    let authorization = 0;
+    if (!login) return { confirmed, blocked: 0, attention, authorization, login, receipts };
     const collect = result => {
       if (result.issue) confirmed.push(result.issue);
       if (result.message) confirmed.push(result.message);
       if (result.attention) attention += 1;
+      if (result.authorization) authorization += 1;
       if (result.receipt) receipts.push(result.receipt);
     };
     if (store.planBatch) {
@@ -655,7 +674,7 @@ function createBackgroundIssueSync({
       }
     }
     const blocked = store.countBlocked ? await store.countBlocked(login) : 0;
-    return { confirmed, blocked, attention, login, receipts };
+    return { confirmed, blocked, attention, authorization, login, receipts };
   }
 
   function flush() {

frontend/dashboard.js

@@ -1657,6 +1657,10 @@
         '<button class="draft-edit" data-draft-index="' + index + '" type="button">Edit</button>' +
         '<button class="draft-send" data-draft-index="' + index + '" type="button">' + sendLabel + '</button>' +
         '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard</button>' :
+        reviewOutbox && item.status === 'authorization' ?
+        '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open review</button>' +
+        '<button class="draft-authorize" data-draft-index="' + index + '" type="button">Authorize &amp; send review</button>' +
+        '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard queued review</button>' :
         reviewOutbox && item.status === 'attention' ?
         '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open current review</button>' +
         '<button class="draft-copy" data-draft-index="' + index + '" type="button">Copy feedback</button>' +
@@ -1778,11 +1782,17 @@
         const item = lastDrafts[Number(button.dataset.draftIndex)];
         if (!item?.outbox_id || !activeFlushLogin) return;
         button.disabled = true;
-        qs('#my-work-action-status').textContent = 'Fresh authorization required for this exact issue.';
+        const reviewAuthorization = item.outbox_kind === 'pull-review';
+        qs('#my-work-action-status').textContent = reviewAuthorization ?
+          'Fresh authorization required for this exact review decision and head.' :
+          'Fresh authorization required for this exact issue.';
         const result = await authoredOutbox.retry(item.outbox_id, activeFlushLogin);
         applyAuthoredOutboxResult(result);
         qs('#my-work-action-status').textContent = result.confirmed?.length ?
-          'Issue closed and queued intent cleared.' : 'Issue closure was not confirmed. The queued intent is still safe.';
+          (reviewAuthorization ? 'Review submitted and queued intent cleared.' :
+            'Issue closed and queued intent cleared.') :
+          (reviewAuthorization ? 'Review was not confirmed. The queued review and feedback are still safe.' :
+            'Issue closure was not confirmed. The queued intent is still safe.');
       });
     });
     list.querySelectorAll('.draft-copy').forEach(button => {

frontend/drafts.js

@@ -161,11 +161,12 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
             outbox_kind: item.kind,
             kind: 'authored-outbox',
             status: item.status === 'attention' ? 'attention' : (item.status === 'sending' ? 'sending' :
-              (isClosure ? 'authorization' : 'queued')),
+              (item.status === 'authorization' || isClosure ? 'authorization' : 'queued')),
             label: item.deliveryState === 'uncertain' ? 'Verify delivery' :
               (item.status === 'attention' ? (isClosure ? 'Issue closure needs attention' : 'Needs attention') :
-                (isReview ? 'Queued review' : (isClosure ? 'Awaiting authorization' : 'Queued message'))),
-            authorization_required: isClosure,
+                (isReview ? (item.status === 'authorization' ? 'Review awaiting authorization' : 'Queued review') :
+                  (isClosure ? 'Awaiting authorization' : 'Queued message'))),
+            authorization_required: isClosure || (isReview && item.status === 'authorization'),
             delivery_state: item.deliveryState,
             repository: isUpdate ? '' : item.repository,
             title: target,

frontend/service-worker.js

@@ -1,6 +1,6 @@
 const BASE = new URL('./', self.location.href).pathname;
 importScripts(BASE + 'static/background-issue-sync.js');
-const CACHE = 'stackchain-dashboard-shell-v84';
+const CACHE = 'stackchain-dashboard-shell-v85';
 const OFFLINE_LEASE_URL = new URL(BASE + '__offline-session-lease', self.location.origin).href;
 const OUTAGE_STATUSES = new Set([500, 502, 503, 504]);
 const NAVIGATION_TIMEOUT_MS = self.__STACKCHAIN_NAVIGATION_TIMEOUT_MS || 4000;
@@ -205,11 +205,13 @@ async function flushAndNotify() {
       !await issueSync.getReceiptPreference?.(result.login)) return;
   for (const receipt of result.receipts) {
     const needsAttention = receipt.status === 'attention';
-    const title = needsAttention
+    const needsAuthorization = receipt.status === 'authorization';
+    const title = needsAuthorization ? 'Queued review needs authorization' : needsAttention
       ? 'Queued work needs attention'
       : receipt.kind === 'issue' ? 'Queued issue created' : 'Queued message sent';
     await self.registration.showNotification(title, {
-      body: needsAttention ? 'Tap to review it in Drafts.' : 'Tap to open it in Stackchain.',
+      body: needsAuthorization ? 'Tap to authorize it in the Delivery center.' :
+        needsAttention ? 'Tap to review it in Drafts.' : 'Tap to open it in Stackchain.',
       tag: 'stackchain-delivery-' + receipt.id,
       data: { route: receipt.route },
     });