feat: comment and continue Today work (#429)

tests/test_comment_next.py

@@ -0,0 +1,212 @@
+import json
+import subprocess
+from pathlib import Path
+
+import pytest
+
+from tests.dashboard_bundle import dashboard
+
+
+COMMENT_NEXT = Path(__file__).parents[1] / "frontend" / "comment-next.js"
+MY_WORK = Path(__file__).parents[1] / "frontend" / "my-work.js"
+
+
+def run_node(script):
+    return subprocess.run(
+        ["node", "-e", script], check=True, capture_output=True, text=True
+    ).stdout
+
+
+def test_comment_and_next_posts_then_completes_current_today_item_once():
+    script = f"""
+const createCommentNext = require({json.dumps(str(COMMENT_NEXT))});
+const calls = [];
+let finishPost;
+const controller = createCommentNext({{
+  post: (item, body) => {{ calls.push(`post:${{item.number}}:${{body}}`); return new Promise(resolve => {{ finishPost = resolve; }}); }},
+  queue: () => {{ throw new Error('must not queue'); }},
+  canQueue: () => false,
+  complete: item => {{ calls.push(`complete:${{item.number}}`); return true; }},
+}});
+const item = {{kind:'issue', repository:'stackchain/dashboard', number:429}};
+const first = controller.submit(item, 'Handoff ready');
+const second = controller.submit(item, 'Handoff ready');
+if (first !== second) throw new Error('submission was not single-flight');
+finishPost({{id:7, body:'Handoff ready'}});
+(async () => {{
+  const result = await first;
+  process.stdout.write(JSON.stringify({{result, calls, busy:controller.busy()}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+
+    assert json.loads(run_node(script)) == {
+        "result": {
+            "accepted": True,
+            "delivery": "posted",
+            "comment": {"id": 7, "body": "Handoff ready"},
+            "completed": True,
+        },
+        "calls": ["post:429:Handoff ready", "complete:429"],
+        "busy": False,
+    }
+
+
+def test_comment_and_next_advances_after_durable_offline_admission():
+    script = f"""
+const createCommentNext = require({json.dumps(str(COMMENT_NEXT))});
+const calls = [];
+const retryable = new Error('offline'); retryable.status = 503;
+const controller = createCommentNext({{
+  post: () => Promise.reject(retryable),
+  canQueue: error => error.status === 503,
+  queue: message => {{ calls.push(message); return Promise.resolve({{durable:true, background:false}}); }},
+  complete: item => {{ calls.push(`complete:${{item.number}}`); return true; }},
+}});
+(async () => {{
+  const result = await controller.submit({{kind:'pull', repository:'stackchain/dashboard', number:12}}, 'Please review', 'op-12');
+  process.stdout.write(JSON.stringify({{result, calls}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+
+    assert json.loads(run_node(script)) == {
+        "result": {
+            "accepted": True,
+            "delivery": "saved",
+            "background": False,
+            "completed": True,
+        },
+        "calls": [
+            {
+                "kind": "pull-comment",
+                "repository": "stackchain/dashboard",
+                "number": 12,
+                "body": "Please review",
+                "operationId": "op-12",
+            },
+            "complete:12",
+        ],
+    }
+
+
+def test_comment_and_next_reads_retry_identity_after_the_failed_post():
+    script = f"""
+const createCommentNext = require({json.dumps(str(COMMENT_NEXT))});
+let operationId = '';
+let queued;
+const controller = createCommentNext({{
+  post: () => {{ operationId = 'post-attempt-id'; return Promise.reject(Object.assign(new Error('timeout'), {{status:503}})); }},
+  canQueue: () => true,
+  queue: message => {{ queued = message; return Promise.resolve({{durable:true}}); }},
+  complete: () => true,
+}});
+(async () => {{
+  const result = await controller.submit(
+    {{kind:'issue', repository:'r', number:3}}, 'Status', () => operationId
+  );
+  process.stdout.write(JSON.stringify({{result, queued}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+
+    output = json.loads(run_node(script))
+    assert output["result"]["accepted"] is True
+    assert output["result"]["delivery"] == "saved"
+    assert output["queued"]["operationId"] == "post-attempt-id"
+
+
+def test_comment_and_next_clears_the_completed_draft_before_opening_next_item():
+    script = f"""
+const createCommentNext = require({json.dumps(str(COMMENT_NEXT))});
+const calls = [];
+const controller = createCommentNext({{
+  post: () => Promise.resolve({{id:1}}), queue: () => null, canQueue: () => false,
+  accept: item => calls.push(`clear:${{item.number}}`),
+  complete: item => {{ calls.push(`complete:${{item.number}}`); return true; }},
+}});
+(async () => {{
+  await controller.submit({{kind:'issue',repository:'r',number:8}}, 'Done');
+  process.stdout.write(JSON.stringify(calls));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+
+    assert json.loads(run_node(script)) == ["clear:8", "complete:8"]
+
+
+def test_comment_and_next_keeps_today_position_when_delivery_or_completion_fails():
+    script = f"""
+const createCommentNext = require({json.dumps(str(COMMENT_NEXT))});
+const failures = [];
+const permanent = createCommentNext({{
+  post: () => Promise.reject(Object.assign(new Error('forbidden'), {{status:403}})),
+  canQueue: () => false,
+  queue: () => Promise.resolve({{durable:true}}),
+  complete: () => {{ failures.push('advanced'); return true; }},
+}});
+const notDurable = createCommentNext({{
+  post: () => Promise.reject(Object.assign(new Error('offline'), {{status:503}})),
+  canQueue: () => true,
+  queue: () => Promise.resolve({{durable:false, background:false}}),
+  complete: () => {{ failures.push('advanced'); return true; }},
+}});
+const cannotComplete = createCommentNext({{
+  post: () => Promise.resolve({{id:9}}), canQueue: () => false, queue: () => null,
+  complete: () => false,
+}});
+(async () => {{
+  for (const [name, controller] of [['permanent', permanent], ['notDurable', notDurable]]) {{
+    try {{ await controller.submit({{kind:'issue',repository:'r',number:1}}, 'draft'); }}
+    catch (error) {{ failures.push(`${{name}}:${{error.message}}`); }}
+  }}
+  const partial = await cannotComplete.submit({{kind:'issue',repository:'r',number:1}}, 'draft');
+  process.stdout.write(JSON.stringify({{failures, partial}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+
+    assert json.loads(run_node(script)) == {
+        "failures": ["permanent:forbidden", "notDurable:Comment was not saved for delivery."],
+        "partial": {
+            "accepted": True,
+            "delivery": "posted",
+            "comment": {"id": 9},
+            "completed": False,
+        },
+    }
+
+
+def test_today_checkpoint_only_matches_the_current_session_item():
+    script = f"""
+const buildMyWork = require({json.dumps(str(MY_WORK))});
+const items = [
+  {{kind:'issue', repository:'r', number:1}},
+  {{kind:'pull', repository:'r', number:2}},
+];
+const session = buildMyWork.createWorkSession({{
+  getItems: () => items, getFilter: () => 'all', checkpointEnabled: () => true,
+  checkpoint: {{save:()=>undefined, clear:()=>undefined, read:()=>null}},
+  onOpen:()=>undefined, onProgress:()=>undefined, onFinish:()=>undefined,
+}});
+session.start();
+process.stdout.write(JSON.stringify({{
+  current: session.checkpointed(items[0]),
+  other: session.checkpointed(items[1]),
+  generic: session.checkpointed(),
+}}));
+"""
+
+    assert json.loads(run_node(script)) == {
+        "current": True,
+        "other": False,
+        "generic": True,
+    }
+
+
+@pytest.mark.anyio
+async def test_mobile_composers_offer_comment_and_next_only_for_today_checkpoint():
+    html = await dashboard()
+
+    assert 'id="send-issue-comment-next"' in html
+    assert 'id="send-pull-comment-next"' in html
+    assert html.count('>Comment &amp; next</button>') == 2
+    assert "setCommentNextVisibility('issue')" in html
+    assert "setCommentNextVisibility('pull')" in html
+    assert '.comment-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
+    assert '.comment-actions button { min-height:44px;' in html

tests/test_later_sync.py

@@ -347,5 +347,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
 def test_later_sync_ships_atomically_in_the_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/later-sync.js'" in source

tests/test_markdown_renderer.py

@@ -137,4 +137,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
     assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
     assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
     assert ".markdown-content a { min-height:44px;" in css
-    assert "stackchain-dashboard-shell-v71" in worker
+    assert "stackchain-dashboard-shell-v72" in worker

tests/test_mobile_composer_integration.py

@@ -35,4 +35,4 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
     shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
 
     assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
-    assert "stackchain-dashboard-shell-v71" in worker
+    assert "stackchain-dashboard-shell-v72" in worker

tests/test_plan_today.py

@@ -168,6 +168,6 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/plan-today.js'" in source
     assert "BASE + 'static/plan-today-preview.js'" in source

tests/test_service_worker.py

@@ -122,7 +122,7 @@ async function dispatchNotificationClick(route) {{
 def test_resumable_today_session_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/my-work.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
@@ -131,7 +131,7 @@ def test_resumable_today_session_ships_in_a_new_offline_shell():
 def test_offline_review_next_ships_today_completion_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/today-completion.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -139,7 +139,7 @@ def test_offline_review_next_ships_today_completion_atomically():
 def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/create-issue-sheet.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -147,14 +147,14 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
 def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/later-picker.js'" in source
 
 
 def test_navigation_deadline_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/dashboard.css'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/install-app.js'" in source
@@ -163,21 +163,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
 def test_today_convergence_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/today-sync.js'" in source
 
 
 def test_mobile_search_viewport_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/mobile-search-viewport.js'" in source
 
 
 def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/update-ownership.js'" in source
 
 
@@ -358,7 +358,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
 def test_queue_today_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/queue-today.js'" in source
 
 
@@ -397,6 +397,7 @@ def test_install_precaches_complete_subpath_scoped_app_shell():
         "/dashboard/static/card-planning.js",
         "/dashboard/static/today-work.js",
         "/dashboard/static/today-completion.js",
+        "/dashboard/static/comment-next.js",
         "/dashboard/static/plan-today.js",
         "/dashboard/static/plan-today-preview.js",
         "/dashboard/static/today-sync.js",

tests/test_today_sync.py

@@ -86,7 +86,7 @@ sync.enqueue('add', 'issue:r:1:');
 def test_inflight_today_drain_ships_in_a_new_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v71" in source
+    assert "stackchain-dashboard-shell-v72" in source
     assert "BASE + 'static/today-sync.js'" in source