feat: resume recap feedback after interruptions (Closes #585)

tests/test_comment_next.py

@@ -303,4 +303,4 @@ async def test_unread_update_offers_reply_mark_read_and_next_independent_of_toda
     assert '.update-reply-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
     assert '.update-reply-actions button { min-height:44px;' in html
     worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
-    assert "stackchain-dashboard-shell-v88" in worker
+    assert "stackchain-dashboard-shell-v89" in worker

tests/test_frontend_bundle.py

@@ -162,7 +162,7 @@ def test_legacy_cache_marker_is_normalized_out_of_build_identity(tmp_path):
     worker = changed_frontend / "service-worker.js"
     worker.write_text(
         worker.read_text().replace(
-            "const CACHE = 'stackchain-dashboard-shell-v88';",
+            "const CACHE = 'stackchain-dashboard-shell-v89';",
             "const CACHE = 'stackchain-dashboard-shell-v999';",
         )
     )

tests/test_later_sync.py

@@ -347,5 +347,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
 def test_later_sync_ships_atomically_in_the_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/later-sync.js'" in source

tests/test_markdown_renderer.py

@@ -137,4 +137,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
     assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
     assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
     assert ".markdown-content a { min-height:44px;" in css
-    assert "stackchain-dashboard-shell-v88" in worker
+    assert "stackchain-dashboard-shell-v89" in worker

tests/test_mobile_composer_integration.py

@@ -41,7 +41,7 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
     shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
 
     assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
-    assert "stackchain-dashboard-shell-v88" in worker
+    assert "stackchain-dashboard-shell-v89" in worker
 
 
 def test_all_conversation_composers_offer_accessible_mobile_mentions():

tests/test_mobile_device_setup.py

@@ -186,7 +186,7 @@ def test_mobile_dashboard_mounts_phone_safe_device_setup_flow():
     assert "promptStorage:localStorage" in dashboard
     assert "pushControllerReady.then(ensureDeviceSetup)" in dashboard
     assert "BASE + 'static/mobile-device-setup.js'" in worker
-    assert "stackchain-dashboard-shell-v88" in worker
+    assert "stackchain-dashboard-shell-v89" in worker
     assert ".device-setup-panel" in css
     assert ".device-readiness-card" in css
     assert "overflow-x:hidden" in css

tests/test_plan_today.py

@@ -332,6 +332,6 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/plan-today.js'" in source
     assert "BASE + 'static/plan-today-preview.js'" in source

tests/test_service_worker.py

@@ -135,7 +135,7 @@ async function dispatchPush(payload) {{
 def test_resumable_today_session_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/my-work.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
@@ -144,14 +144,14 @@ def test_resumable_today_session_ships_in_a_new_offline_shell():
 def test_ownership_exit_runtime_rolls_the_offline_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/dashboard.js'" in source
 
 
 def test_offline_review_next_ships_today_completion_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/today-completion.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -159,7 +159,7 @@ def test_offline_review_next_ships_today_completion_atomically():
 def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/create-issue-sheet.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -167,14 +167,14 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
 def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/later-picker.js'" in source
 
 
 def test_navigation_deadline_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/dashboard.css'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/install-app.js'" in source
@@ -183,21 +183,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
 def test_today_convergence_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/today-sync.js'" in source
 
 
 def test_mobile_search_viewport_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/mobile-search-viewport.js'" in source
 
 
 def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/update-ownership.js'" in source
 
 
@@ -638,7 +638,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
 def test_queue_today_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/queue-today.js'" in source
 
 

tests/test_today_readiness.py

@@ -221,7 +221,7 @@ async def test_today_blocker_opens_existing_preview_and_preserves_readiness_gate
 def test_readiness_runtime_is_available_in_offline_shell():
     service_worker = SERVICE_WORKER.read_text()
 
-    assert "const CACHE = 'stackchain-dashboard-shell-v88';" in service_worker
+    assert "const CACHE = 'stackchain-dashboard-shell-v89';" in service_worker
     assert "BASE + 'static/today-readiness.js'" in service_worker
 
 

tests/test_today_recap.py

@@ -306,6 +306,61 @@ recap.begin([
     assert output["after"] is None
 
 
+def test_recap_controller_restores_account_scoped_pending_replan_until_completed():
+    script = f"""
+const createRecap = require({json.dumps(str(TODAY_RECAP))});
+const values=new Map();
+const storage={{getItem:key=>values.get(key)||null,setItem:(key,value)=>values.set(key,value),removeItem:key=>values.delete(key)}};
+let login='timmy';
+const options={{save:payload=>Promise.resolve({{session_id:payload.session_id}}),clear:()=>{{}},storage,getLogin:()=>login}};
+const first=createRecap({{...options,makeId:()=> 'saved-session'}});
+first.begin([{{identity:'issue:r:1:',elapsed_ms:52*60000}}], {{'issue:r:1:':30}});
+(async()=>{{
+  await first.saveForReplan();
+  const afterSave=first.pendingReplan();
+  const restored=createRecap(options).pendingReplan();
+  login='alexander';
+  const otherAccount=createRecap(options).pendingReplan();
+  login='timmy';
+  const retainedAfterCancel=createRecap(options).pendingReplan();
+  createRecap(options).completeReplan();
+  const afterComplete=createRecap(options).pendingReplan();
+  process.stdout.write(JSON.stringify({{afterSave,restored,otherAccount,retainedAfterCancel,afterComplete,keys:[...values.keys()]}}));
+}})().catch(error=>{{console.error(error);process.exit(1);}});
+"""
+    run = subprocess.run(["node", "-e", script], capture_output=True, text=True)
+    assert run.returncode == 0, run.stderr
+    output = json.loads(run.stdout)
+    pending = {
+        "session_id": "saved-session",
+        "actual_minutes": {"issue:r:1:": 52},
+    }
+    assert output == {
+        "afterSave": pending,
+        "restored": pending,
+        "otherAccount": None,
+        "retainedAfterCancel": pending,
+        "afterComplete": None,
+        "keys": [],
+    }
+
+
+def test_recap_controller_removes_malformed_or_unbounded_pending_replan():
+    script = f"""
+const createRecap = require({json.dumps(str(TODAY_RECAP))});
+const key='stackchain.today-recap-handoff.v1.timmy';
+const values=new Map([[key, JSON.stringify({{session_id:'saved',actual_minutes:Object.fromEntries(
+  Array.from({{length:21}}, (_,index)=>['issue:r:' + index + ':', 10])
+)}})]]);
+const storage={{getItem:key=>values.get(key)||null,setItem:(key,value)=>values.set(key,value),removeItem:key=>values.delete(key)}};
+const recap=createRecap({{save:()=>Promise.resolve(),clear:()=>{{}},storage,getLogin:()=> 'timmy'}});
+process.stdout.write(JSON.stringify({{pending:recap.pendingReplan(),hasKey:values.has(key)}}));
+"""
+    run = subprocess.run(["node", "-e", script], capture_output=True, text=True)
+    assert run.returncode == 0, run.stderr
+    assert json.loads(run.stdout) == {"pending": None, "hasKey": False}
+
+
 @pytest.mark.anyio
 async def test_dashboard_renders_mobile_today_recap_flow():
     html = main.FRONTEND_BUILD.dashboard_html
@@ -335,3 +390,19 @@ async def test_dashboard_renders_mobile_today_recap_flow():
     assert "identity => [...todayMyWork, ...activeMyWork].find" in dashboard
     assert "openPlanToday(qs('#plan-today'), true, actualMinutes)" in dashboard
     assert ".today-recap-row { grid-template-columns:1fr; }" in css
+
+
+@pytest.mark.anyio
+async def test_dashboard_resumes_and_explicitly_discards_pending_recap_feedback():
+    html = main.FRONTEND_BUILD.dashboard_html
+    dashboard = (ROOT / "frontend" / "dashboard.js").read_text()
+    recap_source = TODAY_RECAP.read_text()
+
+    assert 'id="discard-recap-replan"' in html
+    assert "todayRecapView.pendingReplan()?.actual_minutes" in dashboard
+    assert "todayRecapView.completeReplan();" in dashboard
+    assert "todayRecapView.discardReplan();" in dashboard
+    assert "if (capacityAware && !todayWork.replacePlanning(plan)) return false;" in dashboard
+    assert dashboard.index("todayWork.replacePlanning(plan)") < dashboard.index("todayRecapView.completeReplan();")
+    assert "pendingReplan:recap.pendingReplan" in recap_source
+    assert "discardReplan:recap.discardReplan" in recap_source

tests/test_today_sync.py

@@ -127,7 +127,7 @@ sync.enqueueConfiguration(120, {{'issue:r:1:':60}});
 def test_inflight_today_drain_ships_in_a_new_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v88" in source
+    assert "stackchain-dashboard-shell-v89" in source
     assert "BASE + 'static/today-sync.js'" in source