feat: preserve Search photo reply drafts (Closes #957)

tests/test_comment_next.py

@@ -303,4 +303,4 @@ async def test_unread_update_offers_reply_mark_read_and_next_independent_of_toda
     assert '.update-reply-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
     assert '.update-reply-actions button { min-height:44px;' in html
     worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
-    assert "stackchain-dashboard-shell-v112" in worker
+    assert "stackchain-dashboard-shell-v113" in worker

tests/test_dashboard_session_frontend.py

@@ -350,6 +350,7 @@ process.stdout.write(JSON.stringify(state));
     assert result["deletedDatabases"] == [
         "stackchain-background-outbox-v1", "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1", "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["remaining"] == ["gitea.preference"]
     assert result["replaced"] == [
@@ -376,6 +377,7 @@ process.stdout.write(JSON.stringify(state));
     assert result["deletedDatabases"] == [
         "stackchain-background-outbox-v1", "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1", "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["deletedCaches"] == ["stackchain-dashboard-shell-v15"]
     assert result["replaced"] == ["/dashboard/login?reason=session-expired"]
@@ -507,6 +509,7 @@ process.stdout.write(JSON.stringify(state));
     assert result["deletedDatabases"] == [
         "stackchain-background-outbox-v1", "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1", "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["deletedCaches"] == ["stackchain-dashboard-shell-v15"]
     assert result["workerMessages"] == [{"type": "stackchain-purge-outbox"}]
@@ -530,6 +533,7 @@ process.stdout.write(JSON.stringify(state));
     assert result["deletedDatabases"] == [
         "stackchain-background-outbox-v1", "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1", "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["deletedCaches"] == ["stackchain-dashboard-shell-v15"]
     assert result["workerMessages"] == [{"type": "stackchain-purge-outbox"}]
@@ -626,6 +630,7 @@ process.stdout.write(JSON.stringify(state));
     assert result["deletedDatabases"] == [
         "stackchain-background-outbox-v1", "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1", "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["deletedCaches"] == ["stackchain-dashboard-shell-v15"]
     assert result["assigned"] == "/dashboard/login"

tests/test_later_sync.py

@@ -347,5 +347,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
 def test_later_sync_ships_atomically_in_the_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/later-sync.js'" in source

tests/test_markdown_renderer.py

@@ -256,4 +256,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
     assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
     assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
     assert ".markdown-content a { min-height:44px;" in css
-    assert "stackchain-dashboard-shell-v112" in worker
+    assert "stackchain-dashboard-shell-v113" in worker

tests/test_mobile_composer_integration.py

@@ -45,7 +45,7 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
     shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
 
     assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
-    assert "stackchain-dashboard-shell-v112" in worker
+    assert "stackchain-dashboard-shell-v113" in worker
 
 
 def test_all_conversation_composers_offer_accessible_mobile_mentions():

tests/test_mobile_device_setup.py

@@ -214,7 +214,7 @@ def test_mobile_dashboard_mounts_phone_safe_device_setup_flow():
     assert "promptStorage:localStorage" in dashboard
     assert "pushControllerReady.then(ensureDeviceSetup)" in dashboard
     assert "BASE + 'static/mobile-device-setup.js'" in worker
-    assert "stackchain-dashboard-shell-v112" in worker
+    assert "stackchain-dashboard-shell-v113" in worker
     assert ".device-setup-panel" in css
     assert ".device-readiness-card" in css
     assert "overflow-x:hidden" in css

tests/test_mobile_start_day.py

@@ -283,4 +283,4 @@ async def test_dashboard_wires_thumb_safe_start_day_briefing_into_offline_mobile
     assert ".mobile-start-day-finish { min-height:44px;" in html
     assert "max-width:100%; overflow-wrap:anywhere;" in html
     assert "BASE + 'static/mobile-start-day.js'" in service_worker
-    assert "stackchain-dashboard-shell-v112" in service_worker
+    assert "stackchain-dashboard-shell-v113" in service_worker

tests/test_plan_today.py

@@ -410,7 +410,7 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/plan-today.js'" in source
     assert "BASE + 'static/plan-today-readiness.js'" in source
     assert "BASE + 'static/plan-today-preview.js'" in source

tests/test_private_data_registry.py

@@ -31,6 +31,7 @@ process.stdout.write(JSON.stringify(databases));
         "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1",
         "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     }
 
 

tests/test_private_device_data.py

@@ -48,6 +48,7 @@ const clear = createPrivateDeviceDataPurger({{
         "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1",
         "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert state["caches"] == ["stackchain-dashboard-shell-v37"]
     assert state["workerMessages"] == [{"type": "stackchain-purge-outbox"}]

tests/test_search_reply_draft_store.py

@@ -0,0 +1,118 @@
+import json
+import subprocess
+from pathlib import Path
+
+
+ROOT = Path(__file__).resolve().parents[1]
+STORE = ROOT / "frontend" / "search-reply-draft-store.js"
+ATTACHMENT = ROOT / "frontend" / "issue-attachment.js"
+INDEX = ROOT / "frontend" / "index.html"
+DASHBOARD = ROOT / "frontend" / "dashboard.js"
+REGISTRY = ROOT / "frontend" / "private-data-registry.js"
+WORKER = ROOT / "frontend" / "service-worker.js"
+
+
+def run_node(script: str) -> str:
+    return subprocess.run(
+        ["node", "-e", script], check=True, capture_output=True, text=True
+    ).stdout
+
+
+def test_search_reply_photo_drafts_restore_only_for_the_confirmed_account_and_exact_result():
+    script = f"""
+const createStore = require({json.dumps(str(STORE))});
+const records = new Map();
+let login = 'timmy';
+const transaction = async (operation, key, value) => {{
+  if (operation === 'put') records.set(key, structuredClone(value));
+  if (operation === 'get') return records.has(key) ? structuredClone(records.get(key)) : null;
+  if (operation === 'delete') records.delete(key);
+}};
+const store = createStore({{transaction, getOwnerLogin:()=>login}});
+const target = {{kind:'issue', repository:'stackchain/dashboard', number:957}};
+const other = {{kind:'issue', repository:'stackchain/dashboard', number:958}};
+const photo = new Blob(['field-evidence'], {{type:'image/webp'}});
+(async()=>{{
+  await store.save(target, [{{
+    filename:'camera.webp', contentType:'image/webp', blob:photo,
+    note:'rack label', operationId:'upload-stable-1',
+    confirmed:{{markdown:'![camera](confirmed-url)'}},
+  }}]);
+  const restored = await store.load(target);
+  const wrongTarget = await store.load(other);
+  login = 'alexander';
+  const wrongAccount = await store.load(target);
+  process.stdout.write(JSON.stringify({{
+    restored:{{...restored[0], blobText:await restored[0].blob.text(), blob:undefined}},
+    wrongTarget, wrongAccount, recordCount:records.size,
+  }}));
+}})().catch(error=>{{console.error(error);process.exit(1);}});
+"""
+    output = json.loads(run_node(script))
+
+    assert output == {
+        "restored": {
+            "filename": "camera.webp",
+            "contentType": "image/webp",
+            "note": "rack label",
+            "operationId": "upload-stable-1",
+            "confirmed": {"markdown": "![camera](confirmed-url)"},
+            "blobText": "field-evidence",
+        },
+        "wrongTarget": None,
+        "wrongAccount": None,
+        "recordCount": 1,
+    }
+
+
+def test_photo_bundle_checkpoint_restores_stable_uploads_without_repeating_them():
+    script = f"""
+const attachment = require({json.dumps(str(ATTACHMENT))});
+const photo = new Blob(['proof'], {{type:'image/png'}}); photo.name = 'proof.png';
+const uploads = [];
+const first = attachment.create({{
+  createOperationId:()=> 'stable-upload-957',
+  upload:async payload=>{{uploads.push(payload.operation_id);return {{markdown:'![proof](saved-url)'}};}},
+}});
+first.select(photo);
+(async()=>{{
+  await first.prepareComment({{repository:'stackchain/dashboard',number:957}}, 'Ready');
+  const checkpoint = await first.serialize();
+  const restored = attachment.create({{
+    createOperationId:()=> 'must-not-replace-operation',
+    upload:async payload=>{{uploads.push(payload.operation_id);throw new Error('must not upload twice');}},
+  }});
+  restored.restore(checkpoint);
+  const comment = await restored.prepareComment({{repository:'stackchain/dashboard',number:957}}, 'Ready');
+  process.stdout.write(JSON.stringify({{checkpoint:{{...checkpoint,blob:undefined}},comment,uploads}}));
+}})().catch(error=>{{console.error(error);process.exit(1);}});
+"""
+    output = json.loads(run_node(script))
+
+    assert output == {
+        "checkpoint": {
+            "filename": "proof.png",
+            "contentType": "image/png",
+            "operationId": "stable-upload-957",
+            "confirmed": {"markdown": "![proof](saved-url)"},
+        },
+        "comment": "Ready\n\n![proof](saved-url)",
+        "uploads": ["stable-upload-957"],
+    }
+
+
+def test_dashboard_checkpoints_restores_and_clears_search_photo_drafts_at_user_boundaries():
+    html = INDEX.read_text()
+    dashboard = DASHBOARD.read_text()
+    registry = REGISTRY.read_text()
+    worker = WORKER.read_text()
+
+    assert '<script src="static/search-reply-draft-store.js"></script>' in html
+    assert html.index('static/search-reply-draft-store.js') < html.index('static/dashboard.js')
+    assert "'stackchain-search-reply-drafts-v1'" in registry
+    assert "BASE + 'static/search-reply-draft-store.js'" in worker
+    assert "createSearchReplyDraftStore({" in dashboard
+    assert "getOwnerLogin:() => confirmedOwnerLogin" in dashboard
+    assert "onCheckpoint:() => persistSearchReplyPhotos()" in dashboard
+    assert "searchReplyDraftStore.load(target)" in dashboard
+    assert "searchReplyDraftStore.remove(item)" in dashboard

tests/test_service_worker.py

@@ -155,7 +155,7 @@ async function dispatchPush(payload) {{
 def test_resumable_today_session_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/my-work.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
@@ -164,7 +164,7 @@ def test_resumable_today_session_ships_in_a_new_offline_shell():
 def test_mobile_conversation_photo_bundles_roll_the_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/authored-outbox.js'" in source
     assert "BASE + 'static/background-issue-sync.js'" in source
@@ -173,7 +173,7 @@ def test_mobile_conversation_photo_bundles_roll_the_offline_shell():
 def test_photo_metadata_sanitizer_rolls_the_cached_optimizer_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/issue-evidence-review.js'" in source
     assert "BASE + 'static/issue-attachment.js'" in source
 
@@ -181,14 +181,14 @@ def test_photo_metadata_sanitizer_rolls_the_cached_optimizer_atomically():
 def test_ownership_exit_runtime_rolls_the_offline_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/dashboard.js'" in source
 
 
 def test_offline_review_next_ships_today_completion_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/today-completion.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -196,7 +196,7 @@ def test_offline_review_next_ships_today_completion_atomically():
 def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/create-issue-sheet.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -204,7 +204,7 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
 def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/issue-sheet.js'" in source
     assert "BASE + 'static/checklist-conflict.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
@@ -214,14 +214,14 @@ def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
 def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/later-picker.js'" in source
 
 
 def test_navigation_deadline_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/dashboard.css'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/install-app.js'" in source
@@ -230,21 +230,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
 def test_today_convergence_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/today-sync.js'" in source
 
 
 def test_mobile_search_viewport_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/mobile-search-viewport.js'" in source
 
 
 def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/update-ownership.js'" in source
 
 
@@ -430,6 +430,7 @@ def test_revoked_background_session_purges_worker_data_and_notifies_dashboard_cl
         "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1",
         "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["state"]["deleted"] == ["stackchain-dashboard-old"]
     assert result["state"]["clientMessages"] == [
@@ -523,6 +524,7 @@ def test_device_purge_message_stops_worker_outbox_and_acknowledges_completion():
         "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1",
         "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["replies"] == [{"ok": True}]
 
@@ -910,7 +912,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
 def test_queue_today_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/queue-today.js'" in source
 
 
@@ -939,6 +941,7 @@ def test_install_precaches_complete_subpath_scoped_app_shell():
         "/dashboard/static/commands.js",
         "/dashboard/static/saved-searches.js",
         "/dashboard/static/search-preview.js",
+        "/dashboard/static/search-reply-draft-store.js",
         "/dashboard/static/search-defer.js",
         "/dashboard/static/widgets.js",
         "/dashboard/static/drafts.js",
@@ -1126,6 +1129,7 @@ def test_expired_offline_lease_purges_private_worker_data_and_refuses_cached_she
         "stackchain-offline-work-v2",
         "stackchain-unfiled-captures-v1",
         "stackchain-voice-transcripts-v1",
+        "stackchain-search-reply-drafts-v1",
     ]
     assert result["state"]["deleted"] == ["stackchain-dashboard-old"]
     assert "private cached dashboard" not in result["body"]

tests/test_today_readiness.py

@@ -221,7 +221,7 @@ async def test_today_blocker_opens_existing_preview_and_preserves_readiness_gate
 def test_readiness_runtime_is_available_in_offline_shell():
     service_worker = SERVICE_WORKER.read_text()
 
-    assert "const CACHE = 'stackchain-dashboard-shell-v112';" in service_worker
+    assert "const CACHE = 'stackchain-dashboard-shell-v113';" in service_worker
     assert "BASE + 'static/today-readiness.js'" in service_worker
 
 

tests/test_today_sync.py

@@ -127,7 +127,7 @@ sync.enqueueConfiguration(120, {{'issue:r:1:':60}});
 def test_inflight_today_drain_ships_in_a_new_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v112" in source
+    assert "stackchain-dashboard-shell-v113" in source
     assert "BASE + 'static/today-sync.js'" in source