feat: keep Human Gate decisions in reach on mobile (Closes #1439)

tests/e2e/test_human_gates_reopen_release.py

@@ -29,6 +29,7 @@ def test_release_artifact_reopens_human_gates_with_one_fresh_mobile_snapshot(
     current = {"gate": "g1"}
     evidence_url = {"value": "/evidence/manifest"}
     list_requests: list[str] = []
+    decision_requests: list[str] = []
     browser_errors: list[str] = []
 
     def gate(gate_id: str) -> dict:
@@ -61,6 +62,7 @@ def test_release_artifact_reopens_human_gates_with_one_fresh_mobile_snapshot(
             def human_gates_route(route):
                 path = route.request.url.split("?", 1)[0]
                 if route.request.method == "POST":
+                    decision_requests.append(path)
                     payload = {"receipt_id": "receipt-1", "state": "released"}
                 elif path.endswith("/api/v1/human-gates"):
                     list_requests.append(current["gate"])
@@ -81,9 +83,31 @@ def test_release_artifact_reopens_human_gates_with_one_fresh_mobile_snapshot(
             expect(page.locator("#human-gates")).to_be_visible()
             expect(page.locator("#human-gate-detail")).to_contain_text("First candidate")
 
+            tray = page.locator(".human-gate-decision-tray")
+            expect(tray).to_be_visible()
+            expect(page.locator("[data-gate-readiness]")).to_have_text(
+                "0 of 3 confirmations complete"
+            )
+            tray_bounds = tray.bounding_box()
+            assert tray_bounds
+            assert tray_bounds["y"] + tray_bounds["height"] <= height + 1
+            for action in ("hold", "release"):
+                bounds = page.locator(f'[data-gate-decision="{action}"]').bounding_box()
+                assert bounds and bounds["height"] >= 44
+
+            page.locator('[data-gate-decision="release"]').click()
+            expect(page.locator("[data-gate-error]")).to_contain_text(
+                "Complete the release checklist"
+            )
+            expect(page.locator('[data-gate-checklist="exact_hash"]')).to_be_focused()
+            assert decision_requests == []
+
             page.locator('[data-gate-checklist="exact_hash"]').check()
             page.locator('[data-gate-checklist="artifacts_reviewed"]').check()
             page.locator('[data-gate-checklist="provenance_reviewed"]').check()
+            expect(page.locator("[data-gate-readiness]")).to_have_text(
+                "3 of 3 confirmations complete"
+            )
             page.locator("[data-gate-reason]").fill("Awaiting final approval")
             with page.expect_popup() as popup_info:
                 page.get_by_role("link", name="Signed manifest").click()
@@ -108,6 +132,8 @@ def test_release_artifact_reopens_human_gates_with_one_fresh_mobile_snapshot(
             assert page.evaluate("key => localStorage.getItem(key) !== null", progress_key)
             page.locator('[data-gate-decision="release"]').click()
             expect(page.locator("#human-gates-status")).to_contain_text("Decision saved")
+            expect(page.locator(".human-gate-decision-tray")).to_have_count(0)
+            assert len(decision_requests) == 1
             assert not page.evaluate("key => localStorage.getItem(key) !== null", progress_key)
 
             page.evaluate("document.querySelector('#close-human-gates').click()")

tests/test_comment_next.py

@@ -303,4 +303,4 @@ async def test_unread_update_offers_reply_mark_read_and_next_independent_of_toda
     assert '.update-reply-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
     assert '.update-reply-actions button { min-height:44px;' in html
     worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
-    assert "stackchain-dashboard-shell-v146" in worker
+    assert "stackchain-dashboard-shell-v147" in worker

tests/test_following_frontend.py

@@ -593,7 +593,7 @@ process.stdout.write(JSON.stringify({{
     assert ".following-disposition-mode" in css
     assert "if (searchPreviewReturnKind === 'following')" in dashboard
     assert "e.key === 'Escape' && searchPreviewReturnKind === 'following'" in dashboard
-    assert "stackchain-dashboard-shell-v146" in service_worker
+    assert "stackchain-dashboard-shell-v147" in service_worker
 
 
 def test_prepare_today_lazily_refreshes_and_directly_reviews_following():

tests/test_human_gates_frontend.py

@@ -7,6 +7,7 @@ MODULE = Path(__file__).parents[1] / "frontend" / "human-gates.js"
 PROGRESSIVE = Path(__file__).parents[1] / "frontend" / "progressive-human-gates.js"
 INDEX = Path(__file__).parents[1] / "frontend" / "index.html"
 DASHBOARD = Path(__file__).parents[1] / "frontend" / "dashboard.js"
+CSS = Path(__file__).parents[1] / "frontend" / "dashboard.css"
 WORKER = Path(__file__).parents[1] / "frontend" / "service-worker.js"
 LIVE_SNAPSHOT = Path(__file__).parents[1] / "frontend" / "progressive-live-snapshot.js"
 PROGRESSIVE_MY_WORK = Path(__file__).parents[1] / "frontend" / "progressive-my-work.js"
@@ -274,6 +275,82 @@ const gates=createHumanGates({
     }
 
 
+def test_mobile_decision_tray_reports_readiness_and_targets_the_first_missing_confirmation():
+    output = run_node(r"""
+let posts=0;
+const focused=[];
+const checklist=[
+  {dataset:{gateChecklist:'exact_hash'},checked:true,focus(){focused.push('exact_hash')},scrollIntoView(){focused.push('scroll-exact_hash')}},
+  {dataset:{gateChecklist:'artifacts_reviewed'},checked:false,focus(){focused.push('artifacts_reviewed')},scrollIntoView(){focused.push('scroll-artifacts_reviewed')}},
+  {dataset:{gateChecklist:'provenance_reviewed'},checked:false,focus(){focused.push('provenance_reviewed')},scrollIntoView(){focused.push('scroll-provenance_reviewed')}},
+];
+const error={textContent:'',hidden:true};
+const readiness={textContent:''};
+const buttons=[{disabled:false},{disabled:false}];
+const detail={
+  innerHTML:'', addEventListener(){},
+  querySelectorAll:selector=>selector==='[data-gate-checklist]'?checklist:selector==='[data-gate-decision]'?buttons:[],
+  querySelector:selector=>selector==='[data-gate-error]'?error:selector==='[data-gate-readiness]'?readiness:selector==='[data-gate-reason]'?{value:''}:selector==='[data-gate-override]'?{value:''}:null,
+};
+const item={id:'g1',title:'Long evidence review',candidate_hash:'abc',revision:1,checks:[]};
+const gates=createHumanGates({
+  storage:{getItem:()=>null,setItem(){}},getLogin:()=> 'timmy',isOnline:()=>true,
+  nodes:{count:{},list:{},status:{},panel:{},detail},location:{hash:''},
+  fetchJson:async(path,options={})=>{if(options.method==='POST')posts+=1;return options.method==='POST'?{receipt_id:'r1'}:{pending_count:1,items:[item]};},
+});
+(async()=>{
+  await gates.load(); gates.reviewNext();
+  const rendered=detail.innerHTML;
+  let message='';
+  try { await gates.submitDecision('release'); } catch(error) { message=error.message; }
+  process.stdout.write(JSON.stringify({rendered,message,error,readiness,focused,posts}));
+})();
+""")
+    assert 'class="human-gate-decision-tray"' in output["rendered"]
+    assert 'data-gate-readiness' in output["rendered"]
+    assert output["message"] == "Complete the release checklist before deciding."
+    assert output["error"] == {
+        "textContent": "Complete the release checklist before deciding.",
+        "hidden": False,
+    }
+    assert output["readiness"]["textContent"] == "1 of 3 confirmations complete"
+    assert output["focused"] == ["scroll-artifacts_reviewed", "artifacts_reviewed"]
+    assert output["posts"] == 0
+
+
+def test_mobile_decision_tray_is_safe_area_aware_touch_sized_and_does_not_cover_form_fields():
+    css = CSS.read_text()
+
+    assert ".human-gate-decision-tray" in css
+    assert "position:sticky" in css
+    assert "bottom:calc(-1 * max(24px,env(safe-area-inset-bottom)))" in css
+    assert "padding-bottom:max(16px,env(safe-area-inset-bottom))" in css
+    assert ".human-gate-decision-actions button{min-height:44px}" in css
+    assert ".human-gate-detail{padding-bottom:" in css
+
+
+def test_human_gate_decision_tray_frontend_assets_invalidate_the_installed_shell_cache():
+    worker = WORKER.read_text()
+
+    assert "stackchain-dashboard-shell-v147" in worker
+
+
+def test_unmet_required_check_is_named_inline_and_focuses_the_override_reason():
+    output = run_node(r"""
+const focused=[];
+const checklist=['exact_hash','artifacts_reviewed','provenance_reviewed'].map(key=>({dataset:{gateChecklist:key},checked:true}));
+const override={value:'',focus(){focused.push('override')},scrollIntoView(){focused.push('scroll-override')}};
+const error={textContent:'',hidden:true};
+const detail={innerHTML:'',addEventListener(){},querySelectorAll:selector=>selector==='[data-gate-checklist]'?checklist:[],querySelector:selector=>selector==='[data-gate-error]'?error:selector==='[data-gate-override]'?override:selector==='[data-gate-reason]'?{value:''}:null};
+const item={id:'g1',title:'Candidate',candidate_hash:'abc',revision:1,checks:[{name:'Mobile browser journey',state:'failure',required:true}]};
+const gates=createHumanGates({storage:{getItem:()=>null,setItem(){}},getLogin:()=> 'timmy',isOnline:()=>true,nodes:{count:{},list:{},status:{},panel:{},detail},location:{hash:''},fetchJson:async()=>({pending_count:1,items:[item]})});
+(async()=>{await gates.load();gates.reviewNext();let message='';try{await gates.submitDecision('release')}catch(error){message=error.message}process.stdout.write(JSON.stringify({message,inline:error.textContent,focused}));})();
+""")
+    assert "Mobile browser journey" in output["message"]
+    assert output["inline"] == output["message"]
+    assert output["focused"] == ["scroll-override", "override"]
+
+
 def test_release_requires_override_for_unmet_required_checks_and_decisions_require_online_identity():
     output = run_node(r"""
 let online=true, login='timmy', posts=0;
@@ -492,7 +569,7 @@ def test_human_gate_mobile_shell_and_deep_route_are_wired():
     assert "mobileStartDay.reconcile({authoritative:true, authoritativePhases:['gate']})" in dashboard
     assert "counts.gate = queueCounts.gate" in dashboard
     assert "gate:preparationItems.gate || []" in dashboard
-    assert "stackchain-dashboard-shell-v146" in WORKER.read_text()
+    assert "stackchain-dashboard-shell-v147" in WORKER.read_text()
 
 
 def test_deep_link_opens_human_gates_without_waiting_for_optional_workspace():

tests/test_later_sync.py

@@ -435,5 +435,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
 def test_later_sync_ships_atomically_in_the_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/later-sync.js'" in source

tests/test_markdown_renderer.py

@@ -256,4 +256,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
     assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
     assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
     assert ".markdown-content a { min-height:44px;" in css
-    assert "stackchain-dashboard-shell-v146" in worker
+    assert "stackchain-dashboard-shell-v147" in worker

tests/test_mobile_composer_integration.py

@@ -45,7 +45,7 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
     shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
 
     assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
-    assert "stackchain-dashboard-shell-v146" in worker
+    assert "stackchain-dashboard-shell-v147" in worker
 
 
 def test_all_conversation_composers_offer_accessible_mobile_mentions():

tests/test_mobile_device_setup.py

@@ -383,7 +383,7 @@ def test_mobile_dashboard_mounts_phone_safe_device_setup_flow():
     assert "controller.recoverPermission('deadline')" in dashboard
     assert "pushControllerReady.then(ensureDeviceSetup)" in dashboard
     assert "BASE + 'static/mobile-device-setup.js'" in worker
-    assert "stackchain-dashboard-shell-v146" in worker
+    assert "stackchain-dashboard-shell-v147" in worker
     assert ".device-setup-panel" in css
     assert ".device-readiness-card" in css
     assert "overflow-x:hidden" in css

tests/test_mobile_insights.py

@@ -274,5 +274,5 @@ async def test_mobile_home_progressively_discloses_secondary_panels_as_insights(
 def test_mobile_insights_rolls_into_the_offline_shell():
     worker = (CONTROLLER.parent / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v146" in worker
+    assert "stackchain-dashboard-shell-v147" in worker
     assert "BASE + 'static/mobile-insights.js'" in worker

tests/test_mobile_start_day.py

@@ -469,7 +469,7 @@ async def test_dashboard_wires_thumb_safe_start_day_briefing_into_offline_mobile
     assert ".mobile-start-day-finish { min-height:44px;" in html
     assert "max-width:100%; overflow-wrap:anywhere;" in html
     assert "BASE + 'static/mobile-start-day.js'" in service_worker
-    assert "stackchain-dashboard-shell-v146" in service_worker
+    assert "stackchain-dashboard-shell-v147" in service_worker
 
 
 @pytest.mark.anyio

tests/test_plan_today.py

@@ -418,7 +418,7 @@ async def test_starting_saved_today_work_closes_a_concurrent_rollover_planner():
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/plan-today.js'" in source
     assert "BASE + 'static/plan-today-readiness.js'" in source
     assert "BASE + 'static/plan-today-preview.js'" in source

tests/test_service_worker.py

@@ -189,14 +189,14 @@ async function dispatchPush(payload) {{
 def test_shared_progressive_snapshot_broker_rolls_the_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/progressive-live-snapshot.js'" in source
 
 
 def test_week_unplan_undo_rolls_the_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/week-plan.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
 
@@ -204,20 +204,20 @@ def test_week_unplan_undo_rolls_the_offline_shell():
 def test_private_today_action_mailbox_rolls_the_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
 
 
 def test_per_day_week_conflict_ui_rolls_the_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/week-plan.js'" in source
 
 
 def test_resumable_today_session_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/my-work.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
@@ -226,7 +226,7 @@ def test_resumable_today_session_ships_in_a_new_offline_shell():
 def test_mobile_conversation_photo_bundles_roll_the_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/authored-outbox.js'" in source
     assert "BASE + 'static/background-issue-sync.js'" in source
@@ -235,7 +235,7 @@ def test_mobile_conversation_photo_bundles_roll_the_offline_shell():
 def test_photo_metadata_sanitizer_rolls_the_cached_optimizer_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/issue-evidence-review.js'" in source
     assert "BASE + 'static/issue-attachment.js'" in source
 
@@ -243,14 +243,14 @@ def test_photo_metadata_sanitizer_rolls_the_cached_optimizer_atomically():
 def test_ownership_exit_runtime_rolls_the_offline_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/dashboard.js'" in source
 
 
 def test_offline_review_next_ships_today_completion_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/today-completion.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -258,7 +258,7 @@ def test_offline_review_next_ships_today_completion_atomically():
 def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/create-issue-sheet.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -266,7 +266,7 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
 def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/issue-sheet.js'" in source
     assert "BASE + 'static/checklist-conflict.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
@@ -276,14 +276,14 @@ def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
 def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/later-picker.js'" in source
 
 
 def test_navigation_deadline_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/dashboard.css'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/install-app.js'" in source
@@ -292,21 +292,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
 def test_today_convergence_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/today-sync.js'" in source
 
 
 def test_mobile_search_viewport_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/mobile-search-viewport.js'" in source
 
 
 def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/update-ownership.js'" in source
 
 
@@ -1390,7 +1390,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
 def test_queue_today_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/queue-today.js'" in source
 
 

tests/test_today_readiness.py

@@ -221,7 +221,7 @@ async def test_today_blocker_opens_existing_preview_and_preserves_readiness_gate
 def test_readiness_runtime_is_available_in_offline_shell():
     service_worker = SERVICE_WORKER.read_text()
 
-    assert "const CACHE = 'stackchain-dashboard-shell-v146';" in service_worker
+    assert "const CACHE = 'stackchain-dashboard-shell-v147';" in service_worker
     assert "BASE + 'static/today-readiness.js'" in service_worker
 
 

tests/test_today_sync.py

@@ -343,7 +343,7 @@ listeners['stackchain:first-task-complete']();
 def test_inflight_today_drain_ships_in_a_new_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v146" in source
+    assert "stackchain-dashboard-shell-v147" in source
     assert "BASE + 'static/today-sync.js'" in source