feat: close authored pulls with recovery (Closes #1356)

tests/e2e/test_mobile_close_authored_pull_release.py

@@ -0,0 +1,87 @@
+import os
+from pathlib import Path
+
+import pytest
+
+
+ROOT = Path(__file__).parents[2]
+pytestmark = pytest.mark.skipif(
+    os.environ.get("STACKCHAIN_RUN_RELEASE_E2E") != "1",
+    reason="release browser journey is opt-in",
+)
+
+
+@pytest.mark.parametrize("viewport", [(320, 568), (390, 844)])
+def test_mobile_author_closes_obsolete_pull_then_recovers_it(viewport):
+    playwright = pytest.importorskip("playwright.sync_api")
+    html = (ROOT / "frontend" / "index.html").read_text()
+
+    with playwright.sync_playwright() as runtime:
+        try:
+            browser = runtime.chromium.launch(headless=True)
+        except Exception as error:
+            pytest.skip(f"Chromium is not installed: {error}")
+        page = browser.new_page(viewport={"width": viewport[0], "height": viewport[1]})
+        page.on("dialog", lambda dialog: dialog.accept())
+        page.set_content(html, wait_until="domcontentloaded")
+        page.add_style_tag(path=ROOT / "frontend" / "dashboard.css")
+        page.add_script_tag(path=ROOT / "frontend" / "pull-sheet.js")
+        page.evaluate(
+            """() => {
+                window.lifecycleCalls = [];
+                window.lifecycleItem = {repository:'stackchain/api', number:7, key:'stackchain/api#7'};
+                window.lifecycleDetail = {
+                  number:7, title:'Obsolete experiment', author:'timmy', state:'open',
+                  merged:false, head_sha:'abc1234', capabilities:{authored:true, assigned:false},
+                };
+                const controller = createPullSheet({
+                  storage:null,
+                  fetchJson:async (path, options) => {
+                    lifecycleCalls.push({path, method:options.method, body:JSON.parse(options.body)});
+                    const state = path.endsWith('/close') ? 'closed' : 'open';
+                    return {repository:'stackchain/api', number:7, title:'Obsolete experiment',
+                      head_sha:'abc1234', state, merged:false};
+                  },
+                });
+                createPullSheet.bindLifecycleControls(
+                  document, controller, () => lifecycleItem, () => lifecycleDetail,
+                  result => { lifecycleDetail = {...lifecycleDetail, ...result}; }
+                );
+                createPullSheet.resetLifecycleControls(document, lifecycleDetail);
+                document.querySelector('#pull-sheet').classList.add('open');
+            }"""
+        )
+
+        page.locator("#pull-lifecycle summary").click()
+        close = page.get_by_role("button", name="Close pull request")
+        before = close.evaluate("button => ({height:button.getBoundingClientRect().height, hidden:button.hidden})")
+        close.click()
+        page.get_by_text("Pull request closed.").wait_for()
+        reopen = page.get_by_role("button", name="Reopen pull request")
+        receipt = reopen.evaluate("button => ({height:button.getBoundingClientRect().height, hidden:button.closest('[hidden]') !== null})")
+        reopen.click()
+        page.get_by_text("Pull request reopened.").wait_for()
+        metrics = page.evaluate(
+            """() => ({
+              calls:lifecycleCalls,
+              state:lifecycleDetail.state,
+              closeHidden:document.querySelector('#close-authored-pull').hidden,
+              receiptHidden:document.querySelector('#pull-close-receipt').hidden,
+              focused:document.activeElement === document.querySelector('#close-authored-pull'),
+              scrollWidth:document.documentElement.scrollWidth,
+              clientWidth:document.documentElement.clientWidth,
+            })"""
+        )
+        browser.close()
+
+    assert before["hidden"] is False
+    assert before["height"] >= 44
+    assert receipt["height"] >= 44
+    assert receipt["hidden"] is False
+    assert [call["path"].rsplit("/", 1)[-1] for call in metrics["calls"]] == ["close", "reopen"]
+    assert all(call["body"] == {"expected_head_sha": "abc1234"} for call in metrics["calls"])
+    assert metrics["state"] == "open"
+    assert metrics["closeHidden"] is False
+    assert metrics["receiptHidden"] is True
+    assert metrics["focused"] is True
+    assert metrics["scrollWidth"] <= metrics["clientWidth"]