feat: resolve mobile checklist conflicts (Closes #913)

frontend/authored-outbox.js

@@ -1,4 +1,4 @@
-function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync, getOwnerLogin = () => '', createOperationId, now = () => Date.now(), maxItems = 50 }) {
+function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync, getOwnerLogin = () => '', createOperationId, mergeChecklistConflict, now = () => Date.now(), maxItems = 50 }) {
   const storageKey = 'stackchain.authored-outbox.v1';
   const makeId = createOperationId || (() =>
     globalThis.crypto?.randomUUID?.() || String(Date.now()) + '-' + Math.random().toString(16).slice(2)
@@ -113,6 +113,7 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
       } : {}),
       ...(message.kind === 'issue-content' ? {
         title: String(message.title || ''),
+        baseBody: String(message.baseBody ?? message.body ?? ''),
         expectedUpdatedAt: String(message.expectedUpdatedAt || ''),
       } : {}),
     };
@@ -363,6 +364,51 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
     return retryItem(id, currentLogin);
   }
 
+  async function resolveIssueContentConflict(id, latest, currentLogin) {
+    const previousItems = read();
+    const item = previousItems.find(candidate => candidate.id === id);
+    currentLogin = String(currentLogin || '').trim();
+    if (!item || item.kind !== 'issue-content' || item.status !== 'attention') {
+      throw new Error('This checklist conflict is no longer available.');
+    }
+    if (!currentLogin || item.ownerLogin !== currentLogin) {
+      throw new Error('Confirm the account that queued this checklist update.');
+    }
+    if (typeof mergeChecklistConflict !== 'function') {
+      throw new Error('Checklist conflict review is unavailable.');
+    }
+    const merged = mergeChecklistConflict({
+      baseBody: String(item.baseBody ?? item.body ?? ''),
+      localBody: String(item.body || ''),
+      remoteBody: String(latest?.body || ''),
+    });
+    if (merged.conflicts?.length) return merged;
+    if (!String(latest?.updated_at || '')) throw new Error('Latest issue revision is unavailable.');
+    const rebased = {
+      ...item,
+      operationId: String(makeId()).slice(0, 128),
+      title: String(latest?.title || ''),
+      baseBody: String(latest?.body || ''),
+      body: merged.body,
+      expectedUpdatedAt: String(latest.updated_at),
+      status: 'queued',
+    };
+    delete rebased.error;
+    delete rebased.deliveryState;
+    const nextItems = previousItems.map(candidate => candidate.id === id ? rebased : candidate);
+    write(nextItems, false);
+    if (backgroundSync?.reconcile) {
+      try { await backgroundSync.reconcile(nextItems, 'authored'); }
+      catch (error) {
+        write(previousItems, false);
+        throw error;
+      }
+      try { await backgroundSync.requestSync?.(); }
+      catch (_error) { /* Foreground retry remains available. */ }
+    }
+    return { ...merged, item: rebased };
+  }
+
   function reconcileBackground(records) {
     const statuses = new Map((records || []).map(item => [item.id, item]));
     const items = read().flatMap(item => {
@@ -388,7 +434,8 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
     return items;
   }
 
-  return { enqueue, enqueueDurably, update, discard, flush, retry, reconcileBackground, list: () => read().map(item => ({ ...item })) };
+  return { enqueue, enqueueDurably, update, discard, flush, retry, resolveIssueContentConflict,
+    reconcileBackground, list: () => read().map(item => ({ ...item })) };
 }
 
 if (typeof module !== 'undefined' && module.exports) module.exports = createAuthoredOutbox;

frontend/checklist-conflict.js

@@ -0,0 +1,58 @@
+function mergeChecklistConflict({ baseBody, localBody, remoteBody }) {
+  const taskPattern = /^(\s*[-*+]\s+\[)([ xX])(\]\s+)(.*)$/;
+
+  function tasks(body) {
+    const entries = [];
+    String(body || '').split('\n').forEach((line, lineIndex) => {
+      const match = line.match(taskPattern);
+      if (!match) return;
+      const label = match[4].trim();
+      const key = label.replace(/\s+/g, ' ').toLocaleLowerCase();
+      if (!key) return;
+      entries.push({ key, label, checked: match[2].toLowerCase() === 'x', lineIndex, match });
+    });
+    return entries;
+  }
+
+  function grouped(entries) {
+    const result = new Map();
+    entries.forEach(entry => result.set(entry.key, [...(result.get(entry.key) || []), entry]));
+    return result;
+  }
+
+  const base = grouped(tasks(baseBody));
+  const local = grouped(tasks(localBody));
+  const remoteEntries = tasks(remoteBody);
+  const remote = grouped(remoteEntries);
+  const changes = [];
+  const conflicts = [];
+
+  for (const [key, baseMatches] of base) {
+    const localMatches = local.get(key) || [];
+    if (baseMatches.length !== 1 || localMatches.length !== 1) continue;
+    if (baseMatches[0].checked === localMatches[0].checked) continue;
+    const remoteMatches = remote.get(key) || [];
+    if (remoteMatches.length !== 1) {
+      conflicts.push({
+        label: baseMatches[0].label,
+        reason: remoteMatches.length ? 'ambiguous' : 'missing',
+      });
+      continue;
+    }
+    changes.push({ label: remoteMatches[0].label, checked: localMatches[0].checked });
+  }
+
+  if (conflicts.length) return { body: null, changes, conflicts };
+  const desired = new Map(changes.map(change => [
+    change.label.replace(/\s+/g, ' ').toLocaleLowerCase(), change.checked,
+  ]));
+  const lines = String(remoteBody || '').split('\n');
+  remoteEntries.forEach(entry => {
+    if (!desired.has(entry.key)) return;
+    const marker = desired.get(entry.key) ? 'x' : ' ';
+    lines[entry.lineIndex] = entry.match[1] + marker + entry.match[3] + entry.match[4];
+  });
+  return { body: lines.join('\n'), changes, conflicts: [] };
+}
+
+if (typeof module !== 'undefined') module.exports = mergeChecklistConflict;

frontend/dashboard.js

@@ -673,6 +673,7 @@
     storage: localStorage, fetchJson: fetchReviewJson, coordinator: outboxCoordinator,
     backgroundSync: backgroundIssueSync,
     getOwnerLogin: () => confirmedOwnerLogin,
+    mergeChecklistConflict: mergeChecklistConflict,
   });
   const queueOfflineIssueBlocker = createOfflineIssueBlocker({
     enqueueDurably: message => authoredOutbox.enqueueDurably(message),
@@ -2745,6 +2746,7 @@
       const isUnfiled = item.kind === 'unfiled-issue';
       const reviewOutbox = item.outbox_kind === 'pull-review';
       const closureOutbox = item.outbox_kind === 'issue-close';
+      const checklistConflict = item.checklist_conflict === true;
       const sendLabel = item.delivery_state === 'uncertain' ? 'Verified not posted — retry' : 'Send now';
       const outboxActions = item.quarantined ?
         '<button class="draft-copy" data-draft-index="' + index + '" type="button">Copy content</button>' +
@@ -2764,6 +2766,9 @@
         '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open current review</button>' +
         '<button class="draft-copy" data-draft-index="' + index + '" type="button">Copy feedback</button>' +
         '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard queued review</button>' :
+        item.kind === 'authored-outbox' && checklistConflict ?
+        '<button class="draft-review-checklist" data-draft-index="' + index + '" type="button">Review changes</button>' +
+        '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard</button>' :
         item.kind === 'authored-outbox' && closureOutbox ?
         '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open issue</button>' +
         '<button class="draft-authorize" data-draft-index="' + index + '" type="button">Authorize &amp; close</button>' +
@@ -2873,6 +2878,42 @@
         else applyOutboxResult(await issueOutbox.retry(item.outbox_id, activeFlushLogin));
       });
     });
+    list.querySelectorAll('.draft-review-checklist').forEach(button => {
+      button.addEventListener('click', async () => {
+        const item = lastDrafts[Number(button.dataset.draftIndex)];
+        const queued = authoredOutbox.list().find(candidate => candidate.id === item?.outbox_id);
+        if (!item?.checklist_conflict || !queued || !activeFlushLogin) return;
+        button.disabled = true;
+        qs('#my-work-action-status').textContent = 'Loading the latest checklist for review…';
+        try {
+          const latest = await issueController.load({
+            repository:item.repository, number:item.number,
+          });
+          const preview = mergeChecklistConflict({
+            baseBody:queued.baseBody, localBody:queued.body, remoteBody:latest.body,
+          });
+          if (preview.conflicts.length) {
+            qs('#my-work-action-status').textContent = 'Checklist changes for ' +
+              preview.conflicts.map(conflict => conflict.label).join(', ') +
+              ' could not be matched safely. Open the issue to compare renamed or deleted tasks.';
+            return;
+          }
+          if (!window.confirm('Apply ' + preview.changes.length + ' checklist change' +
+              (preview.changes.length === 1 ? '' : 's') + ' to the latest issue? Remote prose and other tasks will stay unchanged.')) return;
+          const result = await authoredOutbox.resolveIssueContentConflict(item.outbox_id, latest, activeFlushLogin);
+          if (result.conflicts.length) return;
+          const delivery = await authoredOutbox.retry(item.outbox_id, activeFlushLogin);
+          applyAuthoredOutboxResult(delivery);
+          qs('#my-work-action-status').textContent = delivery.confirmed?.length ?
+            'Checklist changes applied to the latest issue.' :
+            'The issue changed again. Review the checklist conflict against the new version.';
+        } catch (error) {
+          qs('#my-work-action-status').textContent = String(error?.message || 'Checklist review could not be loaded. Retry when online.');
+        } finally {
+          button.disabled = false;
+        }
+      });
+    });
     list.querySelectorAll('.draft-authorize').forEach(button => {
       button.addEventListener('click', async () => {
         const item = lastDrafts[Number(button.dataset.draftIndex)];

frontend/drafts.js

@@ -155,6 +155,8 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
             .filter(Boolean).join('\n\n');
           const ownerLogin = String(item.ownerLogin || '').trim();
           const quarantined = !ownerLogin || !currentLogin || ownerLogin !== currentLogin;
+          const checklistConflict = !quarantined && item.kind === 'issue-content' &&
+            item.status === 'attention' && typeof item.baseBody === 'string';
           return {
             id: 'stackchain.authored-outbox.v1:' + item.id,
             outbox_id: item.id,
@@ -162,7 +164,7 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
             kind: 'authored-outbox',
             status: item.status === 'attention' ? 'attention' : (item.status === 'sending' ? 'sending' :
               (item.status === 'authorization' || isClosure ? 'authorization' : 'queued')),
-            label: item.deliveryState === 'uncertain' ? 'Verify delivery' :
+            label: checklistConflict ? 'Checklist conflict' : item.deliveryState === 'uncertain' ? 'Verify delivery' :
               (item.status === 'attention' ? (isClosure ? 'Issue closure needs attention' : 'Needs attention') :
                 (isReview ? (item.status === 'authorization' ? 'Review awaiting authorization' : 'Queued review') :
                   (isClosure ? 'Awaiting authorization' : 'Queued message'))),
@@ -172,6 +174,7 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
             title: target,
             preview: textPreview([item.error, item.body].filter(Boolean).join(' — ')),
             copy_text: copyText,
+            checklist_conflict: checklistConflict,
             ...(isReview ? { head_sha: item.expectedHeadSha } : {}),
             quarantined,
             ownership: quarantined ? 'Queued by ' + (ownerLogin || 'an unknown account') +

frontend/issue-sheet.js

@@ -158,7 +158,7 @@ function createIssueSheet({ fetchJson, storage, renderMarkdown = globalThis.rend
       }
       const body = toggleTask(detail.body, taskIndex, checked);
       await enqueueDurably({ kind:'issue-content', repository:item.repository, number:item.number,
-        title:detail.title, body, expectedUpdatedAt:detail.updated_at });
+        title:detail.title, baseBody:detail.body, body, expectedUpdatedAt:detail.updated_at });
       return { queued:true, detail:{ ...detail, body, checklist_pending:true } };
     },
     pendingTask(item, detail, items, ownerLogin) {