feat: paginate balanced mobile search results (Closes #783)

tests/test_command_palette.py

@@ -142,6 +142,38 @@ if (!ready || ready.items.length !== 1 || ready.partial !== true) {{
     subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
 
 
+def test_remote_command_search_appends_deduplicated_pages_and_ignores_stale_load_more():
+    script = f"""
+const filterCommands = require({json.dumps(str(COMMANDS))});
+(async () => {{
+const pending = new Map();
+const states = [];
+const controller = filterCommands.createGlobalSearchController({{
+  delay: 0,
+  search: (query, signal, page) => new Promise(resolve => pending.set(query + ':' + page, resolve)),
+  onState: state => states.push(state),
+}});
+controller.setQuery('mobile');
+await new Promise(resolve => setTimeout(resolve, 0));
+pending.get('mobile:1')({{ items:[{{kind:'issue',repository:'a/b',number:1}}], has_more:true, next_page:2 }});
+await new Promise(resolve => setTimeout(resolve, 0));
+controller.loadMore();
+await new Promise(resolve => setTimeout(resolve, 0));
+controller.setQuery('release');
+await new Promise(resolve => setTimeout(resolve, 0));
+pending.get('mobile:2')({{ items:[{{kind:'issue',repository:'a/b',number:1}},{{kind:'pull',repository:'a/b',number:2}}], has_more:false, next_page:3 }});
+pending.get('release:1')({{ items:[{{kind:'issue',repository:'a/b',number:3}}], has_more:false, next_page:2 }});
+await new Promise(resolve => setTimeout(resolve, 0));
+const ready = states.filter(state => state.status === 'ready').at(-1);
+if (ready.query !== 'release' || ready.items.length !== 1 || ready.items[0].number !== 3) {{
+  throw new Error('stale page entered current query: ' + JSON.stringify(states));
+}}
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+
+    subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+
+
 def test_command_selection_wraps_for_arrow_keys():
     script = f"""
 const commands = require({json.dumps(str(COMMANDS))});
@@ -161,9 +193,10 @@ def test_palette_exposes_accessible_global_work_search_under_dashboard_subpath()
     assert 'aria-controls="cmd-results"' in html
     assert 'role="listbox"' in html
     assert "fetch('api/v1/search?q='" in html
-    assert "async function searchGlobalWork(query, signal)" in html
+    assert "async function searchGlobalWork(query, signal, page = 1)" in html
     assert "signal," in html
     assert "Some results are temporarily unavailable." in html
+    assert 'id="cmd-load-more"' in html
     assert urljoin(
         "https://forge.alexanderwhitestone.com/dashboard/",
         "api/v1/search?q=mobile",

tests/test_global_search.py

@@ -10,8 +10,8 @@ from src import gitea_proxy, main
 async def test_global_search_endpoint_returns_bounded_normalized_results(monkeypatch):
     requested = []
 
-    async def search(query, limit):
-        requested.append((query, limit))
+    async def search(query, limit, page):
+        requested.append((query, limit, page))
         return {
             "items": [{
                 "kind": "issue",
@@ -27,11 +27,11 @@ async def test_global_search_endpoint_returns_bounded_normalized_results(monkeyp
     monkeypatch.setattr(main.gitea_proxy, "global_search", search, raising=False)
     transport = httpx.ASGITransport(app=main.app)
     async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
-        response = await client.get("/api/v1/search?q=mobile&limit=7")
+        response = await client.get("/api/v1/search?q=mobile&limit=7&page=2")
 
     assert response.status_code == 200
     assert response.headers["cache-control"] == "no-store"
-    assert requested == [("mobile", 7)]
+    assert requested == [("mobile", 7, 2)]
     assert response.json() == {"query": "mobile", "items": [{
         "kind": "issue",
         "repository": "stackchain/api",
@@ -110,7 +110,7 @@ async def test_global_search_queries_issues_and_pulls_and_skips_unsafe_results()
         await gitea_proxy.stop_client()
 
     assert {request["type"] for request in requests} == {"issues", "pulls"}
-    assert all(request["q"] == "mobile queue" and request["limit"] == "7" for request in requests)
+    assert all(request["q"] == "mobile queue" and request["limit"] == "4" for request in requests)
     assert results == {
         "items": [{
             "kind": "issue", "repository": "stackchain/api", "number": 42,
@@ -122,6 +122,8 @@ async def test_global_search_queries_issues_and_pulls_and_skips_unsafe_results()
             "url": "https://forge.example/stackchain/web/pulls/9",
         }],
         "partial": False,
+        "has_more": False,
+        "next_page": 2,
     }
 
 
@@ -154,6 +156,8 @@ async def test_global_search_returns_healthy_stream_when_other_stream_fails():
             "url": "https://forge.example/stackchain/web/pulls/9",
         }],
         "partial": True,
+        "has_more": False,
+        "next_page": 2,
     }
 
 
@@ -180,6 +184,38 @@ async def test_global_search_caps_combined_results_to_requested_limit():
     assert result["partial"] is False
 
 
+@pytest.mark.anyio
+async def test_global_search_pages_each_stream_and_balances_results():
+    requests = []
+
+    async def handler(request):
+        params = dict(request.url.params)
+        requests.append(params)
+        kind = params["type"]
+        page = int(params["page"])
+        items = [{
+            "number": page * 10 + number,
+            "title": f"{kind} page {page} result {number}",
+            "state": "open",
+            "repository": {"full_name": "stackchain/web"},
+            "html_url": f"https://forge.example/stackchain/web/{kind}/{page * 10 + number}",
+        } for number in (1, 2, 3, 4)]
+        return httpx.Response(200, json=items)
+
+    gitea_proxy.start_client(transport=httpx.MockTransport(handler))
+    try:
+        result = await gitea_proxy.global_search("search", limit=4, page=2)
+    finally:
+        await gitea_proxy.stop_client()
+
+    assert {(request["type"], request["page"]) for request in requests} == {
+        ("issues", "2"), ("pulls", "2")
+    }
+    assert [item["kind"] for item in result["items"]] == ["issue", "pull", "issue", "pull"]
+    assert result["next_page"] == 3
+    assert result["has_more"] is True
+
+
 @pytest.mark.anyio
 async def test_global_search_propagates_cancellation_to_stop_obsolete_work():
     async def handler(request):