feat: make consequential reviews passkey-native (Closes #509)

src/main.py

@@ -200,17 +200,20 @@ class DashboardSignIn(BaseModel):
         return normalized
 
 
+StepUpAction = Literal[
+    "merge_pull",
+    "submit_pull_review",
+    "close_issue",
+    "revoke_device",
+    "revoke_all_sessions",
+    "enroll_passkey",
+    "revoke_passkey",
+]
+
+
 class FreshAuthorization(BaseModel):
     access_token: str = Field(min_length=1, max_length=1_024)
-    action: Literal[
-        "merge_pull",
-        "submit_pull_review",
-        "close_issue",
-        "revoke_device",
-        "revoke_all_sessions",
-        "enroll_passkey",
-        "revoke_passkey",
-    ]
+    action: StepUpAction
     target: str = Field(min_length=1, max_length=255)
 
 
@@ -228,9 +231,7 @@ class PasskeyAuthentication(PasskeyCeremony):
 
 
 class PasskeyAuthorizationTarget(BaseModel):
-    action: Literal[
-        "merge_pull", "close_issue", "revoke_device", "revoke_all_sessions", "revoke_passkey"
-    ]
+    action: StepUpAction
     target: str = Field(min_length=1, max_length=255)
 
 
@@ -3825,12 +3826,50 @@ async def submit_review(
             submission.decision,
             submission.body,
         )
-        if submission.comments:
-            return await gitea_proxy.submit_pull_review(
-                *args,
-                [comment.model_dump() for comment in submission.comments],
-            )
-        return await gitea_proxy.submit_pull_review(*args)
+        journal = None
+        operation_id = None
+        if submission.decision != "comment":
+            journal = _security_event_store()
+            try:
+                operation_id = await asyncio.to_thread(
+                    journal.reserve,
+                    (
+                        "pull_review_approved"
+                        if submission.decision == "approve"
+                        else "pull_review_changes_requested"
+                    ),
+                    target=f"{repository}#{number}",
+                )
+            except SecurityEventStoreError:
+                raise HTTPException(
+                    status_code=503,
+                    detail="Security activity is temporarily unavailable",
+                )
+        try:
+            if submission.comments:
+                result = await gitea_proxy.submit_pull_review(
+                    *args,
+                    [comment.model_dump() for comment in submission.comments],
+                )
+            else:
+                result = await gitea_proxy.submit_pull_review(*args)
+        except (
+            HTTPException,
+            gitea_proxy.StaleReviewError,
+            gitea_proxy.InvalidReviewCommentError,
+        ):
+            if journal is not None and operation_id is not None:
+                try:
+                    await asyncio.to_thread(journal.discard, operation_id)
+                except SecurityEventStoreError:
+                    pass
+            raise
+        if journal is not None and operation_id is not None:
+            try:
+                await asyncio.to_thread(journal.finalize, operation_id)
+            except SecurityEventStoreError:
+                pass
+        return result
 
     try:
         comment_fingerprint = tuple(