feat: unify mobile work queues (Closes #627)

tests/test_mobile_task_dock.py

@@ -274,6 +274,82 @@ process.stdout.write(JSON.stringify({{
     }
 
 
+def test_mobile_task_dock_opens_stable_queue_switcher_and_routes_each_queue():
+    script = f"""
+const createDock = require({json.dumps(str(DOCK))});
+class FakeElement {{
+  constructor() {{ this.listeners = {{}}; this.attributes = {{}}; this.hidden = false; this.textContent = ''; this.focuses = 0; this.classList = {{contains:()=>false}}; }}
+  addEventListener(name, callback) {{ this.listeners[name] = callback; }}
+  click() {{ return this.listeners.click?.({{currentTarget:this}}); }}
+  setAttribute(name, value) {{ this.attributes[name] = value; }}
+  removeAttribute(name) {{ delete this.attributes[name]; }}
+  focus() {{ this.focuses += 1; }}
+}}
+const nav = new FakeElement();
+const queues = new FakeElement();
+const sheet = new FakeElement(); sheet.open = false;
+sheet.showModal = function () {{ this.open = true; }};
+sheet.close = function () {{ this.open = false; this.listeners.close?.(); }};
+const close = new FakeElement();
+const badge = new FakeElement();
+const rows = Object.fromEntries(['today','attention','later','draft'].map(name => [name, new FakeElement()]));
+const counts = Object.fromEntries(Object.keys(rows).map(name => [name, new FakeElement()]));
+const selected = [];
+const dock = createDock({{
+  nav, buttons:{{queues}}, actions:{{queues:()=>{{}}}}, overlays:[sheet],
+  queueSheet:sheet, queueClose:close, queueRows:rows, queueCounts:counts, queueBadge:badge,
+  onSelectQueue:name=>selected.push(name),
+  observe() {{}},
+}});
+dock.start();
+dock.updateQueues({{today:2, attention:1, later:3, draft:4}});
+queues.click();
+const opened = sheet.open;
+rows.later.click();
+const closedAfterSelect = !sheet.open;
+queues.click(); close.click();
+process.stdout.write(JSON.stringify({{
+  opened, closedAfterSelect, selected,
+  badge:badge.textContent, badgeLabel:queues.attributes['aria-label'],
+  counts:Object.fromEntries(Object.entries(counts).map(([name, node]) => [name, node.textContent])),
+  queueFocuses:queues.focuses,
+  columnState:nav.attributes['data-attention'] || null,
+}}));
+"""
+    result = subprocess.run(["node", "-e", script], capture_output=True, text=True)
+
+    assert result.returncode == 0, result.stderr
+    assert json.loads(result.stdout) == {
+        "opened": True,
+        "closedAfterSelect": True,
+        "selected": ["later"],
+        "badge": "10",
+        "badgeLabel": "Queues, 10 items",
+        "counts": {"today": "2", "attention": "1", "later": "3", "draft": "4"},
+        "queueFocuses": 2,
+        "columnState": None,
+    }
+
+
+@pytest.mark.anyio
+async def test_dashboard_renders_and_wires_mobile_queue_switcher():
+    html = await dashboard()
+
+    assert 'data-mobile-task="queues"' in html
+    assert 'id="mobile-queue-sheet"' in html
+    assert 'aria-labelledby="mobile-queue-heading"' in html
+    assert 'data-mobile-queue="today"' in html
+    assert 'data-mobile-queue="attention"' in html
+    assert 'data-mobile-queue="later"' in html
+    assert 'data-mobile-queue="draft"' in html
+    assert 'id="mobile-queue-count"' in html
+    assert 'mobileTaskDock.updateQueues(counts)' in html
+    assert "onSelectQueue: openMobileQueue" in html
+    assert '.mobile-queue-sheet' in html
+    assert 'padding-bottom:calc(16px + env(safe-area-inset-bottom))' in html
+    assert '.mobile-task-dock[data-attention="true"]' not in html
+
+
 @pytest.mark.anyio
 async def test_dashboard_wires_mobile_work_dock_into_today_session_lifecycle():
     html = await dashboard()
@@ -301,27 +377,25 @@ async def test_dashboard_renders_and_wires_phone_safe_task_dock():
     html = await dashboard()
 
     assert '<nav class="mobile-task-dock" id="mobile-task-dock" aria-label="Primary tasks">' in html
-    assert html.count('class="mobile-task-action" data-mobile-task=') == 6
-    for task in ("work", "attention", "find", "new", "search", "drafts"):
+    assert html.count('class="mobile-task-action" data-mobile-task=') == 5
+    for task in ("work", "find", "new", "search", "queues"):
         assert f'data-mobile-task="{task}"' in html
-    assert 'id="mobile-draft-count"' in html
+    assert 'id="mobile-queue-count"' in html
     assert 'data-work-filter="attention"' in html
-    assert 'id="mobile-attention-count"' in html
     assert '.mobile-task-dock { display:none;' in html
     assert 'grid-template-columns:repeat(5,minmax(0,1fr))' in html
-    assert '.mobile-task-dock[data-attention="true"] { grid-template-columns:repeat(6,minmax(0,1fr));' in html
     assert 'padding-bottom:env(safe-area-inset-bottom)' in html
     assert '.mobile-task-action { min-width:0; min-height:44px;' in html
     assert '<script src="static/mobile-task-dock.js"></script>' in html
     assert "createMobileTaskDock({" in html
     assert "work: () => mobileWorkEntry.open()" in html
-    assert "attention: openMobileAttention" in html
-    assert "qs('[data-work-filter=\"attention\"]').click()" in html
+    assert "onSelectQueue: openMobileQueue" in html
+    assert "qs('[data-work-filter=\"' + name + '\"]').click()" in html
     assert "find: () => qs('#find-work').click()" in html
     assert "new: () => qs('#new-issue').click()" in html
     assert "search: () => qs('#open-palette').click()" in html
-    assert "drafts: () => qs('[data-work-filter=\"draft\"]').click()" in html
-    assert "draftCount.textContent = sourceDraftCount.textContent" in html
+    assert "queues: () => {}" in html
+    assert "mobileTaskDock.updateQueues(counts)" in html
     assert "mobileTaskDock.updateWork(mobileWorkEntry.mode())" in html
     assert "mobileTaskDock.updateAttention(countMyWork(activeMyWork).attention)" in html
 
@@ -358,7 +432,7 @@ async def test_mobile_attention_pauses_today_and_offers_phone_safe_return():
 
     assert 'class="attention-interruption" id="attention-interruption"' in html
     assert 'id="return-to-today" type="button">Return to Today</button>' in html
-    assert 'if (workSession.checkpointed()) timer.beginAttention();' in html
+    assert "if (name === 'attention' && workSession.checkpointed()) timer.beginAttention();" in html
     assert 'timer.returnFromAttention()' in html
     assert "workSession.reopen(item)" in html
     assert "attentionInterruption.hidden = !pending" in html

tests/test_unfiled_captures.py

@@ -330,7 +330,7 @@ async def test_mobile_composer_exposes_cold_offline_save_and_account_safe_resume
     assert "getCaptureLogin: () => String(lastContextSnapshot?.user?.login || '').trim()" in html
     assert "unfiledCaptures.save(captureDraft)" in html
     assert "const savedCapture = await unfiledCaptures.save(captureDraft)" in html
-    assert "mobileTaskDock.select('drafts')" in html
+    assert "mobileTaskDock.select('queues')" in html
     assert "data-capture-id=\"' + escapeHtml(item.capture_id) + '\"" in html
     assert "requestAnimationFrame(() =>" in html
     assert "savedCard?.scrollIntoView({block:'nearest'})" in html