fix: recover mobile workspace loading in place (Closes #1124)
CI / lint (pull_request) Successful in 2m50s
CI / build-release (pull_request) Successful in 6s
CI / browser-journey (pull_request) Successful in 3m1s
CI / release-candidate (pull_request) Has been skipped

This commit is contained in:
timmy committed 2026-08-19 10:10:52 +00:00
1 parent db85bfa5f9
commit 9252807364
4 files changed
+187 -75

No files matched your search

@@ -1,6 +1,7 @@
from __future__ import annotations
import os
import re
import threading
from pathlib import Path
@@ -181,6 +182,59 @@ def test_release_artifact_bootstraps_mobile_home_and_returns_from_insights(
fake_thread.join(timeout=5)
def test_release_artifact_recovers_a_transient_workspace_request_in_place(tmp_path: Path):
archives = sorted((ROOT / "dist").glob("stackchain-dashboard-*.tar.gz"))
assert len(archives) == 1, "browser job must download exactly one assembled release archive"
fake = FakeGiteaServer(("127.0.0.1", 0))
fake_thread = threading.Thread(target=fake.serve_forever, daemon=True)
fake_thread.start()
fake_url = f"http://127.0.0.1:{fake.server_port}"
attempts: list[str] = []
try:
with release_server(archives[0], tmp_path, fake_url) as origin, sync_playwright() as playwright:
browser = playwright.chromium.launch(args=["--ignore-certificate-errors"])
page = browser.new_page(viewport={"width": 390, "height": 844})
page.goto(origin + "/", wait_until="networkidle")
def interrupt_once(route):
attempts.append(route.request.url)
if len(attempts) == 1:
route.abort("failed")
else:
route.continue_()
page.route(re.compile(r"/feature-today-timer-[^/?]+\.js(?:\?.*)?$"), interrupt_once)
page.locator('input[name="device_label"]').fill("Workspace recovery release phone")
page.locator('input[name="access_token"]').fill(ACCESS_TOKEN)
page.locator("#submit-sign-in").click()
page.wait_for_url(origin + "/", wait_until="networkidle")
page.wait_for_timeout(1500)
resources = page.evaluate(
"performance.getEntriesByType('resource').map(entry => entry.name)"
)
state = {
"attempts": attempts,
"resources": resources,
"action": page.locator("#my-work-action-status").text_content(),
"retry_hidden": page.locator("#retry-workspace").is_hidden(),
"work": page.locator("#my-work-status").text_content(),
}
assert len(attempts) == 2, state
assert "2" in (state["work"] or ""), state
expect(page.locator("#retry-workspace")).to_be_hidden()
expect(page.locator("#my-work-action-status")).not_to_contain_text("Workspace unavailable")
assert any("feature-today-timer-" in url and "retry=" in url for url in resources), state
assert page.evaluate("document.documentElement.scrollWidth <= window.innerWidth")
browser.close()
finally:
fake.shutdown()
fake.server_close()
fake_thread.join(timeout=5)
def test_release_artifact_keeps_mobile_delivery_recovery_single_flight(tmp_path: Path):
archives = sorted((ROOT / "dist").glob("stackchain-dashboard-*.tar.gz"))
assert len(archives) == 1, "browser job must download exactly one assembled release archive"